* [PATCH] drm/i915: remove dead code in ironlake_crtc_mode_set
@ 2013-10-18 6:36 Daniel Vetter
2013-10-18 7:44 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2013-10-18 6:36 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
In
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Wed Jun 5 13:34:23 2013 +0200
drm/i915: consolidate pch pll enable sequence
I've removed all the code from this if block, but somehow forgotten to
kill the block itself.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 04c3e1b..38892db 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6072,11 +6072,6 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
else
intel_crtc->lowfreq_avail = false;
- if (intel_crtc->config.has_pch_encoder) {
- pll = intel_crtc_to_shared_dpll(intel_crtc);
-
- }
-
intel_set_pipe_timings(intel_crtc);
if (intel_crtc->config.has_pch_encoder) {
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: remove dead code in ironlake_crtc_mode_set
2013-10-18 6:36 [PATCH] drm/i915: remove dead code in ironlake_crtc_mode_set Daniel Vetter
@ 2013-10-18 7:44 ` Ville Syrjälä
2013-10-18 13:03 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjälä @ 2013-10-18 7:44 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel Graphics Development
On Fri, Oct 18, 2013 at 08:36:36AM +0200, Daniel Vetter wrote:
> In
>
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Jun 5 13:34:23 2013 +0200
>
> drm/i915: consolidate pch pll enable sequence
>
> I've removed all the code from this if block, but somehow forgotten to
> kill the block itself.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 04c3e1b..38892db 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6072,11 +6072,6 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
> else
> intel_crtc->lowfreq_avail = false;
>
> - if (intel_crtc->config.has_pch_encoder) {
> - pll = intel_crtc_to_shared_dpll(intel_crtc);
> -
> - }
> -
> intel_set_pipe_timings(intel_crtc);
>
> if (intel_crtc->config.has_pch_encoder) {
> --
> 1.8.4.rc3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: remove dead code in ironlake_crtc_mode_set
2013-10-18 7:44 ` Ville Syrjälä
@ 2013-10-18 13:03 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2013-10-18 13:03 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Daniel Vetter, Intel Graphics Development
On Fri, Oct 18, 2013 at 10:44:41AM +0300, Ville Syrjälä wrote:
> On Fri, Oct 18, 2013 at 08:36:36AM +0200, Daniel Vetter wrote:
> > In
> >
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Wed Jun 5 13:34:23 2013 +0200
> >
> > drm/i915: consolidate pch pll enable sequence
> >
> > I've removed all the code from this if block, but somehow forgotten to
> > kill the block itself.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Merged, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-18 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-18 6:36 [PATCH] drm/i915: remove dead code in ironlake_crtc_mode_set Daniel Vetter
2013-10-18 7:44 ` Ville Syrjälä
2013-10-18 13:03 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.