Re: [PATCH 1/4] drm: Constify struct drm_info_list * arguments

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Oct 17, 2013 at 07:09:53PM +0100, Damien Lespiau wrote:
> Those functions are just reading data from those pointers.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
for the series.

> ---
>  drivers/gpu/drm/drm_debugfs.c | 4 ++--
>  include/drm/drmP.h            | 9 +++++----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index a05087c..4813ff1 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -84,7 +84,7 @@ static const struct file_operations drm_debugfs_fops = {
>   * Create a given set of debugfs files represented by an array of
>   * gdm_debugfs_lists in the given root directory.
>   */
> -int drm_debugfs_create_files(struct drm_info_list *files, int count,
> +int drm_debugfs_create_files(const struct drm_info_list *files, int count,
>  			     struct dentry *root, struct drm_minor *minor)
>  {
>  	struct drm_device *dev = minor->dev;
> @@ -188,7 +188,7 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id,
>   *
>   * Remove all debugfs entries created by debugfs_init().
>   */
> -int drm_debugfs_remove_files(struct drm_info_list *files, int count,
> +int drm_debugfs_remove_files(const struct drm_info_list *files, int count,
>  			     struct drm_minor *minor)
>  {
>  	struct list_head *pos, *q;
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 2b954ad..c3b659a 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -1470,10 +1470,11 @@ extern struct drm_local_map *drm_getsarea(struct drm_device *dev);
>  #if defined(CONFIG_DEBUG_FS)
>  extern int drm_debugfs_init(struct drm_minor *minor, int minor_id,
>  			    struct dentry *root);
> -extern int drm_debugfs_create_files(struct drm_info_list *files, int count,
> -				    struct dentry *root, struct drm_minor *minor);
> -extern int drm_debugfs_remove_files(struct drm_info_list *files, int count,
> -                                    struct drm_minor *minor);
> +extern int drm_debugfs_create_files(const struct drm_info_list *files,
> +				    int count, struct dentry *root,
> +				    struct drm_minor *minor);
> +extern int drm_debugfs_remove_files(const struct drm_info_list *files,
> +				    int count, struct drm_minor *minor);
>  extern int drm_debugfs_cleanup(struct drm_minor *minor);
>  #endif
>  
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC