From: Greg KH <greg@kroah.com>
To: Angelo Butti <buttiangelo@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: Pericom PCIe Serial board Support (12d8:7952/4/8) - Chip PI7C9X7952/4/8
Date: Sat, 19 Oct 2013 19:51:51 -0700 [thread overview]
Message-ID: <20131020025151.GA31823@kroah.com> (raw)
In-Reply-To: <525D9A56.9080402@gmail.com>
On Tue, Oct 15, 2013 at 10:41:10PM +0300, Angelo Butti wrote:
> On 10/15/2013 08:28 PM, Greg KH wrote:
> > On Tue, Oct 15, 2013 at 07:20:18PM +0200, Angelo Butti wrote:
> >> I'm really sorry for my mistake.
> >
> > No worries, but your email client turned all tabs into spaces, and made
> > the patch imposible to apply :(
> >
> >> Also, maybe that there is a simple way to change the clock without
> >> rewrite the standard serial setup procedure, but I cannot find it ....
> >> Below the correct one:
> >>
> >> --- linux-3.10.11-200.fc19.i686/drivers/tty/serial/8250/8250_pci.c.orig
> >> 2013-09-16 20:13:52.918548000 +0300
> >> +++ linux-3.10.11-200.fc19.i686/drivers/tty/serial/8250/8250_pci.c
> >> 2013-10-15 16:20:18.566685996 +0300
> >> @@ -1308,6 +1308,29 @@ static int pci_default_setup(struct seri
> >> return setup_port(priv, port, bar, offset, board->reg_shift);
> >> }
> >>
> >> +static int pci_pericom_setup(struct serial_private *priv,
> >> + const struct pciserial_board *board,
> >> + struct uart_8250_port *port, int idx)
> >
> > See?
> >
> > Also, we need a "Signed-off-by:" line as per the instructions in the
> > Documentation/SubmittingPatches file (take a look at it for what that
> > means.)
> >
> > Care to try again?
> >
> > thanks,
> >
> > greg k-h
> >
>
> Ok, I change the email client .... I hope ....
The patch was a bit whitespace dammaged, but I fixed it up by hand and
applied it.
thanks,
greg k-h
prev parent reply other threads:[~2013-10-20 7:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 15:25 Pericom PCIe Serial board Support (12d8:7952/4/8) - Chip PI7C9X7952/4/8 Angelo Butti
2013-10-15 13:48 ` Angelo Butti
2013-10-15 14:09 ` Greg KH
2013-10-15 17:20 ` Angelo Butti
2013-10-15 17:28 ` Greg KH
2013-10-15 19:41 ` Angelo Butti
2013-10-20 2:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131020025151.GA31823@kroah.com \
--to=greg@kroah.com \
--cc=buttiangelo@gmail.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.