From: Andrew Lunn <andrew@lunn.ch>
To: Luka Perkov <luka@openwrt.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>,
Jason Cooper <jason@lakedaemon.net>,
rjw@rjwysocki.net, viresh.kumar@linaro.org,
linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/4] cpufreq: Add a cpufreq driver for Marvell Dove
Date: Sun, 20 Oct 2013 10:42:01 +0200 [thread overview]
Message-ID: <20131020084201.GA19257@lunn.ch> (raw)
In-Reply-To: <20131019230908.GA10934@w500.lan>
On Sun, Oct 20, 2013 at 01:09:08AM +0200, Luka Perkov wrote:
> Hi Andrew,
>
> On Sat, Oct 19, 2013 at 02:37:38PM +0200, Andrew Lunn wrote:
> > The Marvell Dove SoC can run the CPU at two frequencies. The high
> > frequencey is from a PLL, while the lower is the same as the DDR
> > clock. Add a cpufreq driver to swap between these frequences.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > drivers/cpufreq/Kconfig.arm | 7 ++
> > drivers/cpufreq/Makefile | 1 +
> > drivers/cpufreq/dove-cpufreq.c | 276 +++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 284 insertions(+)
> > create mode 100644 drivers/cpufreq/dove-cpufreq.c
>
> ...
>
> > --- /dev/null
> > +++ b/drivers/cpufreq/dove-cpufreq.c
> > @@ -0,0 +1,276 @@
> > +/*
> > + * dove_freq.c: cpufreq driver for the Marvell dove
> > + *
> > + * Copyright (C) 2013 Andrew Lunn <andrew@lunn.ch>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version
> > + * 2 of the License, or (at your option) any later version.
> > + */
> > +
> > +#define DEBUG
>
> It seems to me that this define is not used at all...
Hi Luke
Correct. Its left over from my debugging. I will collect more comments
and then remove it in a v2 patchset.
Thanks
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] cpufreq: Add a cpufreq driver for Marvell Dove
Date: Sun, 20 Oct 2013 10:42:01 +0200 [thread overview]
Message-ID: <20131020084201.GA19257@lunn.ch> (raw)
In-Reply-To: <20131019230908.GA10934@w500.lan>
On Sun, Oct 20, 2013 at 01:09:08AM +0200, Luka Perkov wrote:
> Hi Andrew,
>
> On Sat, Oct 19, 2013 at 02:37:38PM +0200, Andrew Lunn wrote:
> > The Marvell Dove SoC can run the CPU at two frequencies. The high
> > frequencey is from a PLL, while the lower is the same as the DDR
> > clock. Add a cpufreq driver to swap between these frequences.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > drivers/cpufreq/Kconfig.arm | 7 ++
> > drivers/cpufreq/Makefile | 1 +
> > drivers/cpufreq/dove-cpufreq.c | 276 +++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 284 insertions(+)
> > create mode 100644 drivers/cpufreq/dove-cpufreq.c
>
> ...
>
> > --- /dev/null
> > +++ b/drivers/cpufreq/dove-cpufreq.c
> > @@ -0,0 +1,276 @@
> > +/*
> > + * dove_freq.c: cpufreq driver for the Marvell dove
> > + *
> > + * Copyright (C) 2013 Andrew Lunn <andrew@lunn.ch>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version
> > + * 2 of the License, or (at your option) any later version.
> > + */
> > +
> > +#define DEBUG
>
> It seems to me that this define is not used at all...
Hi Luke
Correct. Its left over from my debugging. I will collect more comments
and then remove it in a v2 patchset.
Thanks
Andrew
next prev parent reply other threads:[~2013-10-20 8:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 12:37 [PATCH 0/4] Dove cpufreq driver Andrew Lunn
2013-10-19 12:37 ` Andrew Lunn
2013-10-19 12:37 ` [PATCH 1/4] cpufreq: Add a cpufreq driver for Marvell Dove Andrew Lunn
2013-10-19 12:37 ` Andrew Lunn
2013-10-19 23:09 ` Luka Perkov
2013-10-19 23:09 ` Luka Perkov
2013-10-20 8:42 ` Andrew Lunn [this message]
2013-10-20 8:42 ` Andrew Lunn
2013-10-21 10:42 ` Sebastian Hesselbarth
2013-10-21 10:42 ` Sebastian Hesselbarth
2013-10-21 15:42 ` Andrew Lunn
2013-10-21 15:42 ` Andrew Lunn
2013-10-21 16:38 ` Sebastian Hesselbarth
2013-10-21 16:38 ` Sebastian Hesselbarth
2013-10-22 9:01 ` Viresh Kumar
2013-10-22 9:01 ` Viresh Kumar
2013-10-22 15:57 ` Andrew Lunn
2013-10-22 15:57 ` Andrew Lunn
2013-10-23 4:29 ` Viresh Kumar
2013-10-23 4:29 ` Viresh Kumar
2013-10-22 10:19 ` Sudeep KarkadaNagesha
2013-10-22 10:19 ` Sudeep KarkadaNagesha
2013-10-19 12:37 ` [PATCH 2/4] mvebu: Dove: Instantiate cpufreq driver Andrew Lunn
2013-10-19 12:37 ` Andrew Lunn
2013-10-21 10:47 ` Sebastian Hesselbarth
2013-10-21 10:47 ` Sebastian Hesselbarth
2013-10-21 15:26 ` Andrew Lunn
2013-10-21 15:26 ` Andrew Lunn
2013-10-19 12:37 ` [PATCH 3/4] mvebu: Dove: Enable cpufreq driver in defconfig Andrew Lunn
2013-10-19 12:37 ` Andrew Lunn
2013-10-19 12:37 ` [PATCH 4/4] mvebu: Dove: Add clocks and DFS interrupt to cpu node in DT Andrew Lunn
2013-10-19 12:37 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2013-10-23 13:04 [PATCH 1/4] cpufreq: Add a cpufreq driver for Marvell Dove Andrew Lunn
2013-10-23 13:04 ` Andrew Lunn
2013-10-23 13:40 ` Viresh Kumar
2013-10-23 13:40 ` Viresh Kumar
2013-10-23 13:51 ` Andrew Lunn
2013-10-23 13:51 ` Andrew Lunn
2013-10-23 14:25 ` Viresh Kumar
2013-10-23 14:25 ` Viresh Kumar
2013-10-23 14:36 ` Andrew Lunn
2013-10-23 14:36 ` Andrew Lunn
2013-10-23 15:00 ` Viresh Kumar
2013-10-23 15:00 ` Viresh Kumar
2013-10-23 14:59 ` Andrew Lunn
2013-10-23 14:59 ` Andrew Lunn
2013-10-24 2:17 ` Viresh Kumar
2013-10-24 2:17 ` Viresh Kumar
2013-10-28 11:31 ` Andrew Lunn
2013-10-28 11:31 ` Andrew Lunn
2013-10-29 11:33 ` Viresh Kumar
2013-10-29 11:33 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131020084201.GA19257@lunn.ch \
--to=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=luka@openwrt.org \
--cc=rjw@rjwysocki.net \
--cc=sebastian.hesselbarth@googlemail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.