From: Andrew Jones <drjones@redhat.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, gleb@redhat.com
Subject: Re: [PATCH 3/9] clean root dir of all x86-ness
Date: Sun, 20 Oct 2013 18:37:26 +0200 [thread overview]
Message-ID: <20131020163725.GB2072@hawk.usersys.redhat.com> (raw)
In-Reply-To: <20131017190152.GT24837@cbox>
On Thu, Oct 17, 2013 at 12:01:52PM -0700, Christoffer Dall wrote:
> On Thu, Oct 17, 2013 at 11:35:09AM +0200, Andrew Jones wrote:
> > On Wed, Oct 16, 2013 at 06:06:06PM -0700, Christoffer Dall wrote:
> > > > -The exit status of the binary (and the script) is inconsistent: with
> > > > -qemu-system, after the unittest is done, the exit status of qemu is 1,
> > > > -different from the 'old style' qemu-kvm, whose exit status in successful
> > > > -completion is 0.
> > > > +To create the tests' images do
> > >
> > > tests' images doesn't read very nice, can we just say test images?
> >
> > OK
> >
> > >
> > > > + ./configure
> > > > + make
> > > > +in this directory. Tests' images are created in ./<ARCH>/*.flat
> > > > +
> > > > +Then use the runner script to detect the correct invocation and
> > > > +invoke the test, e.g.
> > > > + ./x86-run ./x86/msr.flat
> > > > +or
> > > > + ./run_tests.sh
> > > > +to run them all.
> > >
> > > While you're at it, it would be great to provide a little more context
> > > in the README file.
> > >
> > > For example, we start talking abouter 'runner scripts', we refer to
> > > something called '.flat', and we refer to QEMU without explaining how
> > > this whole thing works, what the components are, what is required of
> > > QEMU etc.
> > >
> > > I think that would be useful for the wider adoption of kvm-unit-tests to
> > > developers writing ad-hoc patches for KVM.
> > >
> > > A reference to docs/testdev.txt from somewhere approrpriate in such text
> > > would probably also be useful...
> > >
> > > I know much of this is arch-specific, but there must be something
> > > generic or common across the architecture, and that would in essense be
> > > capturing what 'kvm-unit-tests' give you, which I think is very useful
> > > to have in the readme.
> > >
> >
> > Agreed. I'll see what I can do with the overall documentation. And I need
> > to create an arm/README for arm specific documentation as well.
> >
> We can work on this a bit together as well if you want, I need to get a
> slightly broader understanding of this framework first though. Are you
> going to be at KVM forum?
>
Yup. Already here :-)
drew
next prev parent reply other threads:[~2013-10-20 16:37 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 16:23 [PATCH 0/9] kvm-unit-tests/arm: initial drop Andrew Jones
2013-10-14 16:23 ` [PATCH 1/9] remove unused files Andrew Jones
2013-10-16 12:52 ` Gleb Natapov
2013-10-16 13:13 ` Alexander Graf
2013-10-16 13:13 ` Alexander Graf
2013-10-16 13:18 ` Andrew Jones
2013-10-14 16:23 ` [PATCH 2/9] makefile and run_tests tweaks Andrew Jones
2013-10-14 16:23 ` [PATCH 3/9] clean root dir of all x86-ness Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 9:35 ` Andrew Jones
2013-10-17 19:01 ` Christoffer Dall
2013-10-20 16:37 ` Andrew Jones [this message]
2013-10-14 16:23 ` [PATCH 4/9] Introduce a simple iomap structure Andrew Jones
2013-10-14 16:23 ` [PATCH 5/9] Add halt() and some error codes Andrew Jones
2013-10-14 16:23 ` [PATCH 6/9] Introduce virtio-testdev Andrew Jones
2013-10-15 8:39 ` Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 9:51 ` Andrew Jones
2013-10-17 19:01 ` Christoffer Dall
2013-10-17 1:06 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 7/9] arm: replace arbitrary divisions Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:03 ` Andrew Jones
2013-10-17 18:59 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 8/9] arm: initial drop Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:16 ` Andrew Jones
2013-10-17 13:28 ` Andrew Jones
2013-10-17 18:39 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 9/9] arm: add vectors support Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:38 ` Andrew Jones
2013-10-17 18:58 ` Christoffer Dall
2013-10-20 16:35 ` Andrew Jones
2013-10-21 9:59 ` Christoffer Dall
2013-11-20 23:06 ` [PATCH 0/9] kvm-unit-tests/arm: initial drop María Soler Heredia
2013-11-26 17:23 ` Andrew Jones
2013-12-29 9:24 ` Christoffer Dall
2014-01-02 18:56 ` Andrew Jones
-- strict thread matches above, loose matches on Subject: below --
2013-12-04 16:42 [PATCH 0/9 v2] " Andrew Jones
2013-12-04 16:42 ` [PATCH 3/9] clean root dir of all x86-ness Andrew Jones
2013-12-29 6:30 ` Christoffer Dall
2014-01-02 15:00 ` Andrew Jones
2014-01-02 17:16 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131020163725.GB2072@hawk.usersys.redhat.com \
--to=drjones@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.