From: Alexander Graf <agraf@suse.de>
To: Gleb Natapov <gleb@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
christoffer.dall@linaro.org, kvm-ppc <kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH 1/9] remove unused files
Date: Wed, 16 Oct 2013 13:13:06 +0000 [thread overview]
Message-ID: <525E90E2.4040203@suse.de> (raw)
In-Reply-To: <20131016125243.GF15657@redhat.com>
On 10/16/2013 02:52 PM, Gleb Natapov wrote:
> Copying Alex in case he has an opinion about removing powerpc.
I would prefer to see it fixed and actually get unit tests, but the code
that's there is trivial enough to not really make an impact on that. So
no real complaints from my side.
Alex
>
> On Mon, Oct 14, 2013 at 06:23:27PM +0200, Andrew Jones wrote:
>> There are several unused files, primarily because powerpc is an unused
>> arch. The exceptions are config-ia64.mak, which is also an unused arch
>> file, lib/fwcfg.c, lib/panic.c, x86/print.h and x86/run-kvm-unit-tests,
>> which are just unused. Remove them all in order to tidy things up.
>>
>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>> ---
>> Makefile | 8 +-
>> config-ia64.mak | 7 -
>> config-powerpc-440.mak | 15 -
>> config-powerpc.mak | 39 ---
>> formats | 31 --
>> iotable.c | 53 ----
>> iotable.h | 40 ---
>> kvmtrace.c | 706 ---------------------------------------------
>> kvmtrace_format | 532 ----------------------------------
>> lib/fwcfg.c | 58 ----
>> lib/libcflat.h | 1 -
>> lib/panic.c | 13 -
>> lib/powerpc/44x/map.c | 51 ----
>> lib/powerpc/44x/timebase.S | 28 --
>> lib/powerpc/44x/timebase.h | 25 --
>> lib/powerpc/44x/tlbwe.S | 29 --
>> lib/powerpc/io.c | 35 ---
>> main-ppc.c | 383 ------------------------
>> powerpc/44x/tlbsx.S | 33 ---
>> powerpc/44x/tlbwe.S | 27 --
>> powerpc/44x/tlbwe_16KB.S | 35 ---
>> powerpc/44x/tlbwe_hole.S | 27 --
>> powerpc/cstart.S | 38 ---
>> powerpc/exit.c | 23 --
>> powerpc/helloworld.c | 27 --
>> powerpc/io.S | 32 --
>> powerpc/spin.S | 4 -
>> powerpc/sprg.S | 7 -
>> x86/print.h | 19 --
>> x86/run-kvm-unit-tests | 6 -
>> 30 files changed, 1 insertion(+), 2331 deletions(-)
>> delete mode 100644 config-ia64.mak
>> delete mode 100644 config-powerpc-440.mak
>> delete mode 100644 config-powerpc.mak
>> delete mode 100644 formats
>> delete mode 100644 iotable.c
>> delete mode 100644 iotable.h
>> delete mode 100644 kvmtrace.c
>> delete mode 100755 kvmtrace_format
>> delete mode 100644 lib/fwcfg.c
>> delete mode 100644 lib/panic.c
>> delete mode 100644 lib/powerpc/44x/map.c
>> delete mode 100644 lib/powerpc/44x/timebase.S
>> delete mode 100644 lib/powerpc/44x/timebase.h
>> delete mode 100644 lib/powerpc/44x/tlbwe.S
>> delete mode 100644 lib/powerpc/io.c
>> delete mode 100644 main-ppc.c
>> delete mode 100644 powerpc/44x/tlbsx.S
>> delete mode 100644 powerpc/44x/tlbwe.S
>> delete mode 100644 powerpc/44x/tlbwe_16KB.S
>> delete mode 100644 powerpc/44x/tlbwe_hole.S
>> delete mode 100644 powerpc/cstart.S
>> delete mode 100644 powerpc/exit.c
>> delete mode 100644 powerpc/helloworld.c
>> delete mode 100644 powerpc/io.S
>> delete mode 100644 powerpc/spin.S
>> delete mode 100644 powerpc/sprg.S
>> delete mode 100644 x86/print.h
>> delete mode 100644 x86/run-kvm-unit-tests
>>
[...]
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Gleb Natapov <gleb@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
christoffer.dall@linaro.org, kvm-ppc <kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH 1/9] remove unused files
Date: Wed, 16 Oct 2013 15:13:06 +0200 [thread overview]
Message-ID: <525E90E2.4040203@suse.de> (raw)
In-Reply-To: <20131016125243.GF15657@redhat.com>
On 10/16/2013 02:52 PM, Gleb Natapov wrote:
> Copying Alex in case he has an opinion about removing powerpc.
I would prefer to see it fixed and actually get unit tests, but the code
that's there is trivial enough to not really make an impact on that. So
no real complaints from my side.
Alex
>
> On Mon, Oct 14, 2013 at 06:23:27PM +0200, Andrew Jones wrote:
>> There are several unused files, primarily because powerpc is an unused
>> arch. The exceptions are config-ia64.mak, which is also an unused arch
>> file, lib/fwcfg.c, lib/panic.c, x86/print.h and x86/run-kvm-unit-tests,
>> which are just unused. Remove them all in order to tidy things up.
>>
>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>> ---
>> Makefile | 8 +-
>> config-ia64.mak | 7 -
>> config-powerpc-440.mak | 15 -
>> config-powerpc.mak | 39 ---
>> formats | 31 --
>> iotable.c | 53 ----
>> iotable.h | 40 ---
>> kvmtrace.c | 706 ---------------------------------------------
>> kvmtrace_format | 532 ----------------------------------
>> lib/fwcfg.c | 58 ----
>> lib/libcflat.h | 1 -
>> lib/panic.c | 13 -
>> lib/powerpc/44x/map.c | 51 ----
>> lib/powerpc/44x/timebase.S | 28 --
>> lib/powerpc/44x/timebase.h | 25 --
>> lib/powerpc/44x/tlbwe.S | 29 --
>> lib/powerpc/io.c | 35 ---
>> main-ppc.c | 383 ------------------------
>> powerpc/44x/tlbsx.S | 33 ---
>> powerpc/44x/tlbwe.S | 27 --
>> powerpc/44x/tlbwe_16KB.S | 35 ---
>> powerpc/44x/tlbwe_hole.S | 27 --
>> powerpc/cstart.S | 38 ---
>> powerpc/exit.c | 23 --
>> powerpc/helloworld.c | 27 --
>> powerpc/io.S | 32 --
>> powerpc/spin.S | 4 -
>> powerpc/sprg.S | 7 -
>> x86/print.h | 19 --
>> x86/run-kvm-unit-tests | 6 -
>> 30 files changed, 1 insertion(+), 2331 deletions(-)
>> delete mode 100644 config-ia64.mak
>> delete mode 100644 config-powerpc-440.mak
>> delete mode 100644 config-powerpc.mak
>> delete mode 100644 formats
>> delete mode 100644 iotable.c
>> delete mode 100644 iotable.h
>> delete mode 100644 kvmtrace.c
>> delete mode 100755 kvmtrace_format
>> delete mode 100644 lib/fwcfg.c
>> delete mode 100644 lib/panic.c
>> delete mode 100644 lib/powerpc/44x/map.c
>> delete mode 100644 lib/powerpc/44x/timebase.S
>> delete mode 100644 lib/powerpc/44x/timebase.h
>> delete mode 100644 lib/powerpc/44x/tlbwe.S
>> delete mode 100644 lib/powerpc/io.c
>> delete mode 100644 main-ppc.c
>> delete mode 100644 powerpc/44x/tlbsx.S
>> delete mode 100644 powerpc/44x/tlbwe.S
>> delete mode 100644 powerpc/44x/tlbwe_16KB.S
>> delete mode 100644 powerpc/44x/tlbwe_hole.S
>> delete mode 100644 powerpc/cstart.S
>> delete mode 100644 powerpc/exit.c
>> delete mode 100644 powerpc/helloworld.c
>> delete mode 100644 powerpc/io.S
>> delete mode 100644 powerpc/spin.S
>> delete mode 100644 powerpc/sprg.S
>> delete mode 100644 x86/print.h
>> delete mode 100644 x86/run-kvm-unit-tests
>>
[...]
next prev parent reply other threads:[~2013-10-16 13:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 16:23 [PATCH 0/9] kvm-unit-tests/arm: initial drop Andrew Jones
2013-10-14 16:23 ` [PATCH 1/9] remove unused files Andrew Jones
2013-10-16 12:52 ` Gleb Natapov
2013-10-16 13:13 ` Alexander Graf [this message]
2013-10-16 13:13 ` Alexander Graf
2013-10-16 13:18 ` Andrew Jones
2013-10-14 16:23 ` [PATCH 2/9] makefile and run_tests tweaks Andrew Jones
2013-10-14 16:23 ` [PATCH 3/9] clean root dir of all x86-ness Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 9:35 ` Andrew Jones
2013-10-17 19:01 ` Christoffer Dall
2013-10-20 16:37 ` Andrew Jones
2013-10-14 16:23 ` [PATCH 4/9] Introduce a simple iomap structure Andrew Jones
2013-10-14 16:23 ` [PATCH 5/9] Add halt() and some error codes Andrew Jones
2013-10-14 16:23 ` [PATCH 6/9] Introduce virtio-testdev Andrew Jones
2013-10-15 8:39 ` Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 9:51 ` Andrew Jones
2013-10-17 19:01 ` Christoffer Dall
2013-10-17 1:06 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 7/9] arm: replace arbitrary divisions Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:03 ` Andrew Jones
2013-10-17 18:59 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 8/9] arm: initial drop Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:16 ` Andrew Jones
2013-10-17 13:28 ` Andrew Jones
2013-10-17 18:39 ` Christoffer Dall
2013-10-14 16:23 ` [PATCH 9/9] arm: add vectors support Andrew Jones
2013-10-17 1:06 ` Christoffer Dall
2013-10-17 10:38 ` Andrew Jones
2013-10-17 18:58 ` Christoffer Dall
2013-10-20 16:35 ` Andrew Jones
2013-10-21 9:59 ` Christoffer Dall
2013-11-20 23:06 ` [PATCH 0/9] kvm-unit-tests/arm: initial drop María Soler Heredia
2013-11-26 17:23 ` Andrew Jones
2013-12-29 9:24 ` Christoffer Dall
2014-01-02 18:56 ` Andrew Jones
-- strict thread matches above, loose matches on Subject: below --
2013-12-04 16:42 [PATCH 0/9 v2] " Andrew Jones
2013-12-04 16:42 ` [PATCH 1/9] remove unused files Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E90E2.4040203@suse.de \
--to=agraf@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.