From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data
Date: Tue, 22 Oct 2013 11:15:40 +0300 [thread overview]
Message-ID: <20131022081540.GD13047@intel.com> (raw)
In-Reply-To: <CAKMK7uEVAPc5tTAWh5xtzqT+rhXU_+TR6SAu=WswAh90ehGSvA@mail.gmail.com>
On Mon, Oct 21, 2013 at 10:54:16PM +0200, Daniel Vetter wrote:
> On Mon, Oct 21, 2013 at 10:47 PM, Damien Lespiau
> <damien.lespiau@intel.com> wrote:
> > On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote:
> >> Adding stuff to the bottom of struct drm_i915_driver_private is
> >> nowadays considered uncool.
> >>
> >> Cc: Damien Lespiau <damien.lespiau@intel.com>
> >> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Ville was suggesting moving the pipe_crc struct into intel_crtc. Might
> > be even better! But anyway:
>
> We enable interrupts before we allocate the intel_crtc structs. So if
> we'd store the CRC stuff in there we'd need to be a bit more paranoid
> with clearing hw state (since every time we trust the BIOS we end up
> burning our hands). So I think this is safer ...
FLIP_DONE etc. interrupts already depend on the crtc being there. Not
sure why this is different.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-10-22 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 19:10 [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data Daniel Vetter
2013-10-21 20:47 ` Damien Lespiau
2013-10-21 20:54 ` Daniel Vetter
2013-10-22 8:15 ` Ville Syrjälä [this message]
2013-10-22 9:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022081540.GD13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.