From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6][ 3/7] ARM: imx{25,27} DT: Permit the selection of the imxfb framebuffer driver.
Date: Thu, 24 Oct 2013 10:36:16 +0200 [thread overview]
Message-ID: <20131024103616.0b28b922@e6520eb> (raw)
In-Reply-To: <20131024083143.GB13614@S2101-09.ap.freescale.net>
Hi Shawn,
Le Thu, 24 Oct 2013 16:31:45 +0800,
Shawn Guo <shawn.guo@linaro.org> a ?crit :
> On Thu, Oct 24, 2013 at 10:20:11AM +0200, Eric B?nard wrote:
> > Hi Shawn,
> >
> > Le Thu, 24 Oct 2013 16:15:34 +0800,
> > Shawn Guo <shawn.guo@linaro.org> a ?crit :
> > > > config FB_IMX
> > > > tristate "Freescale i.MX1/21/25/27 LCD support"
> > > > - depends on FB && IMX_HAVE_PLATFORM_IMX_FB
> > > > + depends on FB && HAVE_IMX_FB
> > >
> > > Or simply have it depend on ARCH_MXC?
> > >
> > > depends on FB && ARCH_MXC
> > >
> > but not all MXC have IMX_FB : isn't that a problem ?
>
> Is it really a problem that you see this option when you configure an
> imx51 kernel? The prompt clearly tells you do not need this option for
> an imx51 kernel. Or will it cause any real problem even if you select
> it for an imx51 kernel, except you build in a driver which will never be
> instantiated? I've seen drivers even start drop ARCH_* dependency to
> get a better randconfig build test coverage.
>
not really a problem for me. If the policy is not to narrow the choices
to only the SOC which have the peripheral then we follow it and take
your ARCH_MXC approach which is far simpler.
Thanks,
Eric
WARNING: multiple messages have this Message-ID (diff)
From: "Eric Bénard" <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Subject: Re: [PATCHv6][ 3/7] ARM: imx{25,27} DT: Permit the selection of the imxfb framebuffer driver.
Date: Thu, 24 Oct 2013 10:36:16 +0200 [thread overview]
Message-ID: <20131024103616.0b28b922@e6520eb> (raw)
In-Reply-To: <20131024083143.GB13614-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
Hi Shawn,
Le Thu, 24 Oct 2013 16:31:45 +0800,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> a écrit :
> On Thu, Oct 24, 2013 at 10:20:11AM +0200, Eric Bénard wrote:
> > Hi Shawn,
> >
> > Le Thu, 24 Oct 2013 16:15:34 +0800,
> > Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> a écrit :
> > > > config FB_IMX
> > > > tristate "Freescale i.MX1/21/25/27 LCD support"
> > > > - depends on FB && IMX_HAVE_PLATFORM_IMX_FB
> > > > + depends on FB && HAVE_IMX_FB
> > >
> > > Or simply have it depend on ARCH_MXC?
> > >
> > > depends on FB && ARCH_MXC
> > >
> > but not all MXC have IMX_FB : isn't that a problem ?
>
> Is it really a problem that you see this option when you configure an
> imx51 kernel? The prompt clearly tells you do not need this option for
> an imx51 kernel. Or will it cause any real problem even if you select
> it for an imx51 kernel, except you build in a driver which will never be
> instantiated? I've seen drivers even start drop ARCH_* dependency to
> get a better randconfig build test coverage.
>
not really a problem for me. If the policy is not to narrow the choices
to only the SOC which have the peripheral then we follow it and take
your ARCH_MXC approach which is far simpler.
Thanks,
Eric
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-24 8:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 8:00 [PATCHv6][ 1/7] video: imxfb: Introduce regulator support Denis Carikli
2013-10-24 8:00 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 2/7] video: imxfb: Also add pwmr for the device tree Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 3/7] ARM: imx{25, 27} DT: Permit the selection of the imxfb framebuffer driver Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 3/7] ARM: imx{25,27} " Denis Carikli
2013-10-24 8:15 ` Shawn Guo
2013-10-24 8:15 ` Shawn Guo
2013-10-24 8:20 ` Eric Bénard
2013-10-24 8:20 ` Eric Bénard
2013-10-24 8:31 ` Shawn Guo
2013-10-24 8:31 ` Shawn Guo
2013-10-24 8:36 ` Eric Bénard [this message]
2013-10-24 8:36 ` Eric Bénard
2013-10-24 8:01 ` [PATCHv6][ 4/7] pinctrl: pinctrl-imx: add imx25 pinctrl driver Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 5/7] ARM: dts: imx25.dtsi: Add some pinmux pins Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 6/7] ARM: dts: Add support for the cpuimx25 board from Eukrea and its baseboard Denis Carikli
2013-10-24 8:01 ` Denis Carikli
2013-10-24 8:01 ` [PATCHv6][ 7/7] ARM: imx_v4_v5_defconfig: Enable gpio regulator and gpio button/keyboard Denis Carikli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024103616.0b28b922@e6520eb \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.