From: Vinod Koul <vinod.koul@intel.com>
To: Joel Fernandes <joelf@ti.com>, dmaengine@vger.kernel.org
Cc: Matt Porter <matt@ohporter.com>, Mark Brown <broonie@linaro.org>,
Russell King <linux@arm.linux.org.uk>, Dan Williams <djbw@fb.com>,
Jyri Sarha <jsarha@ti.com>, Lars Peter-Clausen <lars@metafoo.de>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA
Date: Thu, 24 Oct 2013 22:08:29 +0530 [thread overview]
Message-ID: <20131024163829.GA21230@intel.com> (raw)
In-Reply-To: <52669A23.2080805@ti.com>
On Tue, Oct 22, 2013 at 10:30:43AM -0500, Joel Fernandes wrote:
> On 10/21/2013 01:53 AM, Vinod Koul wrote:
> > On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote:
> >> + nr_periods = (buf_len / period_len) + 1;
> > ?
> >
> > consider the case of buf = period_len, above makes nr_period = 2.
> >
> > Or buf len 100, period len 50, makes nr_period = 3
> >
> > Both doesnt seem right to me?
>
> I guess that variable name is misleading.
>
> nr_periods is actually the total no.of slots needed to process the request. Its
> value is 1 greater than the total number of periods.
Okay sounds good to me. I tried applying below but looks like it fails as I have
already applied, 1 & 3. Can you pls rebase this resend
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] dma: edma: Add support for Cyclic DMA
Date: Thu, 24 Oct 2013 22:08:29 +0530 [thread overview]
Message-ID: <20131024163829.GA21230@intel.com> (raw)
In-Reply-To: <52669A23.2080805@ti.com>
On Tue, Oct 22, 2013 at 10:30:43AM -0500, Joel Fernandes wrote:
> On 10/21/2013 01:53 AM, Vinod Koul wrote:
> > On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote:
> >> + nr_periods = (buf_len / period_len) + 1;
> > ?
> >
> > consider the case of buf = period_len, above makes nr_period = 2.
> >
> > Or buf len 100, period len 50, makes nr_period = 3
> >
> > Both doesnt seem right to me?
>
> I guess that variable name is misleading.
>
> nr_periods is actually the total no.of slots needed to process the request. Its
> value is 1 greater than the total number of periods.
Okay sounds good to me. I tried applying below but looks like it fails as I have
already applied, 1 & 3. Can you pls rebase this resend
--
~Vinod
next prev parent reply other threads:[~2013-10-24 16:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 23:05 [PATCH 0/3] dma: edma: Add cyclic DMA support Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
[not found] ` <1379977515-3794-1-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
2013-09-23 23:05 ` [PATCH 1/3] dma: edma: Split out PaRAM set calculations into its own function Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
2013-10-21 7:26 ` Vinod Koul
2013-10-21 7:26 ` Vinod Koul
2013-09-23 23:05 ` [PATCH 2/3] dma: edma: Add support for Cyclic DMA Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
2013-10-21 6:53 ` Vinod Koul
2013-10-21 6:53 ` Vinod Koul
[not found] ` <20131021065319.GM14013-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-10-22 15:30 ` Joel Fernandes
2013-10-22 15:30 ` Joel Fernandes
2013-10-22 15:30 ` Joel Fernandes
2013-10-24 16:38 ` Vinod Koul [this message]
2013-10-24 16:38 ` Vinod Koul
[not found] ` <20131024163829.GA21230-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-10-24 17:57 ` Joel Fernandes
2013-10-24 17:57 ` Joel Fernandes
2013-10-24 17:57 ` Joel Fernandes
2013-10-31 14:10 ` Vinod Koul
2013-10-31 14:10 ` Vinod Koul
[not found] ` <20131031141012.GJ18788-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-10-31 16:03 ` Joel Fernandes
2013-10-31 16:03 ` Joel Fernandes
2013-10-31 16:03 ` Joel Fernandes
2013-09-23 23:05 ` [PATCH 3/3] dma: edma: Increase maximum SG limit to 20 Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
2013-09-23 23:05 ` Joel Fernandes
2013-10-21 7:26 ` Vinod Koul
2013-10-21 7:26 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024163829.GA21230@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@linaro.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=djbw@fb.com \
--cc=dmaengine@vger.kernel.org \
--cc=joelf@ti.com \
--cc=jsarha@ti.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt@ohporter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.