* [PATCH] libertas/sdio: make sure card enters power-off when firmware is loaded.
@ 2013-10-24 7:33 NeilBrown
0 siblings, 0 replies; only message in thread
From: NeilBrown @ 2013-10-24 7:33 UTC (permalink / raw)
To: John W. Linville, Bing Zhao, Dan Williams
Cc: libertas-dev, linux-wireless, Belisko Marek,
Dr. H. Nikolaus Schaller, Daniel Drake
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Since firmware loading became async it is possible that if_sdio_finish_power_of
is called with only one remaining runtime_pm reference, so it isn't safe
to call pm_runtime_put_noidle. We must call pm_runtime_put().
Diagnosed-by: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/drivers/net/wireless/libertas/if_sdio.c b/drivers/net/wireless/libertas/if_sdio.c
index 4557833..a39318b 100644
--- a/drivers/net/wireless/libertas/if_sdio.c
+++ b/drivers/net/wireless/libertas/if_sdio.c
@@ -853,7 +853,7 @@ static void if_sdio_finish_power_on(struct if_sdio_card *card)
card->started = true;
/* Tell PM core that we don't need the card to be
* powered now */
- pm_runtime_put_noidle(&func->dev);
+ pm_runtime_put(&func->dev);
}
}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-10-24 7:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-24 7:33 [PATCH] libertas/sdio: make sure card enters power-off when firmware is loaded NeilBrown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.