From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Rhyland Klein <rklein@nvidia.com>,
David Woodhouse <dwmw2@infradead.org>,
Thierry Reding <thierry.reding@gmail.com>,
Darbha Sriharsha <dsriharsha@nvidia.com>,
Manish Badarkha <badarkhe.manish@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [Patch V5] drivers: power: Add support for bq24735 charger
Date: Fri, 25 Oct 2013 15:48:41 -0700 [thread overview]
Message-ID: <20131025224841.GB1157@teo> (raw)
In-Reply-To: <525C3A9A.5000207@wwwdotorg.org>
On Mon, Oct 14, 2013 at 12:40:26PM -0600, Stephen Warren wrote:
> >>> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> >>
> >>> +Optional properties :
> >>
> >>> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter
> >>> + presence.
> >>
> >> Is that actually a property of the BQ24735 chip itself (i.e. is it an
> >> output signal from the chip), or part of the board/system?
> >
> > The gpio itself is actually what the IRQ line is tied to from the
> > bq24735 -> tegra (in this case). In other words this is a Host GPIO that
> > is configured as an input and connected to the bq24735.
>
> Ok, so this is the ACOK output pin? In that case, it's fine. It might be
> worth mentioning that explicitly though.
I added the comment to the documentation and applied the patch with a
"Thanks-to: Stephen Warren <swarren@wwwdotorg.org>" tag. :)
Anton
next prev parent reply other threads:[~2013-10-25 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 21:15 [Patch V5] drivers: power: Add support for bq24735 charger Rhyland Klein
2013-10-11 21:15 ` Rhyland Klein
[not found] ` <1381526143-20800-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-14 18:21 ` Stephen Warren
2013-10-14 18:21 ` Stephen Warren
2013-10-14 18:26 ` Rhyland Klein
[not found] ` <525C376A.3000009-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-14 18:40 ` Stephen Warren
2013-10-14 18:40 ` Stephen Warren
2013-10-25 22:48 ` Anton Vorontsov [this message]
2013-10-25 22:55 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025224841.GB1157@teo \
--to=anton.vorontsov@linaro.org \
--cc=Mark.Rutland@arm.com \
--cc=badarkhe.manish@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dsriharsha@nvidia.com \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rklein@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.