From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Anton Vorontsov <anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Darbha Sriharsha
<dsriharsha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Manish Badarkha
<badarkhe.manish-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [Patch V5] drivers: power: Add support for bq24735 charger
Date: Mon, 14 Oct 2013 12:21:16 -0600 [thread overview]
Message-ID: <525C361C.1020703@wwwdotorg.org> (raw)
In-Reply-To: <1381526143-20800-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 10/11/2013 03:15 PM, Rhyland Klein wrote:
> From: Darbha Sriharsha <dsriharsha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Adds support for the bq24735 charger chipset. The bq24735 is a
> high-efficiency, synchronous battery charger.
>
> It allows control of the charging current, input current, and the charger
> voltage DAC's through SMBus.
Please CC the DT bindings maintainers on patches that add DT bindings.
> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> +Optional properties :
> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter
> + presence.
Is that actually a property of the BQ24735 chip itself (i.e. is it an
output signal from the chip), or part of the board/system?
Aside from that, the binding looks reasonable to me (although I'm no
longer a DT bindings maintainer).
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Rhyland Klein <rklein@nvidia.com>,
Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Thierry Reding <thierry.reding@gmail.com>,
Darbha Sriharsha <dsriharsha@nvidia.com>,
Manish Badarkha <badarkhe.manish@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Rutland <Mark.Rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [Patch V5] drivers: power: Add support for bq24735 charger
Date: Mon, 14 Oct 2013 12:21:16 -0600 [thread overview]
Message-ID: <525C361C.1020703@wwwdotorg.org> (raw)
In-Reply-To: <1381526143-20800-1-git-send-email-rklein@nvidia.com>
On 10/11/2013 03:15 PM, Rhyland Klein wrote:
> From: Darbha Sriharsha <dsriharsha@nvidia.com>
>
> Adds support for the bq24735 charger chipset. The bq24735 is a
> high-efficiency, synchronous battery charger.
>
> It allows control of the charging current, input current, and the charger
> voltage DAC's through SMBus.
Please CC the DT bindings maintainers on patches that add DT bindings.
> diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
> +Optional properties :
> + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter
> + presence.
Is that actually a property of the BQ24735 chip itself (i.e. is it an
output signal from the chip), or part of the board/system?
Aside from that, the binding looks reasonable to me (although I'm no
longer a DT bindings maintainer).
next prev parent reply other threads:[~2013-10-14 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 21:15 [Patch V5] drivers: power: Add support for bq24735 charger Rhyland Klein
2013-10-11 21:15 ` Rhyland Klein
[not found] ` <1381526143-20800-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-14 18:21 ` Stephen Warren [this message]
2013-10-14 18:21 ` Stephen Warren
2013-10-14 18:26 ` Rhyland Klein
[not found] ` <525C376A.3000009-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-14 18:40 ` Stephen Warren
2013-10-14 18:40 ` Stephen Warren
2013-10-25 22:48 ` Anton Vorontsov
2013-10-25 22:55 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525C361C.1020703@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=Mark.Rutland-5wv7dgnIgG8@public.gmane.org \
--cc=anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org \
--cc=badarkhe.manish-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dsriharsha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.