Re: [PATCH 2/5] mtd: m25p80: remove obsolete FIXME

[Marek Vasut <marex@denx.de>]

Hi Brian,

> The FIXME and NOTE have already been fixed (we have FAST_READ support).
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
>  drivers/mtd/devices/m25p80.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 63a95ac..7c4cbad 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -367,10 +367,6 @@ static int m25p80_read(struct mtd_info *mtd, loff_t
> from, size_t len, spi_message_init(&m);
>  	memset(t, 0, (sizeof t));
> 
> -	/* NOTE:
> -	 * OPCODE_FAST_READ (if available) is faster.
> -	 * Should add 1 byte DUMMY_BYTE.
> -	 */
>  	t[0].tx_buf = flash->command;
>  	t[0].len = m25p_cmdsz(flash) + (flash->fast_read ? 1 : 0);
>  	spi_message_add_tail(&t[0], &m);
> @@ -388,11 +384,6 @@ static int m25p80_read(struct mtd_info *mtd, loff_t
> from, size_t len, return 1;
>  	}
> 
> -	/* FIXME switch to OPCODE_FAST_READ.  It's required for higher
> -	 * clocks; and at this writing, every chip this driver handles
> -	 * supports that opcode.
> -	 */
> -
>  	/* Set up the write data buffer. */
>  	opcode = flash->read_opcode;
>  	flash->command[0] = opcode;

Makes great share of sense ;-)

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut