From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Marek Vasut <marex@denx.de>,
sourav.poddar@ti.com, Brian Norris <computersforpeace@gmail.com>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: [PATCH 2/5] mtd: m25p80: remove obsolete FIXME
Date: Wed, 23 Oct 2013 19:58:20 -0700 [thread overview]
Message-ID: <1382583503-13748-2-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1382583503-13748-1-git-send-email-computersforpeace@gmail.com>
The FIXME and NOTE have already been fixed (we have FAST_READ support).
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/mtd/devices/m25p80.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 63a95ac..7c4cbad 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -367,10 +367,6 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
spi_message_init(&m);
memset(t, 0, (sizeof t));
- /* NOTE:
- * OPCODE_FAST_READ (if available) is faster.
- * Should add 1 byte DUMMY_BYTE.
- */
t[0].tx_buf = flash->command;
t[0].len = m25p_cmdsz(flash) + (flash->fast_read ? 1 : 0);
spi_message_add_tail(&t[0], &m);
@@ -388,11 +384,6 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
return 1;
}
- /* FIXME switch to OPCODE_FAST_READ. It's required for higher
- * clocks; and at this writing, every chip this driver handles
- * supports that opcode.
- */
-
/* Set up the write data buffer. */
opcode = flash->read_opcode;
flash->command[0] = opcode;
--
1.8.4
next prev parent reply other threads:[~2013-10-24 2:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 2:58 [PATCH 1/5] mtd: m25p80: fix allocation size Brian Norris
2013-10-24 2:58 ` Brian Norris [this message]
2013-10-24 9:01 ` [PATCH 2/5] mtd: m25p80: remove obsolete FIXME Sourav Poddar
2013-10-27 16:30 ` Marek Vasut
2013-10-24 2:58 ` [PATCH 3/5] mtd: m25p80: re-align ID entries Brian Norris
2013-10-24 9:01 ` Sourav Poddar
2013-10-24 2:58 ` [PATCH 4/5] mtd: m25p80: remove M25PXX_USE_FAST_READ Kconfig Brian Norris
2013-10-24 9:07 ` Sourav Poddar
2013-10-24 9:12 ` Sourav Poddar
2013-10-24 17:39 ` Brian Norris
2013-10-24 18:48 ` Sourav Poddar
2013-10-25 17:59 ` Brian Norris
2013-10-27 16:32 ` Marek Vasut
2013-10-30 23:38 ` Brian Norris
2013-10-31 9:21 ` Marek Vasut
2013-10-31 9:50 ` Sourav Poddar
2013-10-31 14:55 ` Brian Norris
2013-11-01 12:26 ` Marek Vasut
2013-11-05 3:37 ` Brian Norris
2013-11-05 13:14 ` Marek Vasut
2013-10-24 2:58 ` [PATCH 5/5] mtd: m25p80: remove 'disabled' device check Brian Norris
2013-10-24 2:58 ` Brian Norris
2013-10-24 9:01 ` Sourav Poddar
2013-10-24 9:01 ` Sourav Poddar
2013-10-25 0:15 ` Grant Likely
2013-10-25 0:15 ` Grant Likely
2013-10-25 18:01 ` Brian Norris
2013-10-25 18:01 ` Brian Norris
2013-10-24 9:00 ` [PATCH 1/5] mtd: m25p80: fix allocation size Sourav Poddar
2013-10-24 17:17 ` Brian Norris
2013-10-24 17:56 ` Sourav Poddar
2013-10-27 16:30 ` Marek Vasut
2013-10-27 22:48 ` Brian Norris
2013-10-28 7:54 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382583503-13748-2-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.