From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Dave Young <dyoung@redhat.com>
Cc: kexec@lists.infradead.org, James.Bottomley@HansenPartnership.com,
horms@verge.net.au, kexec@lists.fedoraproject.org,
ebiederm@xmission.com, hpa@zytor.com, bp@alien8.de,
vgoyal@redhat.com
Subject: Re: [patch 2/4] remove extra acpi_rsdp command line for efi
Date: Mon, 28 Oct 2013 10:12:56 +0000 [thread overview]
Message-ID: <20131028101256.GA3226@srcf.ucam.org> (raw)
In-Reply-To: <20131028095459.GE25527@dhcp-16-126.nay.redhat.com>
On Mon, Oct 28, 2013 at 05:54:59PM +0800, Dave Young wrote:
> Hi,
> Thanks for review.
>
> On 10/28/13 at 09:42am, Matthew Garrett wrote:
> > On Sun, Oct 27, 2013 at 12:04:39PM +0800, dyoung@redhat.com wrote:
> > > Removing code to pass acpi_rsdp because this
> > > patch series will support efi runtime, it's not
> > > necessary any more. EFI initialization code will
> > > take the functionality.
> >
> > Won't this break kexec of old kernels that don't have the new UEFI setup
> > code?
>
> For old kernels the efi setup_data esdata will be NULL, it wil switch to
> old logic. Also for old kernel user need to pass acpi_rsdp in cmdline
Right, but previously acpi_rsdp was passed automatically and now it
won't be?
--
Matthew Garrett | mjg59@srcf.ucam.org
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-10-28 10:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 4:04 [patch 0/4] kexec-tools: efi runtime support on kexec kernel dyoung
2013-10-27 4:04 ` [patch 1/4] Add function get_bootparam dyoung
2013-10-28 0:38 ` Simon Horman
2013-10-28 1:13 ` Dave Young
2013-10-28 2:30 ` Dave Young
2013-10-28 4:20 ` Simon Horman
2013-10-28 5:06 ` Dave Young
2013-10-28 6:08 ` Simon Horman
2013-10-27 4:04 ` [patch 2/4] remove extra acpi_rsdp command line for efi dyoung
2013-10-28 0:39 ` Simon Horman
2013-10-28 1:39 ` Dave Young
2013-10-28 9:42 ` Matthew Garrett
2013-10-28 9:54 ` Dave Young
2013-10-28 10:12 ` Matthew Garrett [this message]
2013-10-28 10:34 ` Dave Young
2013-10-28 10:39 ` Matthew Garrett
2013-10-28 10:45 ` Dave Young
2013-10-28 10:51 ` Matthew Garrett
2013-10-28 10:53 ` Dave Young
2013-10-29 3:05 ` Dave Young
2013-10-29 3:34 ` Dave Young
2013-10-29 8:50 ` Dave Young
2013-10-29 14:57 ` H. Peter Anvin
2013-10-28 16:10 ` Vivek Goyal
2013-10-29 2:04 ` Simon Horman
2013-10-29 2:36 ` Dave Young
2013-10-29 3:18 ` Dave Young
2013-10-30 0:45 ` Simon Horman
2013-10-29 13:27 ` Vivek Goyal
2013-10-27 4:04 ` [patch 3/4] Add efi_info in x86 setup header dyoung
2013-10-27 4:04 ` [patch 4/4] Passing efi related data via setup_data dyoung
2013-10-28 0:37 ` Simon Horman
2013-10-28 1:12 ` Dave Young
2013-10-28 3:02 ` Dave Young
2013-10-28 4:16 ` Simon Horman
2013-10-28 1:28 ` Dave Young
2013-10-28 10:41 ` H. Peter Anvin
2013-10-28 11:21 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028101256.GA3226@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.fedoraproject.org \
--cc=kexec@lists.infradead.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.