All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Simon Horman <horms@verge.net.au>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	kexec@lists.infradead.org, James.Bottomley@HansenPartnership.com,
	bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com,
	Dave Young <dyoung@redhat.com>,
	kexec@lists.fedoraproject.org
Subject: Re: [patch 2/4] remove extra acpi_rsdp command line for efi
Date: Tue, 29 Oct 2013 09:27:24 -0400	[thread overview]
Message-ID: <20131029132723.GA11174@redhat.com> (raw)
In-Reply-To: <20131029020428.GC21262@verge.net.au>

On Tue, Oct 29, 2013 at 11:04:28AM +0900, Simon Horman wrote:

[..]
> > > Yes, that's my point. You're breaking old configurations by requiring 
> > > the user to pass an additional argument.
> > 
> > Yes this is a problem. Of course solution is easy by always passing
> > acpi_rsdp on command line. But in long term this is a problem. In the
> > sense, I am not sure how to cleanup the kexec-tools code as things improve.
> > Now we will support the EFI properly and still pass acpi_rsdp always in
> > an effort to matain backward compatibility.
> > 
> > For a very long time kexec-tools were not automatically appending
> > acpi_rsdp and user were supposed to add it on command line. We were
> > carrying this change in kdump scripts and pushed this change into
> > kexec-tools. In hindsight, it looks like that hardcoding parameters
> > in kexec-tools is a bad idea. It is hard to get rid of them in future.
> 
> I tend to agree.  However, if the parameters end up being hard coded
> elsewhere, for example in widely used wrapper scripts, then I think that
> the same problem still exists. Just outside of kexec-tools itself.

I think getting rid of them in vendor scripts is easier beacause control
the range of kexec-tools and kernel version which will be used in a
particular release life cycle. So when we know that we are not going to
support other kernels than vendor shipped kernel, we can remove parameters
from scripts.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2013-10-29 13:28 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-27  4:04 [patch 0/4] kexec-tools: efi runtime support on kexec kernel dyoung
2013-10-27  4:04 ` [patch 1/4] Add function get_bootparam dyoung
2013-10-28  0:38   ` Simon Horman
2013-10-28  1:13     ` Dave Young
2013-10-28  2:30       ` Dave Young
2013-10-28  4:20         ` Simon Horman
2013-10-28  5:06           ` Dave Young
2013-10-28  6:08             ` Simon Horman
2013-10-27  4:04 ` [patch 2/4] remove extra acpi_rsdp command line for efi dyoung
2013-10-28  0:39   ` Simon Horman
2013-10-28  1:39     ` Dave Young
2013-10-28  9:42   ` Matthew Garrett
2013-10-28  9:54     ` Dave Young
2013-10-28 10:12       ` Matthew Garrett
2013-10-28 10:34         ` Dave Young
2013-10-28 10:39           ` Matthew Garrett
2013-10-28 10:45             ` Dave Young
2013-10-28 10:51               ` Matthew Garrett
2013-10-28 10:53                 ` Dave Young
2013-10-29  3:05                   ` Dave Young
2013-10-29  3:34                     ` Dave Young
2013-10-29  8:50                       ` Dave Young
2013-10-29 14:57                         ` H. Peter Anvin
2013-10-28 16:10                 ` Vivek Goyal
2013-10-29  2:04                   ` Simon Horman
2013-10-29  2:36                     ` Dave Young
2013-10-29  3:18                       ` Dave Young
2013-10-30  0:45                       ` Simon Horman
2013-10-29 13:27                     ` Vivek Goyal [this message]
2013-10-27  4:04 ` [patch 3/4] Add efi_info in x86 setup header dyoung
2013-10-27  4:04 ` [patch 4/4] Passing efi related data via setup_data dyoung
2013-10-28  0:37   ` Simon Horman
2013-10-28  1:12     ` Dave Young
2013-10-28  3:02       ` Dave Young
2013-10-28  4:16         ` Simon Horman
2013-10-28  1:28   ` Dave Young
2013-10-28 10:41   ` H. Peter Anvin
2013-10-28 11:21     ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131029132723.GA11174@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.fedoraproject.org \
    --cc=kexec@lists.infradead.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.