From: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [GIT PULL] EFI changes
Date: Mon, 28 Oct 2013 14:44:13 +0100 [thread overview]
Message-ID: <20131028134413.GA10163@gmail.com> (raw)
In-Reply-To: <20131028123528.GM1982-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
* Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> wrote:
> This is a respin of the EFI earlyprintk support with the fix for the
> allmodconfig build breakage that Ingo reported.
>
> The following changes since commit c158c3bf59951bbb44bd7ccca9e6665dfd1617c5:
>
> boot, efi: Remove redundant memset() (2013-10-04 20:07:47 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-next
>
> for you to fetch changes up to 265434a91cf3377d65dc2b6d80065271514b5696:
>
> x86/efi: Add EFI framebuffer earlyprintk support (2013-10-28 11:57:58 +0000)
>
> ----------------------------------------------------------------
> * Add support for earlyprintk=efi which uses the EFI framebuffer. Very
> useful for debugging boot issues.
>
> ----------------------------------------------------------------
> Matt Fleming (2):
> efi: Add asm-generic/efi.h for non-x86
> x86/efi: Add EFI framebuffer earlyprintk support
>
> Documentation/kernel-parameters.txt | 8 +-
> arch/ia64/include/asm/efi.h | 6 ++
> arch/x86/Kconfig.debug | 10 ++
> arch/x86/boot/compressed/eboot.c | 1 -
> arch/x86/include/asm/efi.h | 12 +++
> arch/x86/kernel/early_printk.c | 6 ++
> arch/x86/kernel/setup.c | 1 -
> arch/x86/platform/efi/Makefile | 1 +
> arch/x86/platform/efi/early_printk.c | 191 +++++++++++++++++++++++++++++++++++
> arch/x86/platform/efi/efi.c | 1 -
> arch/x86/platform/efi/efi_32.c | 1 -
> arch/x86/platform/efi/efi_64.c | 1 -
> arch/x86/platform/uv/bios_uv.c | 1 -
> include/asm-generic/efi.h | 17 ++++
> include/linux/efi.h | 31 +-----
> 15 files changed, 250 insertions(+), 38 deletions(-)
> create mode 100644 arch/ia64/include/asm/efi.h
> create mode 100644 arch/x86/platform/efi/early_printk.c
> create mode 100644 include/asm-generic/efi.h
and this breaks the ARM build:
In file included from /home/mingo/tip/init/main.c:44:
/home/mingo/tip/include/linux/efi.h:842:21: error: asm/efi.h: No such file or directory
/home/mingo/tip/init/main.c: In function 'start_kernel':
/home/mingo/tip/init/main.c:638: error: implicit declaration of function 'efi_enabled'
/home/mingo/tip/init/main.c:639: error: implicit declaration of function 'efi_late_init'
/home/mingo/tip/init/main.c:640: error: implicit declaration of function 'efi_free_boot_services'
Thanks,
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] EFI changes
Date: Mon, 28 Oct 2013 14:44:13 +0100 [thread overview]
Message-ID: <20131028134413.GA10163@gmail.com> (raw)
In-Reply-To: <20131028123528.GM1982@console-pimps.org>
* Matt Fleming <matt@console-pimps.org> wrote:
> This is a respin of the EFI earlyprintk support with the fix for the
> allmodconfig build breakage that Ingo reported.
>
> The following changes since commit c158c3bf59951bbb44bd7ccca9e6665dfd1617c5:
>
> boot, efi: Remove redundant memset() (2013-10-04 20:07:47 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-next
>
> for you to fetch changes up to 265434a91cf3377d65dc2b6d80065271514b5696:
>
> x86/efi: Add EFI framebuffer earlyprintk support (2013-10-28 11:57:58 +0000)
>
> ----------------------------------------------------------------
> * Add support for earlyprintk=efi which uses the EFI framebuffer. Very
> useful for debugging boot issues.
>
> ----------------------------------------------------------------
> Matt Fleming (2):
> efi: Add asm-generic/efi.h for non-x86
> x86/efi: Add EFI framebuffer earlyprintk support
>
> Documentation/kernel-parameters.txt | 8 +-
> arch/ia64/include/asm/efi.h | 6 ++
> arch/x86/Kconfig.debug | 10 ++
> arch/x86/boot/compressed/eboot.c | 1 -
> arch/x86/include/asm/efi.h | 12 +++
> arch/x86/kernel/early_printk.c | 6 ++
> arch/x86/kernel/setup.c | 1 -
> arch/x86/platform/efi/Makefile | 1 +
> arch/x86/platform/efi/early_printk.c | 191 +++++++++++++++++++++++++++++++++++
> arch/x86/platform/efi/efi.c | 1 -
> arch/x86/platform/efi/efi_32.c | 1 -
> arch/x86/platform/efi/efi_64.c | 1 -
> arch/x86/platform/uv/bios_uv.c | 1 -
> include/asm-generic/efi.h | 17 ++++
> include/linux/efi.h | 31 +-----
> 15 files changed, 250 insertions(+), 38 deletions(-)
> create mode 100644 arch/ia64/include/asm/efi.h
> create mode 100644 arch/x86/platform/efi/early_printk.c
> create mode 100644 include/asm-generic/efi.h
and this breaks the ARM build:
In file included from /home/mingo/tip/init/main.c:44:
/home/mingo/tip/include/linux/efi.h:842:21: error: asm/efi.h: No such file or directory
/home/mingo/tip/init/main.c: In function 'start_kernel':
/home/mingo/tip/init/main.c:638: error: implicit declaration of function 'efi_enabled'
/home/mingo/tip/init/main.c:639: error: implicit declaration of function 'efi_late_init'
/home/mingo/tip/init/main.c:640: error: implicit declaration of function 'efi_free_boot_services'
Thanks,
Ingo
next prev parent reply other threads:[~2013-10-28 13:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 12:35 [GIT PULL] EFI changes Matt Fleming
2013-10-28 12:35 ` Matt Fleming
[not found] ` <20131028123528.GM1982-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-28 13:44 ` Ingo Molnar [this message]
2013-10-28 13:44 ` Ingo Molnar
[not found] ` <20131028134413.GA10163-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-28 15:52 ` Matt Fleming
2013-10-28 15:52 ` Matt Fleming
[not found] ` <20131028155215.GN1982-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-28 15:55 ` Ingo Molnar
2013-10-28 15:55 ` Ingo Molnar
[not found] ` <20131028155525.GA13987-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-28 20:30 ` Matt Fleming
2013-10-28 20:30 ` Matt Fleming
[not found] ` <20131028203052.GO1982-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-29 8:11 ` Ingo Molnar
2013-10-29 8:11 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2013-10-29 8:18 Matt Fleming
2013-10-29 8:18 ` Matt Fleming
2013-10-27 21:48 Matt Fleming
2013-10-27 21:48 ` Matt Fleming
[not found] ` <20131027214815.GH1982-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-28 11:17 ` Ingo Molnar
2013-10-28 11:17 ` Ingo Molnar
[not found] ` <20131028111741.GA7830-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-28 11:49 ` Matt Fleming
2013-10-28 11:49 ` Matt Fleming
[not found] ` <20131028114924.GL1982-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-28 11:50 ` Ingo Molnar
2013-10-28 11:50 ` Ingo Molnar
2013-10-04 19:55 Matt Fleming
2013-10-04 19:55 ` Matt Fleming
[not found] ` <20131004195550.GA21783-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-06 9:27 ` Ingo Molnar
2013-10-06 9:27 ` Ingo Molnar
2013-09-30 10:49 Matt Fleming
[not found] ` <20130930104918.GO21381-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-09-30 14:26 ` H. Peter Anvin
2013-09-30 14:26 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028134413.GA10163@gmail.com \
--to=mingo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.