All of lore.kernel.org
 help / color / mirror / Atom feed
From: gmbnomis@gmail.com (Simon Baatz)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM/kirkwood: v3.12-rc6: kernel BUG at mm/util.c:390!
Date: Mon, 28 Oct 2013 15:13:10 +0100	[thread overview]
Message-ID: <20131028141310.GA4970@schnuecks.de> (raw)
In-Reply-To: <20131027195115.208f40f3@tom-ThinkPad-T410>

On Sun, Oct 27, 2013 at 07:51:15PM +0800, Ming Lei wrote:
> diff --git a/lib/scatterlist.c b/lib/scatterlist.c
> index a685c8a..eea8806 100644
> --- a/lib/scatterlist.c
> +++ b/lib/scatterlist.c
> @@ -577,7 +577,7 @@ void sg_miter_stop(struct sg_mapping_iter *miter)
>  		miter->__offset += miter->consumed;
>  		miter->__remaining -= miter->consumed;
>  
> -		if (miter->__flags & SG_MITER_TO_SG)
> +		if ((miter->__flags & SG_MITER_TO_SG) && !PageSlab(page))

This is what I was going to propose, but I would have used
!PageSlab(miter->page) ;-)

>  			flush_kernel_dcache_page(miter->page);

With this, a kernel with DEBUG_VM now boots on Kirkwood. 


- Simon

WARNING: multiple messages have this Message-ID (diff)
From: Simon Baatz <gmbnomis@gmail.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Will Deacon <will.deacon@arm.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	catalin.marinas@arm.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Tejun Heo <tj@kernel.org>,
	"James E.J. Bottomley" <JBottomley@parallels.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: ARM/kirkwood: v3.12-rc6: kernel BUG at mm/util.c:390!
Date: Mon, 28 Oct 2013 15:13:10 +0100	[thread overview]
Message-ID: <20131028141310.GA4970@schnuecks.de> (raw)
In-Reply-To: <20131027195115.208f40f3@tom-ThinkPad-T410>

On Sun, Oct 27, 2013 at 07:51:15PM +0800, Ming Lei wrote:
> diff --git a/lib/scatterlist.c b/lib/scatterlist.c
> index a685c8a..eea8806 100644
> --- a/lib/scatterlist.c
> +++ b/lib/scatterlist.c
> @@ -577,7 +577,7 @@ void sg_miter_stop(struct sg_mapping_iter *miter)
>  		miter->__offset += miter->consumed;
>  		miter->__remaining -= miter->consumed;
>  
> -		if (miter->__flags & SG_MITER_TO_SG)
> +		if ((miter->__flags & SG_MITER_TO_SG) && !PageSlab(page))

This is what I was going to propose, but I would have used
!PageSlab(miter->page) ;-)

>  			flush_kernel_dcache_page(miter->page);

With this, a kernel with DEBUG_VM now boots on Kirkwood. 


- Simon

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Simon Baatz <gmbnomis@gmail.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Will Deacon <will.deacon@arm.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	catalin.marinas@arm.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Tejun Heo <tj@kernel.org>,
	"James E.J. Bottomley" <JBottomley@parallels.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: ARM/kirkwood: v3.12-rc6: kernel BUG at mm/util.c:390!
Date: Mon, 28 Oct 2013 15:13:10 +0100	[thread overview]
Message-ID: <20131028141310.GA4970@schnuecks.de> (raw)
In-Reply-To: <20131027195115.208f40f3@tom-ThinkPad-T410>

On Sun, Oct 27, 2013 at 07:51:15PM +0800, Ming Lei wrote:
> diff --git a/lib/scatterlist.c b/lib/scatterlist.c
> index a685c8a..eea8806 100644
> --- a/lib/scatterlist.c
> +++ b/lib/scatterlist.c
> @@ -577,7 +577,7 @@ void sg_miter_stop(struct sg_mapping_iter *miter)
>  		miter->__offset += miter->consumed;
>  		miter->__remaining -= miter->consumed;
>  
> -		if (miter->__flags & SG_MITER_TO_SG)
> +		if ((miter->__flags & SG_MITER_TO_SG) && !PageSlab(page))

This is what I was going to propose, but I would have used
!PageSlab(miter->page) ;-)

>  			flush_kernel_dcache_page(miter->page);

With this, a kernel with DEBUG_VM now boots on Kirkwood. 


- Simon

  parent reply	other threads:[~2013-10-28 14:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 20:07 ARM/kirkwood: v3.12-rc6: kernel BUG at mm/util.c:390! Aaro Koskinen
2013-10-24 20:07 ` Aaro Koskinen
2013-10-26 14:36 ` Will Deacon
2013-10-26 14:36   ` Will Deacon
2013-10-26 14:36   ` Will Deacon
2013-10-26 17:23   ` Aaro Koskinen
2013-10-26 17:23     ` Aaro Koskinen
2013-10-27 11:51   ` Ming Lei
2013-10-27 11:51     ` Ming Lei
2013-10-27 11:51     ` Ming Lei
2013-10-27 12:50     ` Aaro Koskinen
2013-10-27 12:50       ` Aaro Koskinen
2013-10-27 12:50       ` Aaro Koskinen
2013-10-27 13:16       ` Ming Lei
2013-10-27 13:16         ` Ming Lei
2013-10-27 13:16         ` Ming Lei
2013-10-27 13:42         ` Tejun Heo
2013-10-27 13:42           ` Tejun Heo
2013-10-27 13:42           ` Tejun Heo
2013-10-27 13:47           ` Russell King - ARM Linux
2013-10-27 13:47             ` Russell King - ARM Linux
2013-10-27 13:47             ` Russell King - ARM Linux
2013-10-27 13:53         ` Russell King - ARM Linux
2013-10-27 13:53           ` Russell King - ARM Linux
2013-10-27 13:53           ` Russell King - ARM Linux
2013-10-27 14:18           ` Simon Baatz
2013-10-27 14:18             ` Simon Baatz
2013-10-27 14:18             ` Simon Baatz
2013-10-28 12:48             ` Catalin Marinas
2013-10-28 12:48               ` Catalin Marinas
2013-10-28 12:48               ` Catalin Marinas
2013-10-27 14:19           ` Ming Lei
2013-10-27 14:19             ` Ming Lei
2013-10-27 14:19             ` Ming Lei
2013-10-28 14:13     ` Simon Baatz [this message]
2013-10-28 14:13       ` Simon Baatz
2013-10-28 14:13       ` Simon Baatz
2013-10-28 15:45       ` Ming Lei
2013-10-28 15:45         ` Ming Lei
2013-10-28 15:45         ` Ming Lei
  -- strict thread matches above, loose matches on Subject: below --
2013-10-24 20:05 Aaro Koskinen
2013-10-24 20:05 ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131028141310.GA4970@schnuecks.de \
    --to=gmbnomis@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.