From: Wang YanQing <udknight@gmail.com>
To: gregkh@linuxfoundation.org
Cc: rucsoftsec@gmail.com, jslaby@suse.cz, airlied@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH]tty:vt: Add NULL check to return value of kzalloc()
Date: Tue, 29 Oct 2013 00:26:05 +0800 [thread overview]
Message-ID: <20131028162605.GA3738@udknight> (raw)
In extreme situation kzalloc in con_init may
return NULL, so we should check it to prevent
OOPS!
Signed-off-by: Wang YanQing <udknight@gmail.com>
Reported-by: rucsoftsec@gmail.com
---
I don't think a system without memory to initialize
vt could do some useful things, but this patch could
make debug easier and improve kernel code's robustness
in theory.
drivers/tty/vt/vc_screen.c | 2 +-
drivers/tty/vt/vt.c | 12 ++++++++++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/vt/vc_screen.c b/drivers/tty/vt/vc_screen.c
index 14a2b5f..2bc3987bc 100644
--- a/drivers/tty/vt/vc_screen.c
+++ b/drivers/tty/vt/vc_screen.c
@@ -648,6 +648,6 @@ int __init vcs_init(void)
device_create(vc_class, NULL, MKDEV(VCS_MAJOR, 0), NULL, "vcs");
device_create(vc_class, NULL, MKDEV(VCS_MAJOR, 128), NULL, "vcsa");
for (i = 0; i < MIN_NR_CONSOLES; i++)
- vcs_make_sysfs(i);
+ if (vc_cons[i].d) vcs_make_sysfs(i);
return 0;
}
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 9a8e8c5..ef8b1aa 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -2887,6 +2887,8 @@ static int __init con_init(void)
for (currcons = 0; currcons < MIN_NR_CONSOLES; currcons++) {
vc_cons[currcons].d = vc = kzalloc(sizeof(struct vc_data), GFP_NOWAIT);
+ if (vc == NULL)
+ break;
INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
tty_port_init(&vc->port);
visual_init(vc, currcons, 1);
@@ -2894,8 +2896,18 @@ static int __init con_init(void)
vc_init(vc, vc->vc_rows, vc->vc_cols,
currcons || !vc->vc_sw->con_save_screen);
}
+ if (currcons < MIN_NR_CONSOLES)
+ printk(KERN_WARNING "Console: vt %d-%d initialization failed!\n",
+ currcons, MIN_NR_CONSOLES - 1);
+
currcons = fg_console = 0;
master_display_fg = vc = vc_cons[currcons].d;
+
+ if (vc == NULL) {
+ printk(KERN_WARNING "Console: no avaiable vt!\n");
+ console_unlock();
+ return 0;
+ }
set_origin(vc);
save_screen(vc);
gotoxy(vc, vc->vc_x, vc->vc_y);
--
1.7.12.4.dirty
next reply other threads:[~2013-10-28 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 16:26 Wang YanQing [this message]
2013-10-28 16:35 ` [PATCH]tty:vt: Add NULL check to return value of kzalloc() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028162605.GA3738@udknight \
--to=udknight@gmail.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rucsoftsec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.