From: Greg KH <gregkh@linuxfoundation.org>
To: Wang YanQing <udknight@gmail.com>,
rucsoftsec@gmail.com, jslaby@suse.cz, airlied@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]tty:vt: Add NULL check to return value of kzalloc()
Date: Mon, 28 Oct 2013 09:35:10 -0700 [thread overview]
Message-ID: <20131028163510.GB4797@kroah.com> (raw)
In-Reply-To: <20131028162605.GA3738@udknight>
On Tue, Oct 29, 2013 at 12:26:05AM +0800, Wang YanQing wrote:
> In extreme situation kzalloc in con_init may
> return NULL, so we should check it to prevent
> OOPS!
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> Reported-by: rucsoftsec@gmail.com
I need a name for Reported-by: as well, not just an email.
> ---
> I don't think a system without memory to initialize
> vt could do some useful things, but this patch could
> make debug easier and improve kernel code's robustness
> in theory.
Please always run your patches through the scripts/checkpatch.pl tool
and fix the problems found there so that maintainers don't have to point
out the same thing...
greg k-h
prev parent reply other threads:[~2013-10-28 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 16:26 [PATCH]tty:vt: Add NULL check to return value of kzalloc() Wang YanQing
2013-10-28 16:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028163510.GB4797@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rucsoftsec@gmail.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.