From: Ben Widawsky <ben@bwidawsk.net>
To: Paulo Zanoni <przanoni@gmail.com>,
Art Runyan <arthur.j.runyan@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH 4/4] drm/i915: WaFbcDisableDpfcClockGating only with fbc
Date: Mon, 28 Oct 2013 10:08:29 -0700 [thread overview]
Message-ID: <20131028170829.GD3174@bwidawsk.net> (raw)
In-Reply-To: <CA+gsUGR5WHwCmT2UY8jR-X8m0gf-OEREA7+fOP6o2Wpw3E6DRw@mail.gmail.com>
On Fri, Oct 25, 2013 at 03:24:12PM -0200, Paulo Zanoni wrote:
> 2013/10/24 Ben Widawsky <benjamin.widawsky@intel.com>:
> > We were turning this on for SNB regardless of whether or not we use FBC.
> > We can save the slightest amount of power if we don't disable it when
> > not using FBC.
> >
> > The workaround should be bit 9 for SNB.
>
> First, see comment in patch 3. So you're removing the WA on ILK and
> applying it for SNB-only. Since the spec doesn't say "SNB only", I
> guess we need this WA on both gens.
This is a question for Art, since he confirmed this privately IIRC.
Art does ILK need bit 8 and 9 set in 0x42020?
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-28 17:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 16:59 [PATCH 1/4] drm/i915: Remove WaFbcDisableDpfcClockGating on IVB Ben Widawsky
2013-10-24 16:59 ` [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW Ben Widawsky
2013-10-25 17:27 ` Paulo Zanoni
2013-10-27 13:44 ` Daniel Vetter
2013-10-28 12:22 ` Paulo Zanoni
2013-10-28 13:05 ` Ville Syrjälä
2013-10-28 16:48 ` Ben Widawsky
2013-10-28 17:43 ` Ville Syrjälä
2013-10-28 20:24 ` Ben Widawsky
2013-10-28 16:12 ` Daniel Vetter
2013-10-24 16:59 ` [PATCH 3/4] drm/i915: WaFbcDisableDpfcrClockGating only with fbc Ben Widawsky
2013-10-25 17:14 ` Paulo Zanoni
2013-10-28 16:56 ` Ben Widawsky
2013-10-24 16:59 ` [PATCH 4/4] drm/i915: WaFbcDisableDpfcClockGating " Ben Widawsky
2013-10-25 17:24 ` Paulo Zanoni
2013-10-28 17:08 ` Ben Widawsky [this message]
2013-10-25 17:27 ` [PATCH 1/4] drm/i915: Remove WaFbcDisableDpfcClockGating on IVB Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028170829.GD3174@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=arthur.j.runyan@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.