* [patch]blk-mq: mq plug list breakage
@ 2013-10-29 17:30 Shaohua Li
0 siblings, 0 replies; only message in thread
From: Shaohua Li @ 2013-10-29 17:30 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel
We switched to plug mq_list for mq, but some code are still using old list.
Signed-off-by: Shaohua Li <shli@fusionio.com>
---
block/blk-core.c | 8 +++++++-
block/blk-mq.c | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
Index: linux/block/blk-core.c
===================================================================
--- linux.orig/block/blk-core.c 2013-10-29 11:26:16.556586892 -0600
+++ linux/block/blk-core.c 2013-10-29 11:26:21.014356939 -0600
@@ -1411,6 +1411,7 @@
struct blk_plug *plug;
struct request *rq;
bool ret = false;
+ struct list_head *plug_list;
if (blk_queue_nomerges(q))
goto out;
@@ -1420,7 +1421,12 @@
goto out;
*request_count = 0;
- list_for_each_entry_reverse(rq, &plug->list, queuelist) {
+ if (q->mq_ops)
+ plug_list = &plug->mq_list;
+ else
+ plug_list = &plug->list;
+
+ list_for_each_entry_reverse(rq, plug_list, queuelist) {
int el_ret;
if (rq->q == q)
Index: linux/block/blk-mq.c
===================================================================
--- linux.orig/block/blk-mq.c 2013-10-29 11:26:16.556586892 -0600
+++ linux/block/blk-mq.c 2013-10-29 11:26:21.014356939 -0600
@@ -950,7 +950,7 @@
if (plug) {
blk_mq_bio_to_request(rq, bio);
- if (list_empty(&plug->list))
+ if (list_empty(&plug->mq_list))
trace_block_plug(q);
else if (request_count >= BLK_MAX_REQUEST_COUNT) {
blk_flush_plug_list(plug, false);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-10-29 17:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29 17:30 [patch]blk-mq: mq plug list breakage Shaohua Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.