From: Dan Carpenter <dan.carpenter@oracle.com>
To: Adaptec OEM Raid Solutions <aacraid@adaptec.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, security@kernel.org
Subject: [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference
Date: Tue, 29 Oct 2013 22:10:07 +0300 [thread overview]
Message-ID: <20131029191007.GD21820@longonot.mountain> (raw)
In-Reply-To: <20131025144452.GA28451@ngolde.de>
If "fibsize" is zero then it leads to a ZERO_SIZE_PTR dereference when
we dereference user_srbcmd.
Due to a missing capable() check in the compat ioctls then this error
can be triggered without CAP_SYS_RAWIO. I have fixed that in a separate
patch.
Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index d85ac1a..efd0ba3 100644
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -511,7 +511,8 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
goto cleanup;
}
- if (fibsize > (dev->max_fib_size - sizeof(struct aac_fibhdr))) {
+ if (fibsize == 0 ||
+ fibsize > (dev->max_fib_size - sizeof(struct aac_fibhdr))) {
rcode = -EINVAL;
goto cleanup;
}
next prev parent reply other threads:[~2013-10-29 19:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131025144452.GA28451@ngolde.de>
2013-10-29 19:06 ` [uml-devel] [patch] uml: check length in exitcode_proc_write() Dan Carpenter
2013-11-01 9:22 ` Richard Weinberger
2013-10-29 19:06 ` [patch] libertas: potential oops in debugfs Dan Carpenter
2013-10-29 20:09 ` Dan Carpenter
2013-10-29 19:10 ` Dan Carpenter [this message]
2013-10-29 19:36 ` [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference James Bottomley
2013-10-29 19:59 ` Linus Torvalds
2013-10-29 20:06 ` Dan Carpenter
2013-10-29 20:17 ` Linus Torvalds
2013-10-30 7:47 ` Dan Carpenter
2013-10-29 19:11 ` [patch] [SCSI] aacraid: missing capable() check in compat ioctl Dan Carpenter
2013-10-30 17:12 ` [patch v2] libertas: potential oops in debugfs Dan Carpenter
2013-10-30 17:12 ` Dan Carpenter
2013-10-30 19:51 ` Dan Williams
2013-10-30 19:51 ` Dan Williams
2013-10-30 17:13 ` [patch] [SCSI] megaraid: missing bounds check in mimd_to_kioc() Dan Carpenter
2013-11-21 0:40 ` Kees Cook
2014-01-08 12:27 ` Saxena, Sumit
2014-01-09 18:34 ` Kees Cook
2014-01-09 19:53 ` Saxena, Sumit
2014-01-09 20:03 ` Kees Cook
2013-10-31 18:00 ` [patch] xfs: underflow bug in xfs_attrlist_by_handle() Dan Carpenter
2013-10-31 21:34 ` Dave Chinner
2013-12-04 21:53 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029191007.GD21820@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=JBottomley@parallels.com \
--cc=aacraid@adaptec.com \
--cc=linux-scsi@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.