All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ben Myers <bpm@sgi.com>
Cc: Fabian Yamaguchi <fabs@goesec.de>,
	security@kernel.org, Alex Elder <elder@kernel.org>,
	Nico Golde <nico@ngolde.de>,
	xfs@oss.sgi.com
Subject: [patch] xfs: underflow bug in xfs_attrlist_by_handle()
Date: Thu, 31 Oct 2013 21:00:10 +0300	[thread overview]
Message-ID: <20131031180010.GA24839@longonot.mountain> (raw)
In-Reply-To: <20131025144452.GA28451@ngolde.de>

If we allocate less than sizeof(struct attrlist) then we end up
corrupting memory or doing a ZERO_PTR_SIZE dereference.

This can only be triggered with CAP_SYS_ADMIN.

Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 4d61340..33ad9a7 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -442,7 +442,8 @@ xfs_attrlist_by_handle(
 		return -XFS_ERROR(EPERM);
 	if (copy_from_user(&al_hreq, arg, sizeof(xfs_fsop_attrlist_handlereq_t)))
 		return -XFS_ERROR(EFAULT);
-	if (al_hreq.buflen > XATTR_LIST_MAX)
+	if (al_hreq.buflen < sizeof(struct attrlist) ||
+	    al_hreq.buflen > XATTR_LIST_MAX)
 		return -XFS_ERROR(EINVAL);
 
 	/*
diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c
index e8fb123..a7992f8 100644
--- a/fs/xfs/xfs_ioctl32.c
+++ b/fs/xfs/xfs_ioctl32.c
@@ -356,7 +356,8 @@ xfs_compat_attrlist_by_handle(
 	if (copy_from_user(&al_hreq, arg,
 			   sizeof(compat_xfs_fsop_attrlist_handlereq_t)))
 		return -XFS_ERROR(EFAULT);
-	if (al_hreq.buflen > XATTR_LIST_MAX)
+	if (al_hreq.buflen < sizeof(struct attrlist) ||
+	    al_hreq.buflen > XATTR_LIST_MAX)
 		return -XFS_ERROR(EINVAL);
 
 	/*

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-10-31 18:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131025144452.GA28451@ngolde.de>
2013-10-29 19:06 ` [uml-devel] [patch] uml: check length in exitcode_proc_write() Dan Carpenter
2013-11-01  9:22   ` Richard Weinberger
2013-10-29 19:06 ` [patch] libertas: potential oops in debugfs Dan Carpenter
2013-10-29 20:09   ` Dan Carpenter
2013-10-29 19:10 ` [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference Dan Carpenter
2013-10-29 19:36   ` James Bottomley
2013-10-29 19:59   ` Linus Torvalds
2013-10-29 20:06     ` Dan Carpenter
2013-10-29 20:17       ` Linus Torvalds
2013-10-30  7:47   ` Dan Carpenter
2013-10-29 19:11 ` [patch] [SCSI] aacraid: missing capable() check in compat ioctl Dan Carpenter
2013-10-30 17:12 ` [patch v2] libertas: potential oops in debugfs Dan Carpenter
2013-10-30 17:12   ` Dan Carpenter
2013-10-30 19:51   ` Dan Williams
2013-10-30 19:51     ` Dan Williams
2013-10-30 17:13 ` [patch] [SCSI] megaraid: missing bounds check in mimd_to_kioc() Dan Carpenter
2013-11-21  0:40   ` Kees Cook
2014-01-08 12:27   ` Saxena, Sumit
2014-01-09 18:34     ` Kees Cook
2014-01-09 19:53       ` Saxena, Sumit
2014-01-09 20:03         ` Kees Cook
2013-10-31 18:00 ` Dan Carpenter [this message]
2013-10-31 21:34   ` [patch] xfs: underflow bug in xfs_attrlist_by_handle() Dave Chinner
2013-12-04 21:53   ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131031180010.GA24839@longonot.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=bpm@sgi.com \
    --cc=elder@kernel.org \
    --cc=fabs@goesec.de \
    --cc=nico@ngolde.de \
    --cc=security@kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.