From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: "Geyslan G. Bem" <geyslan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org,
jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-br-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH] efivarfs: 'efivarfs_file_write' function reorganization
Date: Wed, 30 Oct 2013 12:38:50 +0000 [thread overview]
Message-ID: <20131030123850.GA8193@console-pimps.org> (raw)
In-Reply-To: <1381775837-26023-1-git-send-email-geyslan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote:
> This reorganization:
>
> Adds 'attrsize' variable to make the code cleaner and more
> understandable, replacing all 'sizeof(attributes)'.
>
> Removes 'bytes' prior assignment due this new approach.
>
> Uses 'memdup_user' instead 'kmalloc' + 'copy_from_user'.
>
> Signed-off-by: Geyslan G. Bem <geyslan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> fs/efivarfs/file.c | 23 +++++++++--------------
> 1 file changed, 9 insertions(+), 14 deletions(-)
Hmm.. I'm not convinced this is much of an improvement. I think removing
'sizeof(attributes)' actually makes the code harder to read.
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: matthew.garrett@nebula.com, jk@ozlabs.org,
matt.fleming@intel.com, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-br@googlegroups.com
Subject: Re: [PATCH] efivarfs: 'efivarfs_file_write' function reorganization
Date: Wed, 30 Oct 2013 12:38:50 +0000 [thread overview]
Message-ID: <20131030123850.GA8193@console-pimps.org> (raw)
In-Reply-To: <1381775837-26023-1-git-send-email-geyslan@gmail.com>
On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote:
> This reorganization:
>
> Adds 'attrsize' variable to make the code cleaner and more
> understandable, replacing all 'sizeof(attributes)'.
>
> Removes 'bytes' prior assignment due this new approach.
>
> Uses 'memdup_user' instead 'kmalloc' + 'copy_from_user'.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> fs/efivarfs/file.c | 23 +++++++++--------------
> 1 file changed, 9 insertions(+), 14 deletions(-)
Hmm.. I'm not convinced this is much of an improvement. I think removing
'sizeof(attributes)' actually makes the code harder to read.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-30 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 18:37 [PATCH] efivarfs: 'efivarfs_file_write' function reorganization Geyslan G. Bem
[not found] ` <1381775837-26023-1-git-send-email-geyslan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-30 12:38 ` Matt Fleming [this message]
2013-10-30 12:38 ` Matt Fleming
[not found] ` <20131030123850.GA8193-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-30 12:44 ` Geyslan Gregório Bem
2013-10-30 12:44 ` Geyslan Gregório Bem
[not found] ` <CAGG-pUQZ2R0JMZuGi07cL5q4EABYouZJfMpkO6YPy+ry2WkbNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-30 14:39 ` Matt Fleming
2013-10-30 14:39 ` Matt Fleming
[not found] ` <20131030143923.GA9996-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-10-30 19:13 ` Geyslan Gregório Bem
2013-10-30 19:13 ` Geyslan Gregório Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030123850.GA8193@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=geyslan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jk-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=kernel-br-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.