From: Mel Gorman <mgorman@suse.de>
To: kosaki.motohiro@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH] mm: get rid of unnecessary overhead of trace_mm_page_alloc_extfrag()
Date: Wed, 30 Oct 2013 15:20:57 +0000 [thread overview]
Message-ID: <20131030152057.GP2400@suse.de> (raw)
In-Reply-To: <1382719367-11537-1-git-send-email-kosaki.motohiro@gmail.com>
On Fri, Oct 25, 2013 at 12:42:47PM -0400, kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> In general, every tracepoint should be zero overhead if it is disabled.
> However, trace_mm_page_alloc_extfrag() is one of exception. It evaluate
> "new_type == start_migratetype" even if tracepoint is disabled.
>
> However, the code can be moved into tracepoint's TP_fast_assign() and
> TP_fast_assign exist exactly such purpose. This patch does it.
>
> Cc: Mel Gorman <mgorman@suse.de>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: kosaki.motohiro@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH] mm: get rid of unnecessary overhead of trace_mm_page_alloc_extfrag()
Date: Wed, 30 Oct 2013 15:20:57 +0000 [thread overview]
Message-ID: <20131030152057.GP2400@suse.de> (raw)
In-Reply-To: <1382719367-11537-1-git-send-email-kosaki.motohiro@gmail.com>
On Fri, Oct 25, 2013 at 12:42:47PM -0400, kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> In general, every tracepoint should be zero overhead if it is disabled.
> However, trace_mm_page_alloc_extfrag() is one of exception. It evaluate
> "new_type == start_migratetype" even if tracepoint is disabled.
>
> However, the code can be moved into tracepoint's TP_fast_assign() and
> TP_fast_assign exist exactly such purpose. This patch does it.
>
> Cc: Mel Gorman <mgorman@suse.de>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2013-10-30 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 16:42 [PATCH] mm: get rid of unnecessary overhead of trace_mm_page_alloc_extfrag() kosaki.motohiro
2013-10-25 16:42 ` kosaki.motohiro
2013-10-30 15:20 ` Mel Gorman [this message]
2013-10-30 15:20 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030152057.GP2400@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.