Re: [patch] i2c-scmi: remove some bogus NULL checks

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

On Sat, Oct 19, 2013 at 11:46:22AM +0300, Dan Carpenter wrote:
> "obj" can't be NULL here.
> 
> We already know that "pkg->package.elements" gives us a valid pointer
> so the next pointer after that is also non-NULL.

Why is that? Can't see it...

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
> index c447e8d..5992355 100644
> --- a/drivers/i2c/busses/i2c-scmi.c
> +++ b/drivers/i2c/busses/i2c-scmi.c
> @@ -223,7 +223,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,
>  		goto out;
>  
>  	obj = pkg->package.elements + 1;
> -	if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {
> +	if (obj->type != ACPI_TYPE_INTEGER) {
>  		ACPI_ERROR((AE_INFO, "Invalid argument type"));
>  		result = -EIO;
>  		goto out;
> @@ -235,7 +235,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,
>  	case I2C_SMBUS_BYTE:
>  	case I2C_SMBUS_BYTE_DATA:
>  	case I2C_SMBUS_WORD_DATA:
> -		if (obj == NULL || obj->type != ACPI_TYPE_INTEGER) {
> +		if (obj->type != ACPI_TYPE_INTEGER) {
>  			ACPI_ERROR((AE_INFO, "Invalid argument type"));
>  			result = -EIO;
>  			goto out;
> @@ -246,7 +246,7 @@ acpi_smbus_cmi_access(struct i2c_adapter *adap, u16 addr, unsigned short flags,
>  			data->byte = obj->integer.value;
>  		break;
>  	case I2C_SMBUS_BLOCK_DATA:
> -		if (obj == NULL || obj->type != ACPI_TYPE_BUFFER) {
> +		if (obj->type != ACPI_TYPE_BUFFER) {
>  			ACPI_ERROR((AE_INFO, "Invalid argument type"));
>  			result = -EIO;
>  			goto out;

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]