All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Cc: linux@arm.linux.org.uk, jiada_wang@mentor.com,
	kyungmin.park@samsung.com, laurent.pinchart@ideasonboard.com,
	linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	linux-mips@linux-mips.org, linux-sh@vger.kernel.org,
	Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [PATCH v7 0/5] clk: clock deregistration support
Date: Wed, 30 Oct 2013 12:42:52 -0700	[thread overview]
Message-ID: <20131030194252.11662.92657@quantum> (raw)
In-Reply-To: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com>

Quoting Sylwester Nawrocki (2013-10-29 12:51:03)
> This patch series implements clock deregistration in the common clock
> framework. Detailed changes are listed at each patch. I have included
> an additional patch in this series for the omap3isp driver, required 
> to avoid regressions.

Taken into clk-next. Thanks for the fine rework!

Regards,
Mike

> 
> Changes since v5:
>  - fixed NULL clock handling in __clk_get(), __clk_put (patch 5/5).
> 
> Changes since v4:
>  - removed stray struct module forward declaration in patch 3/5.
> 
> Changes since v3:
>  - replaced WARN_ON() with WARN_ON_ONCE() in clk_nodrv_disable_unprepare()
>    callback.
> 
> Changes since v2:
>  - reordered the patches so the race condition is fixed before it can
>    actually cause any issues,
>  - fixed handling of NULL clock pointers in __clk_get(), __clk_put(),
>  - added patch adding actual asignment of clk->owner; more details are
>    discussed in that specific patch.
> 
> Changes since v1:
>  - moved of_clk_{lock, unlock}, __of_clk_get_from_provider() function
>    declaractions to a local header,
>  - renamed clk_dummy_* to clk_nodrv_*.
> 
> Sylwester Nawrocki (5):
>   omap3isp: Modify clocks registration to avoid circular references
>   clk: Provide not locked variant of of_clk_get_from_provider()
>   clkdev: Fix race condition in clock lookup from device tree
>   clk: Add common __clk_get(), __clk_put() implementations
>   clk: Implement clk_unregister()
> 
>  arch/arm/include/asm/clkdev.h         |    2 +
>  arch/blackfin/include/asm/clkdev.h    |    2 +
>  arch/mips/include/asm/clkdev.h        |    2 +
>  arch/sh/include/asm/clkdev.h          |    2 +
>  drivers/clk/clk.c                     |  185 +++++++++++++++++++++++++++++++--
>  drivers/clk/clk.h                     |   16 +++
>  drivers/clk/clkdev.c                  |   12 ++-
>  drivers/media/platform/omap3isp/isp.c |   22 ++--
>  drivers/media/platform/omap3isp/isp.h |    1 +
>  include/linux/clk-private.h           |    5 +
>  include/linux/clkdev.h                |    5 +
>  11 files changed, 235 insertions(+), 19 deletions(-)
>  create mode 100644 drivers/clk/clk.h
> 
> -- 
> 1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Cc: linux@arm.linux.org.uk, jiada_wang@mentor.com,
	kyungmin.park@samsung.com, laurent.pinchart@ideasonboard.com,
	linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	linux-mips@linux-mips.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v7 0/5] clk: clock deregistration support
Date: Wed, 30 Oct 2013 12:42:52 -0700	[thread overview]
Message-ID: <20131030194252.11662.92657@quantum> (raw)
Message-ID: <20131030194252.9rxZGRxqhIuhNIgTt-nH4mT3-Ex-GNI_YH53-DBsYuY@z> (raw)
In-Reply-To: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com>

Quoting Sylwester Nawrocki (2013-10-29 12:51:03)
> This patch series implements clock deregistration in the common clock
> framework. Detailed changes are listed at each patch. I have included
> an additional patch in this series for the omap3isp driver, required 
> to avoid regressions.

Taken into clk-next. Thanks for the fine rework!

Regards,
Mike

> 
> Changes since v5:
>  - fixed NULL clock handling in __clk_get(), __clk_put (patch 5/5).
> 
> Changes since v4:
>  - removed stray struct module forward declaration in patch 3/5.
> 
> Changes since v3:
>  - replaced WARN_ON() with WARN_ON_ONCE() in clk_nodrv_disable_unprepare()
>    callback.
> 
> Changes since v2:
>  - reordered the patches so the race condition is fixed before it can
>    actually cause any issues,
>  - fixed handling of NULL clock pointers in __clk_get(), __clk_put(),
>  - added patch adding actual asignment of clk->owner; more details are
>    discussed in that specific patch.
> 
> Changes since v1:
>  - moved of_clk_{lock, unlock}, __of_clk_get_from_provider() function
>    declaractions to a local header,
>  - renamed clk_dummy_* to clk_nodrv_*.
> 
> Sylwester Nawrocki (5):
>   omap3isp: Modify clocks registration to avoid circular references
>   clk: Provide not locked variant of of_clk_get_from_provider()
>   clkdev: Fix race condition in clock lookup from device tree
>   clk: Add common __clk_get(), __clk_put() implementations
>   clk: Implement clk_unregister()
> 
>  arch/arm/include/asm/clkdev.h         |    2 +
>  arch/blackfin/include/asm/clkdev.h    |    2 +
>  arch/mips/include/asm/clkdev.h        |    2 +
>  arch/sh/include/asm/clkdev.h          |    2 +
>  drivers/clk/clk.c                     |  185 +++++++++++++++++++++++++++++++--
>  drivers/clk/clk.h                     |   16 +++
>  drivers/clk/clkdev.c                  |   12 ++-
>  drivers/media/platform/omap3isp/isp.c |   22 ++--
>  drivers/media/platform/omap3isp/isp.h |    1 +
>  include/linux/clk-private.h           |    5 +
>  include/linux/clkdev.h                |    5 +
>  11 files changed, 235 insertions(+), 19 deletions(-)
>  create mode 100644 drivers/clk/clk.h
> 
> -- 
> 1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 0/5] clk: clock deregistration support
Date: Wed, 30 Oct 2013 19:42:52 +0000	[thread overview]
Message-ID: <20131030194252.11662.92657@quantum> (raw)
In-Reply-To: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com>

Quoting Sylwester Nawrocki (2013-10-29 12:51:03)
> This patch series implements clock deregistration in the common clock
> framework. Detailed changes are listed at each patch. I have included
> an additional patch in this series for the omap3isp driver, required 
> to avoid regressions.

Taken into clk-next. Thanks for the fine rework!

Regards,
Mike

> 
> Changes since v5:
>  - fixed NULL clock handling in __clk_get(), __clk_put (patch 5/5).
> 
> Changes since v4:
>  - removed stray struct module forward declaration in patch 3/5.
> 
> Changes since v3:
>  - replaced WARN_ON() with WARN_ON_ONCE() in clk_nodrv_disable_unprepare()
>    callback.
> 
> Changes since v2:
>  - reordered the patches so the race condition is fixed before it can
>    actually cause any issues,
>  - fixed handling of NULL clock pointers in __clk_get(), __clk_put(),
>  - added patch adding actual asignment of clk->owner; more details are
>    discussed in that specific patch.
> 
> Changes since v1:
>  - moved of_clk_{lock, unlock}, __of_clk_get_from_provider() function
>    declaractions to a local header,
>  - renamed clk_dummy_* to clk_nodrv_*.
> 
> Sylwester Nawrocki (5):
>   omap3isp: Modify clocks registration to avoid circular references
>   clk: Provide not locked variant of of_clk_get_from_provider()
>   clkdev: Fix race condition in clock lookup from device tree
>   clk: Add common __clk_get(), __clk_put() implementations
>   clk: Implement clk_unregister()
> 
>  arch/arm/include/asm/clkdev.h         |    2 +
>  arch/blackfin/include/asm/clkdev.h    |    2 +
>  arch/mips/include/asm/clkdev.h        |    2 +
>  arch/sh/include/asm/clkdev.h          |    2 +
>  drivers/clk/clk.c                     |  185 +++++++++++++++++++++++++++++++--
>  drivers/clk/clk.h                     |   16 +++
>  drivers/clk/clkdev.c                  |   12 ++-
>  drivers/media/platform/omap3isp/isp.c |   22 ++--
>  drivers/media/platform/omap3isp/isp.h |    1 +
>  include/linux/clk-private.h           |    5 +
>  include/linux/clkdev.h                |    5 +
>  11 files changed, 235 insertions(+), 19 deletions(-)
>  create mode 100644 drivers/clk/clk.h
> 
> -- 
> 1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/5] clk: clock deregistration support
Date: Wed, 30 Oct 2013 12:42:52 -0700	[thread overview]
Message-ID: <20131030194252.11662.92657@quantum> (raw)
In-Reply-To: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com>

Quoting Sylwester Nawrocki (2013-10-29 12:51:03)
> This patch series implements clock deregistration in the common clock
> framework. Detailed changes are listed at each patch. I have included
> an additional patch in this series for the omap3isp driver, required 
> to avoid regressions.

Taken into clk-next. Thanks for the fine rework!

Regards,
Mike

> 
> Changes since v5:
>  - fixed NULL clock handling in __clk_get(), __clk_put (patch 5/5).
> 
> Changes since v4:
>  - removed stray struct module forward declaration in patch 3/5.
> 
> Changes since v3:
>  - replaced WARN_ON() with WARN_ON_ONCE() in clk_nodrv_disable_unprepare()
>    callback.
> 
> Changes since v2:
>  - reordered the patches so the race condition is fixed before it can
>    actually cause any issues,
>  - fixed handling of NULL clock pointers in __clk_get(), __clk_put(),
>  - added patch adding actual asignment of clk->owner; more details are
>    discussed in that specific patch.
> 
> Changes since v1:
>  - moved of_clk_{lock, unlock}, __of_clk_get_from_provider() function
>    declaractions to a local header,
>  - renamed clk_dummy_* to clk_nodrv_*.
> 
> Sylwester Nawrocki (5):
>   omap3isp: Modify clocks registration to avoid circular references
>   clk: Provide not locked variant of of_clk_get_from_provider()
>   clkdev: Fix race condition in clock lookup from device tree
>   clk: Add common __clk_get(), __clk_put() implementations
>   clk: Implement clk_unregister()
> 
>  arch/arm/include/asm/clkdev.h         |    2 +
>  arch/blackfin/include/asm/clkdev.h    |    2 +
>  arch/mips/include/asm/clkdev.h        |    2 +
>  arch/sh/include/asm/clkdev.h          |    2 +
>  drivers/clk/clk.c                     |  185 +++++++++++++++++++++++++++++++--
>  drivers/clk/clk.h                     |   16 +++
>  drivers/clk/clkdev.c                  |   12 ++-
>  drivers/media/platform/omap3isp/isp.c |   22 ++--
>  drivers/media/platform/omap3isp/isp.h |    1 +
>  include/linux/clk-private.h           |    5 +
>  include/linux/clkdev.h                |    5 +
>  11 files changed, 235 insertions(+), 19 deletions(-)
>  create mode 100644 drivers/clk/clk.h
> 
> -- 
> 1.7.9.5

  parent reply	other threads:[~2013-10-30 19:43 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 19:51 [PATCH v7 0/5] clk: clock deregistration support Sylwester Nawrocki
2013-10-29 19:51 ` Sylwester Nawrocki
2013-10-29 19:51 ` Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 1/5] omap3isp: Modify clocks registration to avoid circular references Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 22:28   ` Laurent Pinchart
2013-10-29 22:28     ` Laurent Pinchart
2013-10-29 22:28     ` Laurent Pinchart
2013-10-29 23:28     ` Sebastian Reichel
2013-10-29 23:28       ` Sebastian Reichel
2013-10-29 23:28       ` Sebastian Reichel
2013-10-29 23:55       ` Laurent Pinchart
2013-10-29 23:55         ` Laurent Pinchart
2013-10-29 23:55         ` Laurent Pinchart
2013-10-29 23:57     ` Sylwester Nawrocki
2013-10-29 23:57       ` Sylwester Nawrocki
2013-10-29 23:57       ` Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 2/5] clk: Provide not locked variant of of_clk_get_from_provider() Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 3/5] clkdev: Fix race condition in clock lookup from device tree Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 4/5] clk: Add common __clk_get(), __clk_put() implementations Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-30  0:19   ` Russell King - ARM Linux
2013-10-30  0:19     ` Russell King - ARM Linux
2013-10-30  0:19     ` Russell King - ARM Linux
2013-10-29 19:51 ` [PATCH v7 5/5] clk: Implement clk_unregister() Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-29 19:51   ` Sylwester Nawrocki
2013-10-31 18:32   ` Stephen Warren
2013-10-31 18:32     ` Stephen Warren
2013-10-31 18:32     ` Stephen Warren
2013-10-31 18:55     ` Sylwester Nawrocki
2013-10-31 18:55       ` Sylwester Nawrocki
2013-10-31 18:55       ` Sylwester Nawrocki
2013-10-31 19:07       ` Stephen Warren
2013-10-31 19:07         ` Stephen Warren
2013-10-31 19:07         ` Stephen Warren
2013-10-30 19:42 ` Mike Turquette [this message]
2013-10-30 19:42   ` [PATCH v7 0/5] clk: clock deregistration support Mike Turquette
2013-10-30 19:42   ` Mike Turquette
2013-10-30 19:42   ` Mike Turquette
2013-11-01 13:56 ` Jonas Jensen
2013-11-01 13:56   ` Jonas Jensen
2013-11-01 13:56   ` Jonas Jensen
2013-11-01 16:41   ` Sylwester Nawrocki
2013-11-01 16:41     ` Sylwester Nawrocki
2013-11-01 16:41     ` Sylwester Nawrocki
2013-11-04  8:43     ` Jonas Jensen
2013-11-04  8:43       ` Jonas Jensen
2013-11-04  8:43       ` Jonas Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131030194252.11662.92657@quantum \
    --to=mturquette@linaro.org \
    --cc=jiada_wang@mentor.com \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=s.nawrocki@samsung.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.