From: Andrew Morton <akpm@linux-foundation.org>
To: kosaki.motohiro@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm: __rmqueue_fallback() should respect pageblock type
Date: Wed, 30 Oct 2013 21:35:37 -0700 [thread overview]
Message-ID: <20131030213537.f346d751.akpm@linux-foundation.org> (raw)
In-Reply-To: <1383193489-27331-1-git-send-email-kosaki.motohiro@gmail.com>
On Thu, 31 Oct 2013 00:24:49 -0400 kosaki.motohiro@gmail.com wrote:
> When __rmqueue_fallback() don't find out a free block with the same size
> of required, it splits a larger page and puts back rest peiece of the page
> to free list.
>
> But it has one serious mistake. When putting back, __rmqueue_fallback()
> always use start_migratetype if type is not CMA. However, __rmqueue_fallback()
> is only called when all of start_migratetype queue are empty. That said,
> __rmqueue_fallback always put back memory to wrong queue except
> try_to_steal_freepages() changed pageblock type (i.e. requested size is
> smaller than half of page block). Finally, antifragmentation framework
> increase fragmenation instead of decrease.
>
> Mel's original anti fragmentation do the right thing. But commit 47118af076
> (mm: mmzone: MIGRATE_CMA migration type added) broke it.
>
> This patch restores sane and old behavior.
What are the user-visible runtime effects of this change?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: kosaki.motohiro@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm: __rmqueue_fallback() should respect pageblock type
Date: Wed, 30 Oct 2013 21:35:37 -0700 [thread overview]
Message-ID: <20131030213537.f346d751.akpm@linux-foundation.org> (raw)
In-Reply-To: <1383193489-27331-1-git-send-email-kosaki.motohiro@gmail.com>
On Thu, 31 Oct 2013 00:24:49 -0400 kosaki.motohiro@gmail.com wrote:
> When __rmqueue_fallback() don't find out a free block with the same size
> of required, it splits a larger page and puts back rest peiece of the page
> to free list.
>
> But it has one serious mistake. When putting back, __rmqueue_fallback()
> always use start_migratetype if type is not CMA. However, __rmqueue_fallback()
> is only called when all of start_migratetype queue are empty. That said,
> __rmqueue_fallback always put back memory to wrong queue except
> try_to_steal_freepages() changed pageblock type (i.e. requested size is
> smaller than half of page block). Finally, antifragmentation framework
> increase fragmenation instead of decrease.
>
> Mel's original anti fragmentation do the right thing. But commit 47118af076
> (mm: mmzone: MIGRATE_CMA migration type added) broke it.
>
> This patch restores sane and old behavior.
What are the user-visible runtime effects of this change?
next prev parent reply other threads:[~2013-10-31 4:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 4:24 [PATCH] mm: __rmqueue_fallback() should respect pageblock type kosaki.motohiro
2013-10-31 4:24 ` kosaki.motohiro
2013-10-31 4:35 ` Andrew Morton [this message]
2013-10-31 4:35 ` Andrew Morton
2013-10-31 5:00 ` KOSAKI Motohiro
2013-10-31 5:00 ` KOSAKI Motohiro
2013-10-31 5:15 ` KOSAKI Motohiro
2013-10-31 5:15 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030213537.f346d751.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.