* Re: commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning [not found] <CAHH2t87SLhkwQHRDFDT3r5_MLxsE5v4LHoa0c9MNdzP0VLN3Yw@mail.gmail.com> @ 2013-10-31 9:15 ` Ville Syrjälä 2013-10-31 9:44 ` Daniel Vetter 0 siblings, 1 reply; 2+ messages in thread From: Ville Syrjälä @ 2013-10-31 9:15 UTC (permalink / raw) To: feng xiangjun; +Cc: Daniel Vetter, intel-gfx On Thu, Oct 31, 2013 at 09:33:24AM +0800, feng xiangjun wrote: > Hello, ville. > > Latest git commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning, > > + > +static void intel_crt_get_config(struct intel_encoder *encoder, > + struct intel_crtc_config *pipe_config) > +{ > + struct drm_device *dev = encoder->base.dev; > + > + pipe_config->adjusted_mode.flags |= intel_crt_get_flags(encoder); > +} > + > > dev not used. Daniel did the backport, so you get to blame him ;) I'm Cc:ing intel-gfx to avoid having the same discussion multiple times. -- Ville Syrjälä Intel OTC ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning 2013-10-31 9:15 ` commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning Ville Syrjälä @ 2013-10-31 9:44 ` Daniel Vetter 0 siblings, 0 replies; 2+ messages in thread From: Daniel Vetter @ 2013-10-31 9:44 UTC (permalink / raw) To: Ville Syrjälä; +Cc: intel-gfx, feng xiangjun On Thu, Oct 31, 2013 at 10:15 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Thu, Oct 31, 2013 at 09:33:24AM +0800, feng xiangjun wrote: >> Hello, ville. >> >> Latest git commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning, >> >> + >> +static void intel_crt_get_config(struct intel_encoder *encoder, >> + struct intel_crtc_config *pipe_config) >> +{ >> + struct drm_device *dev = encoder->base.dev; >> + >> + pipe_config->adjusted_mode.flags |= intel_crt_get_flags(encoder); >> +} >> + >> >> dev not used. > > Daniel did the backport, so you get to blame him ;) > > I'm Cc:ing intel-gfx to avoid having the same discussion multiple > times. I'll call meh on this one, -next has a version of the patch that doesn't have warnings. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-31 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAHH2t87SLhkwQHRDFDT3r5_MLxsE5v4LHoa0c9MNdzP0VLN3Yw@mail.gmail.com>
2013-10-31 9:15 ` commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning Ville Syrjälä
2013-10-31 9:44 ` Daniel Vetter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.