[PATCH] drm/i915/vlv: Fix typo in the DPIO register define.

[PATCH] drm/i915/vlv: Fix typo in the DPIO register define.

[Chon Ming Lee]

Incorrect definition DPIO_TX3_SWING_CTL4.

Signed-off-by: Chon Ming Lee <chon.ming.lee@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 6799d53..f7ecad2 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -444,7 +444,7 @@
 
 #define _DPIO_TX3_SWING_CTL4_A		0x690
 #define _DPIO_TX3_SWING_CTL4_B		0x2a90
-#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX_SWING_CTL4_A, \
+#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX3_SWING_CTL4_A, \
 					_DPIO_TX3_SWING_CTL4_B)
 
 /*
-- 
1.7.7.6

Re: [PATCH] drm/i915/vlv: Fix typo in the DPIO register define.

[Ville Syrjälä]

On Wed, Oct 30, 2013 at 10:05:19AM +0800, Chon Ming Lee wrote:
> Incorrect definition DPIO_TX3_SWING_CTL4.
> 
> Signed-off-by: Chon Ming Lee <chon.ming.lee@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Based on the specs, the typo meant that HDMI B ended up using
"incorrect" de-emphasis for the TMDS data lanes.

> ---
>  drivers/gpu/drm/i915/i915_reg.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 6799d53..f7ecad2 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -444,7 +444,7 @@
>  
>  #define _DPIO_TX3_SWING_CTL4_A		0x690
>  #define _DPIO_TX3_SWING_CTL4_B		0x2a90
> -#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX_SWING_CTL4_A, \
> +#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX3_SWING_CTL4_A, \
>  					_DPIO_TX3_SWING_CTL4_B)
>  
>  /*
> -- 
> 1.7.7.6
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

Re: [PATCH] drm/i915/vlv: Fix typo in the DPIO register define.

[Daniel Vetter]

On Thu, Oct 31, 2013 at 01:46:31PM +0200, Ville Syrjälä wrote:
> On Wed, Oct 30, 2013 at 10:05:19AM +0800, Chon Ming Lee wrote:
> > Incorrect definition DPIO_TX3_SWING_CTL4.
> > 
> > Signed-off-by: Chon Ming Lee <chon.ming.lee@intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
 
> Based on the specs, the typo meant that HDMI B ended up using
> "incorrect" de-emphasis for the TMDS data lanes.

I've added this explanation to the commit message to describe the impact a
bit better. Next time around please elaborate a bit more about the impact
of a change so other people have an idea how important a patch is or
whether it might help for a given issue they have.

Thanks, Daniel

> 
> > ---
> >  drivers/gpu/drm/i915/i915_reg.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 6799d53..f7ecad2 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -444,7 +444,7 @@
> >  
> >  #define _DPIO_TX3_SWING_CTL4_A		0x690
> >  #define _DPIO_TX3_SWING_CTL4_B		0x2a90
> > -#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX_SWING_CTL4_A, \
> > +#define DPIO_TX3_SWING_CTL4(pipe) _PIPE(pipe, _DPIO_TX3_SWING_CTL4_A, \
> >  					_DPIO_TX3_SWING_CTL4_B)
> >  
> >  /*
> > -- 
> > 1.7.7.6
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch