From: Ben Myers <bpm@sgi.com>
To: Denis Efremov <yefremov.denis@gmail.com>
Cc: ldv-project@linuxtesting.org, Alex Elder <elder@kernel.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null
Date: Thu, 31 Oct 2013 10:56:03 -0500 [thread overview]
Message-ID: <20131031155602.GP1935@sgi.com> (raw)
In-Reply-To: <20131025150609.GB10553@sgi.com>
On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote:
> On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> > ASSERT on args takes place after args dereference.
> > This assertion is redundant since we are going to panic anyway.
> >
> > Found by Linux Driver Verification project (linuxtesting.org) -
> > PVS-Studio analyzer.
> >
> > Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
>
> Looks good.
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
Applied. Thanks Denis.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Denis Efremov <yefremov.denis@gmail.com>
Cc: ldv-project@linuxtesting.org, Alex Elder <elder@kernel.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null
Date: Thu, 31 Oct 2013 10:56:03 -0500 [thread overview]
Message-ID: <20131031155602.GP1935@sgi.com> (raw)
In-Reply-To: <20131025150609.GB10553@sgi.com>
On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote:
> On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> > ASSERT on args takes place after args dereference.
> > This assertion is redundant since we are going to panic anyway.
> >
> > Found by Linux Driver Verification project (linuxtesting.org) -
> > PVS-Studio analyzer.
> >
> > Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
>
> Looks good.
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
Applied. Thanks Denis.
next prev parent reply other threads:[~2013-10-31 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 7:36 [PATCH] xfs:xfs_dir2_node.c: pointer use before check for null Denis Efremov
2013-10-22 7:36 ` Denis Efremov
2013-10-22 20:33 ` Dave Chinner
2013-10-22 20:33 ` Dave Chinner
2013-10-25 11:53 ` [PATCH v2] " Denis Efremov
2013-10-25 11:53 ` Denis Efremov
2013-10-25 15:06 ` Ben Myers
2013-10-25 15:06 ` Ben Myers
2013-10-31 15:56 ` Ben Myers [this message]
2013-10-31 15:56 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031155602.GP1935@sgi.com \
--to=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
--cc=yefremov.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.