From: Oleg Nesterov <oleg@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH 3/4][v2] audit: move audit_aux_data_execve contents into audit_context union
Date: Thu, 31 Oct 2013 18:18:10 +0100 [thread overview]
Message-ID: <20131031171810.GA8757@redhat.com> (raw)
In-Reply-To: <fe3109595c2dac17a55650b084a3c911f9e98597.1383233534.git.rgb@redhat.com>
On 10/31, Richard Guy Briggs wrote:
>
> --- a/kernel/audit.h
> +++ b/kernel/audit.h
> @@ -197,6 +197,10 @@ struct audit_context {
> int fd;
> int flags;
> } mmap;
> + struct {
> + int argc;
> + struct mm_struct *mm;
> + } execve;
Ah, nice, so we should not worry about kmalloc(GFP_KERNEL) failure.
I am in no position to ack the changes in this area, but the whole
series looks fine to me.
Oleg.
next prev parent reply other threads:[~2013-10-31 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 15:37 [PATCH 0/4][v2] audit: Tidy up audit_context and stop bprm recursion Richard Guy Briggs
2013-10-31 15:37 ` [PATCH 1/4][v2] audit: Kill the unused struct audit_aux_data_capset Richard Guy Briggs
2013-10-31 15:37 ` [PATCH 2/4][v2] audit: remove unused envc member of audit_aux_data_execve Richard Guy Briggs
2013-10-31 15:37 ` Richard Guy Briggs
2013-10-31 15:37 ` [PATCH 3/4][v2] audit: move audit_aux_data_execve contents into audit_context union Richard Guy Briggs
2013-10-31 15:37 ` Richard Guy Briggs
2013-10-31 17:18 ` Oleg Nesterov [this message]
2013-10-31 15:37 ` [PATCH 4/4][v2] audit: call audit_bprm() only once to add AUDIT_EXECVE information Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031171810.GA8757@redhat.com \
--to=oleg@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.