From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Select CONFIG_AGP and CONFIG_AGP_INTEL
Date: Fri, 1 Nov 2013 11:00:01 +0200 [thread overview]
Message-ID: <20131101090001.GF13047@intel.com> (raw)
In-Reply-To: <CAKMK7uHYpRsyRwnuoJ-va7bykD+q-d-hW-6NsoShoDNyf8CwFw@mail.gmail.com>
On Fri, Nov 01, 2013 at 09:54:39AM +0100, Daniel Vetter wrote:
> On Fri, Nov 1, 2013 at 9:38 AM, <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > i915 depends on CONFIG_AGP and CONFIG_AGP_INTEL. Since AGP is a thing
> > of the past, it's somewhat likely that a user would not realize that
> > they need to enable those to get i915. So let's just select CONFIG_AGP
> > and CONFIG_AGP_INTEL instead of depending on them.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We don't actually need agp, at least for the kms driver. So I'd go the
> other direction and make it fully optional. UMS won't work if someone
> misconfigures their kernel, but meh.
Don't we still need the AGP backend code for GTT frobbing on older gens?
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-11-01 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 8:38 [PATCH] drm/i915: Select CONFIG_AGP and CONFIG_AGP_INTEL ville.syrjala
2013-11-01 8:54 ` Daniel Vetter
2013-11-01 9:00 ` Ville Syrjälä [this message]
2013-11-01 9:22 ` Daniel Vetter
2013-11-01 13:18 ` [PATCH] drm/i915: Make AGP support optional ville.syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101090001.GF13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.