From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Julian Stecklina
<jsteckli-IG//nw+yl+iQIjdd1DhZXWfrygkm6VTR@public.gmane.org>
Cc: David Woodhouse
<David.Woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] vfio, iommu: Fixed interaction of VFIO_IOMMU_MAP_DMA with IOMMU address limits
Date: Fri, 1 Nov 2013 12:53:36 +0100 [thread overview]
Message-ID: <20131101115336.GH17455@8bytes.org> (raw)
In-Reply-To: <1381305832-2900-1-git-send-email-jsteckli-IG//nw+yl+iQIjdd1DhZXWfrygkm6VTR@public.gmane.org>
On Wed, Oct 09, 2013 at 10:03:52AM +0200, Julian Stecklina wrote:
> The BUG_ON in drivers/iommu/intel-iommu.c:785 can be triggered from userspace via
> VFIO by calling the VFIO_IOMMU_MAP_DMA ioctl on a vfio device with any address
> beyond the addressing capabilities of the IOMMU. The problem is that the ioctl code
> calls iommu_iova_to_phys before it calls iommu_map. iommu_map handles the case that
> it gets addresses beyond the addressing capabilities of its IOMMU.
> intel_iommu_iova_to_phys does not.
>
> This patch fixes iommu_iova_to_phys to return NULL for addresses beyond what the
> IOMMU can handle. This in turn causes the ioctl call to fail in iommu_map and
> (correctly) return EFAULT to the user with a helpful warning message in the kernel
> log.
>
> Signed-off-by: Julian Stecklina <jsteckli-IG//nw+yl+iQIjdd1DhZXWfrygkm6VTR@public.gmane.org>
> Acked-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Julian Stecklina <jsteckli@os.inf.tu-dresden.de>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] vfio, iommu: Fixed interaction of VFIO_IOMMU_MAP_DMA with IOMMU address limits
Date: Fri, 1 Nov 2013 12:53:36 +0100 [thread overview]
Message-ID: <20131101115336.GH17455@8bytes.org> (raw)
In-Reply-To: <1381305832-2900-1-git-send-email-jsteckli@os.inf.tu-dresden.de>
On Wed, Oct 09, 2013 at 10:03:52AM +0200, Julian Stecklina wrote:
> The BUG_ON in drivers/iommu/intel-iommu.c:785 can be triggered from userspace via
> VFIO by calling the VFIO_IOMMU_MAP_DMA ioctl on a vfio device with any address
> beyond the addressing capabilities of the IOMMU. The problem is that the ioctl code
> calls iommu_iova_to_phys before it calls iommu_map. iommu_map handles the case that
> it gets addresses beyond the addressing capabilities of its IOMMU.
> intel_iommu_iova_to_phys does not.
>
> This patch fixes iommu_iova_to_phys to return NULL for addresses beyond what the
> IOMMU can handle. This in turn causes the ioctl call to fail in iommu_map and
> (correctly) return EFAULT to the user with a helpful warning message in the kernel
> log.
>
> Signed-off-by: Julian Stecklina <jsteckli@os.inf.tu-dresden.de>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
Applied, thanks.
next prev parent reply other threads:[~2013-11-01 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 9:57 [PATCH] vfio, iommu: Fixed interaction of VFIO_IOMMU_MAP_DMA with IOMMU address limits Julian Stecklina
[not found] ` <1377597428-21480-1-git-send-email-jsteckli-IG//nw+yl+iQIjdd1DhZXWfrygkm6VTR@public.gmane.org>
2013-08-28 15:44 ` Alex Williamson
2013-08-28 15:44 ` Alex Williamson
[not found] ` <1377704672.10408.81.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2013-10-09 8:03 ` Julian Stecklina
2013-10-09 8:03 ` Julian Stecklina
[not found] ` <1381305832-2900-1-git-send-email-jsteckli-IG//nw+yl+iQIjdd1DhZXWfrygkm6VTR@public.gmane.org>
2013-11-01 11:53 ` Joerg Roedel [this message]
2013-11-01 11:53 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101115336.GH17455@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=David.Woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jsteckli-IG//nw+yl+iQIjdd1DhZXWfrygkm6VTR@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.