* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-11-02 16:09 Marc MERLIN
0 siblings, 0 replies; 19+ messages in thread
From: Marc MERLIN @ 2013-11-02 16:09 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2646 bytes --]
On Fri, Oct 18, 2013 at 11:09:26AM -0700, Kristen Carlson Accardi wrote:
> Please test.
I let it run, my screen blanked (on batteries) and when I unblanked it, I got:
warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7fff96dfe000
Core was generated by `powertop-2.5'.
Program terminated with signal 6, Aborted.
#0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
in ../nptl/sysdeps/unix/sysv/linux/raise.c
(gdb) bt
#0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1 0x00007f0f5f0e9398 in __GI_abort () at abort.c:90
#2 0x00007f0f5f1217cb in __libc_message (do_abort=2, fmt=0x7f0f5f21b895 "*** %s ***: %s terminated\n")
at ../sysdeps/unix/sysv/linux/libc_fatal.c:199
#3 0x00007f0f5f1add17 in __GI___fortify_fail (msg=0x7f0f5f21b82c "buffer overflow detected")
at fortify_fail.c:31
#4 0x00007f0f5f1accd0 in __GI___chk_fail () at chk_fail.c:28
#5 0x00007f0f5f1ac159 in _IO_str_chk_overflow (fp=<optimized out>, c=<optimized out>) at vsprintf_chk.c:33
#6 0x00007f0f5f129209 in __GI__IO_default_xsputn (f=0x7fff96df2430, data=<optimized out>, n=21) at genops.c:481
#7 0x00007f0f5f0fea89 in ___printf_fp (fp=<optimized out>, info=<optimized out>, args=<optimized out>)
at printf_fp.c:1254
#8 0x00007f0f5f0f8b26 in _IO_vfprintf_internal (s=<optimized out>, format=<optimized out>, ap=<optimized out>)
at vfprintf.c:1648
#9 0x00007f0f5f1ac1f7 in ___vsprintf_chk (s=0x7fff96df2730 "-160686063957739622", flags=1, slen=20,
format=0x450588 "%5.1f%s", args=0x7fff96df2558) at vsprintf_chk.c:85
#10 0x00007f0f5f1ac13d in ___sprintf_chk (s=<optimized out>, flags=<optimized out>, slen=<optimized out>,
format=<optimized out>) at sprintf_chk.c:32
#11 0x00000000004263b8 in sprintf (__fmt=0x450588 "%5.1f%s", __s=0x7fff96df2730 "-160686063957739622")
at /usr/include/x86_64-linux-gnu/bits/stdio2.h:34
#12 process_update_display () at process/do_process.cpp:869
#13 0x0000000000443b35 in one_measurement (seconds=<optimized out>, workload=<optimized out>) at main.cpp:215
#14 0x0000000000407762 in main (argc=1, argv=0x7fff96df4928) at main.cpp:468
This does not reproduce at will, but hopefully it helps.
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-11-27 7:46 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-11-27 7:46 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 4287 bytes --]
On (11/26/13 13:58), Marc MERLIN wrote:
> Date: Tue, 26 Nov 2013 13:58:31 -0800
> From: Marc MERLIN <marc_powertop(a)merlins.org>
> To: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
> Cc: Kristen Carlson Accardi <kristen(a)linux.intel.com>, powertop(a)ml01.01.org
> Subject: Re: [Powertop] [Announce] v2.5-rc1
> X-URL: http://marc.merlins.org/
> User-Agent: Mutt/1.5.21 (2010-09-15)
>
> On Tue, Nov 26, 2013 at 10:36:14PM +0300, Sergey Senozhatsky wrote:
> > On (11/02/13 09:09), Marc MERLIN wrote:
> > > On Fri, Oct 18, 2013 at 11:09:26AM -0700, Kristen Carlson Accardi wrote:
> > > > Please test.
> > >
> >
> > Hello Marc,
> > thanks for reporting. while I see the reason of that crash, I can't see
> > how did we come that far. could you please run powertop under strace?
>
> I can't reproduce at will unfortunately, and it hasn't happened again
> since then, so I'm not sure I will be able to, sorry.
no problem.
-ss
> Marc
>
> > thank you,
> >
> > -ss
> >
> > > I let it run, my screen blanked (on batteries) and when I unblanked it, I got:
> > > warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7fff96dfe000
> > > Core was generated by `powertop-2.5'.
> > > Program terminated with signal 6, Aborted.
> > > #0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> > > 56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
> > > in ../nptl/sysdeps/unix/sysv/linux/raise.c
> > > (gdb) bt
> > > #0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> > > #1 0x00007f0f5f0e9398 in __GI_abort () at abort.c:90
> > > #2 0x00007f0f5f1217cb in __libc_message (do_abort=2, fmt=0x7f0f5f21b895 "*** %s ***: %s terminated\n")
> > > at ../sysdeps/unix/sysv/linux/libc_fatal.c:199
> > > #3 0x00007f0f5f1add17 in __GI___fortify_fail (msg=0x7f0f5f21b82c "buffer overflow detected")
> > > at fortify_fail.c:31
> > > #4 0x00007f0f5f1accd0 in __GI___chk_fail () at chk_fail.c:28
> > > #5 0x00007f0f5f1ac159 in _IO_str_chk_overflow (fp=<optimized out>, c=<optimized out>) at vsprintf_chk.c:33
> > > #6 0x00007f0f5f129209 in __GI__IO_default_xsputn (f=0x7fff96df2430, data=<optimized out>, n=21) at genops.c:481
> > > #7 0x00007f0f5f0fea89 in ___printf_fp (fp=<optimized out>, info=<optimized out>, args=<optimized out>)
> > > at printf_fp.c:1254
> > > #8 0x00007f0f5f0f8b26 in _IO_vfprintf_internal (s=<optimized out>, format=<optimized out>, ap=<optimized out>)
> > > at vfprintf.c:1648
> > > #9 0x00007f0f5f1ac1f7 in ___vsprintf_chk (s=0x7fff96df2730 "-160686063957739622", flags=1, slen=20,
> > > format=0x450588 "%5.1f%s", args=0x7fff96df2558) at vsprintf_chk.c:85
> > > #10 0x00007f0f5f1ac13d in ___sprintf_chk (s=<optimized out>, flags=<optimized out>, slen=<optimized out>,
> > > format=<optimized out>) at sprintf_chk.c:32
> > > #11 0x00000000004263b8 in sprintf (__fmt=0x450588 "%5.1f%s", __s=0x7fff96df2730 "-160686063957739622")
> > > at /usr/include/x86_64-linux-gnu/bits/stdio2.h:34
> > > #12 process_update_display () at process/do_process.cpp:869
> > > #13 0x0000000000443b35 in one_measurement (seconds=<optimized out>, workload=<optimized out>) at main.cpp:215
> > > #14 0x0000000000407762 in main (argc=1, argv=0x7fff96df4928) at main.cpp:468
> > >
> > > This does not reproduce at will, but hopefully it helps.
> > >
> > > Marc
> > > --
> > > "A mouse is a device used to point at the xterm you want to type in" - A.S.R.
> > > Microsoft is to operating systems ....
> > > .... what McDonalds is to gourmet cooking
> > > Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
> > > _______________________________________________
> > > PowerTop mailing list
> > > PowerTop(a)lists.01.org
> > > https://lists.01.org/mailman/listinfo/powertop
> > >
> >
>
> --
> "A mouse is a device used to point at the xterm you want to type in" - A.S.R.
> Microsoft is to operating systems ....
> .... what McDonalds is to gourmet cooking
> Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-11-26 21:58 Marc MERLIN
0 siblings, 0 replies; 19+ messages in thread
From: Marc MERLIN @ 2013-11-26 21:58 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 3721 bytes --]
On Tue, Nov 26, 2013 at 10:36:14PM +0300, Sergey Senozhatsky wrote:
> On (11/02/13 09:09), Marc MERLIN wrote:
> > On Fri, Oct 18, 2013 at 11:09:26AM -0700, Kristen Carlson Accardi wrote:
> > > Please test.
> >
>
> Hello Marc,
> thanks for reporting. while I see the reason of that crash, I can't see
> how did we come that far. could you please run powertop under strace?
I can't reproduce at will unfortunately, and it hasn't happened again
since then, so I'm not sure I will be able to, sorry.
Marc
> thank you,
>
> -ss
>
> > I let it run, my screen blanked (on batteries) and when I unblanked it, I got:
> > warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7fff96dfe000
> > Core was generated by `powertop-2.5'.
> > Program terminated with signal 6, Aborted.
> > #0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> > 56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
> > in ../nptl/sysdeps/unix/sysv/linux/raise.c
> > (gdb) bt
> > #0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> > #1 0x00007f0f5f0e9398 in __GI_abort () at abort.c:90
> > #2 0x00007f0f5f1217cb in __libc_message (do_abort=2, fmt=0x7f0f5f21b895 "*** %s ***: %s terminated\n")
> > at ../sysdeps/unix/sysv/linux/libc_fatal.c:199
> > #3 0x00007f0f5f1add17 in __GI___fortify_fail (msg=0x7f0f5f21b82c "buffer overflow detected")
> > at fortify_fail.c:31
> > #4 0x00007f0f5f1accd0 in __GI___chk_fail () at chk_fail.c:28
> > #5 0x00007f0f5f1ac159 in _IO_str_chk_overflow (fp=<optimized out>, c=<optimized out>) at vsprintf_chk.c:33
> > #6 0x00007f0f5f129209 in __GI__IO_default_xsputn (f=0x7fff96df2430, data=<optimized out>, n=21) at genops.c:481
> > #7 0x00007f0f5f0fea89 in ___printf_fp (fp=<optimized out>, info=<optimized out>, args=<optimized out>)
> > at printf_fp.c:1254
> > #8 0x00007f0f5f0f8b26 in _IO_vfprintf_internal (s=<optimized out>, format=<optimized out>, ap=<optimized out>)
> > at vfprintf.c:1648
> > #9 0x00007f0f5f1ac1f7 in ___vsprintf_chk (s=0x7fff96df2730 "-160686063957739622", flags=1, slen=20,
> > format=0x450588 "%5.1f%s", args=0x7fff96df2558) at vsprintf_chk.c:85
> > #10 0x00007f0f5f1ac13d in ___sprintf_chk (s=<optimized out>, flags=<optimized out>, slen=<optimized out>,
> > format=<optimized out>) at sprintf_chk.c:32
> > #11 0x00000000004263b8 in sprintf (__fmt=0x450588 "%5.1f%s", __s=0x7fff96df2730 "-160686063957739622")
> > at /usr/include/x86_64-linux-gnu/bits/stdio2.h:34
> > #12 process_update_display () at process/do_process.cpp:869
> > #13 0x0000000000443b35 in one_measurement (seconds=<optimized out>, workload=<optimized out>) at main.cpp:215
> > #14 0x0000000000407762 in main (argc=1, argv=0x7fff96df4928) at main.cpp:468
> >
> > This does not reproduce at will, but hopefully it helps.
> >
> > Marc
> > --
> > "A mouse is a device used to point at the xterm you want to type in" - A.S.R.
> > Microsoft is to operating systems ....
> > .... what McDonalds is to gourmet cooking
> > Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
> > _______________________________________________
> > PowerTop mailing list
> > PowerTop(a)lists.01.org
> > https://lists.01.org/mailman/listinfo/powertop
> >
>
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-11-26 19:36 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-11-26 19:36 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 3110 bytes --]
On (11/02/13 09:09), Marc MERLIN wrote:
> On Fri, Oct 18, 2013 at 11:09:26AM -0700, Kristen Carlson Accardi wrote:
> > Please test.
>
Hello Marc,
thanks for reporting. while I see the reason of that crash, I can't see
how did we come that far. could you please run powertop under strace?
thank you,
-ss
> I let it run, my screen blanked (on batteries) and when I unblanked it, I got:
> warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7fff96dfe000
> Core was generated by `powertop-2.5'.
> Program terminated with signal 6, Aborted.
> #0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> 56 ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
> in ../nptl/sysdeps/unix/sysv/linux/raise.c
> (gdb) bt
> #0 0x00007f0f5f0e61e5 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
> #1 0x00007f0f5f0e9398 in __GI_abort () at abort.c:90
> #2 0x00007f0f5f1217cb in __libc_message (do_abort=2, fmt=0x7f0f5f21b895 "*** %s ***: %s terminated\n")
> at ../sysdeps/unix/sysv/linux/libc_fatal.c:199
> #3 0x00007f0f5f1add17 in __GI___fortify_fail (msg=0x7f0f5f21b82c "buffer overflow detected")
> at fortify_fail.c:31
> #4 0x00007f0f5f1accd0 in __GI___chk_fail () at chk_fail.c:28
> #5 0x00007f0f5f1ac159 in _IO_str_chk_overflow (fp=<optimized out>, c=<optimized out>) at vsprintf_chk.c:33
> #6 0x00007f0f5f129209 in __GI__IO_default_xsputn (f=0x7fff96df2430, data=<optimized out>, n=21) at genops.c:481
> #7 0x00007f0f5f0fea89 in ___printf_fp (fp=<optimized out>, info=<optimized out>, args=<optimized out>)
> at printf_fp.c:1254
> #8 0x00007f0f5f0f8b26 in _IO_vfprintf_internal (s=<optimized out>, format=<optimized out>, ap=<optimized out>)
> at vfprintf.c:1648
> #9 0x00007f0f5f1ac1f7 in ___vsprintf_chk (s=0x7fff96df2730 "-160686063957739622", flags=1, slen=20,
> format=0x450588 "%5.1f%s", args=0x7fff96df2558) at vsprintf_chk.c:85
> #10 0x00007f0f5f1ac13d in ___sprintf_chk (s=<optimized out>, flags=<optimized out>, slen=<optimized out>,
> format=<optimized out>) at sprintf_chk.c:32
> #11 0x00000000004263b8 in sprintf (__fmt=0x450588 "%5.1f%s", __s=0x7fff96df2730 "-160686063957739622")
> at /usr/include/x86_64-linux-gnu/bits/stdio2.h:34
> #12 process_update_display () at process/do_process.cpp:869
> #13 0x0000000000443b35 in one_measurement (seconds=<optimized out>, workload=<optimized out>) at main.cpp:215
> #14 0x0000000000407762 in main (argc=1, argv=0x7fff96df4928) at main.cpp:468
>
> This does not reproduce at will, but hopefully it helps.
>
> Marc
> --
> "A mouse is a device used to point at the xterm you want to type in" - A.S.R.
> Microsoft is to operating systems ....
> .... what McDonalds is to gourmet cooking
> Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-23 19:06 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-23 19:06 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
On (10/23/13 11:32), Alexandra Yates wrote:
[..]
> >
> >
> YES! that fixes the menu! It works in IE, FF, Chrome :)
>
> Thank you,
> Alexandra.
good news, thank you!
will prepare a patch.
-ss
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-23 18:32 Alexandra Yates
0 siblings, 0 replies; 19+ messages in thread
From: Alexandra Yates @ 2013-10-23 18:32 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]
> On (10/23/13 09:12), Alexandra Yates wrote:
>> >>
>> >> This change enables the menu links and mouse over, but the font and
>> the
>> >> button background are all black, I don't think the css are working
>> here.
>> >> I will send you the image to your email that way you get to see it.
>> >>
>> >
>> > thanks. well, that's weird. I found rdesktop-ed win box around and
>> tested
>> > generated report on IE (don't know the version - 8 or 9). what IE
>> version
>> > is on the picture?
>> >
>>
>> You are welcome, what version of IE are you running?
>>
>
> ok. this is really the last one :)
>
> I think I found the issue -- textContent support in IE.
>
>
> ---
> src/powertop.css | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/src/powertop.css b/src/powertop.css
> index 6d43e07..ce7dbb2 100644
> --- a/src/powertop.css
> +++ b/src/powertop.css
> @@ -17,20 +17,29 @@ var powertop = {
> },
> cadd: function(idx, c){
> var el = document.getElementById(idx);
> - if (el)
> - el.classList.add(c);
> -
> + if (el) {
> + var cn = el.className;
> + if (cn.indexOf(c) != -1)
> + return;
> + cn += ' ' + c;
> + el.className = cn;
> + }
> },
> crm: function(id, c){
> var el = document.getElementById(id);
> - if (el)
> - el.classList.remove(c);
> + if (el) {
> + var cn = el.className
> + while (cn.indexOf(' ' + c) != -1)
> + cn = cn.replace(' ' + c,'');
> + el.className = cn;
> + }
> },
> newbutton: function(id, txt) {
> var x = document.createElement('div');
> x.id = id + '_button';
> x.className = 'nav_button';
> x.textContent = txt;
> + x.innerText = txt;
> x.onclick = function() { powertop.toggle(id); };
> return x;
> },
>
>
YES! that fixes the menu! It works in IE, FF, Chrome :)
Thank you,
Alexandra.
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-23 18:00 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-23 18:00 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]
On (10/23/13 09:12), Alexandra Yates wrote:
> >>
> >> This change enables the menu links and mouse over, but the font and the
> >> button background are all black, I don't think the css are working here.
> >> I will send you the image to your email that way you get to see it.
> >>
> >
> > thanks. well, that's weird. I found rdesktop-ed win box around and tested
> > generated report on IE (don't know the version - 8 or 9). what IE version
> > is on the picture?
> >
>
> You are welcome, what version of IE are you running?
>
ok. this is really the last one :)
I think I found the issue -- textContent support in IE.
---
src/powertop.css | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/powertop.css b/src/powertop.css
index 6d43e07..ce7dbb2 100644
--- a/src/powertop.css
+++ b/src/powertop.css
@@ -17,20 +17,29 @@ var powertop = {
},
cadd: function(idx, c){
var el = document.getElementById(idx);
- if (el)
- el.classList.add(c);
-
+ if (el) {
+ var cn = el.className;
+ if (cn.indexOf(c) != -1)
+ return;
+ cn += ' ' + c;
+ el.className = cn;
+ }
},
crm: function(id, c){
var el = document.getElementById(id);
- if (el)
- el.classList.remove(c);
+ if (el) {
+ var cn = el.className
+ while (cn.indexOf(' ' + c) != -1)
+ cn = cn.replace(' ' + c,'');
+ el.className = cn;
+ }
},
newbutton: function(id, txt) {
var x = document.createElement('div');
x.id = id + '_button';
x.className = 'nav_button';
x.textContent = txt;
+ x.innerText = txt;
x.onclick = function() { powertop.toggle(id); };
return x;
},
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-23 16:58 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-23 16:58 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
On (10/23/13 09:12), Alexandra Yates wrote:
> >> This change enables the menu links and mouse over, but the font and the
> >> button background are all black, I don't think the css are working here.
> >> I will send you the image to your email that way you get to see it.
> >>
> >
> > thanks. well, that's weird. I found rdesktop-ed win box around and tested
> > generated report on IE (don't know the version - 8 or 9). what IE version
> > is on the picture?
> >
> >
>
> You are welcome, what version of IE are you running?
>
ok, last chance. [not tested on IE 8]
could you please try this one?
---
src/powertop.css | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/powertop.css b/src/powertop.css
index 6d43e07..64f8de2 100644
--- a/src/powertop.css
+++ b/src/powertop.css
@@ -17,14 +17,22 @@ var powertop = {
},
cadd: function(idx, c){
var el = document.getElementById(idx);
- if (el)
- el.classList.add(c);
-
+ if (el) {
+ var cn = el.className;
+ if (cn.indexOf(c) != -1)
+ return;
+ cn += ' ' + c;
+ el.className = cn;
+ }
},
crm: function(id, c){
var el = document.getElementById(id);
- if (el)
- el.classList.remove(c);
+ if (el) {
+ var cn = el.className
+ while (cn.indexOf(' ' + c) != -1)
+ cn = cn.replace(' ' + c,'');
+ el.className = cn;
+ }
},
newbutton: function(id, txt) {
var x = document.createElement('div');
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-23 16:31 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-23 16:31 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On (10/23/13 09:12), Alexandra Yates wrote:
> > thanks. well, that's weird. I found rdesktop-ed win box around and tested
> > generated report on IE (don't know the version - 8 or 9). what IE version
> > is on the picture?
> >
>
> You are welcome, what version of IE are you running?
>
v9. report renders just fine. looks like IE v8 specific problem and
[if so] I'd probably consider reverting the commit -- too much pain.
do you have any chance to check with different IE versions?
-ss
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-23 16:12 Alexandra Yates
0 siblings, 0 replies; 19+ messages in thread
From: Alexandra Yates @ 2013-10-23 16:12 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
> On (10/22/13 11:05), Alexandra Yates wrote:
>>
>> This change enables the menu links and mouse over, but the font and the
>> button background are all black, I don't think the css are working here.
>> I will send you the image to your email that way you get to see it.
>>
>
> thanks. well, that's weird. I found rdesktop-ed win box around and tested
> generated report on IE (don't know the version - 8 or 9). what IE version
> is on the picture?
>
> -ss
>
You are welcome, what version of IE are you running?
Thank you,
Alexandra.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-22 21:44 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-22 21:44 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
On (10/22/13 11:05), Alexandra Yates wrote:
>
> This change enables the menu links and mouse over, but the font and the
> button background are all black, I don't think the css are working here.
> I will send you the image to your email that way you get to see it.
>
thanks. well, that's weird. I found rdesktop-ed win box around and tested
generated report on IE (don't know the version - 8 or 9). what IE version
is on the picture?
-ss
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-22 18:05 Alexandra Yates
0 siblings, 0 replies; 19+ messages in thread
From: Alexandra Yates @ 2013-10-22 18:05 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]
> On (10/21/13 17:21), Yates, Alexandra wrote:
>> IE 8.0 up to 10 doesn't display the menu bar nor any of the links.
>
> please test the following patch.
>
> ------8<-----8<--------
>
> IE up to v10 does not support object classList. workaround
> by manual className manipulation.
>
> Reported-by: Alexandra Yates <alexandra.yates(a)intel.com>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
>
> ---
>
> src/powertop.css | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/src/powertop.css b/src/powertop.css
> index 6d43e07..c58d757 100644
> --- a/src/powertop.css
> +++ b/src/powertop.css
> @@ -17,14 +17,20 @@ var powertop = {
> },
> cadd: function(idx, c){
> var el = document.getElementById(idx);
> - if (el)
> - el.classList.add(c);
> -
> + if (el) {
> + var cn = el.className;
> + cn += ' ' + c;
> + el.className = cn;
> + }
> },
> crm: function(id, c){
> var el = document.getElementById(id);
> - if (el)
> - el.classList.remove(c);
> + if (el) {
> + var cn = el.className
> + while (cn.indexOf(' ' + c) != -1)
> + cn = cn.replace(' ' + c,'');
> + el.className = cn;
> + }
> },
> newbutton: function(id, txt) {
> var x = document.createElement('div');
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
This change enables the menu links and mouse over, but the font and the
button background are all black, I don't think the css are working here.
I will send you the image to your email that way you get to see it.
Thank you,
Alexandra.
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-22 8:56 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-22 8:56 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On (10/21/13 17:21), Yates, Alexandra wrote:
> IE 8.0 up to 10 doesn't display the menu bar nor any of the links.
please test the following patch.
------8<-----8<--------
IE up to v10 does not support object classList. workaround
by manual className manipulation.
Reported-by: Alexandra Yates <alexandra.yates(a)intel.com>
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
---
src/powertop.css | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/powertop.css b/src/powertop.css
index 6d43e07..c58d757 100644
--- a/src/powertop.css
+++ b/src/powertop.css
@@ -17,14 +17,20 @@ var powertop = {
},
cadd: function(idx, c){
var el = document.getElementById(idx);
- if (el)
- el.classList.add(c);
-
+ if (el) {
+ var cn = el.className;
+ cn += ' ' + c;
+ el.className = cn;
+ }
},
crm: function(id, c){
var el = document.getElementById(id);
- if (el)
- el.classList.remove(c);
+ if (el) {
+ var cn = el.className
+ while (cn.indexOf(' ' + c) != -1)
+ cn = cn.replace(' ' + c,'');
+ el.className = cn;
+ }
},
newbutton: function(id, txt) {
var x = document.createElement('div');
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-22 8:16 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-22 8:16 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On (10/19/13 01:17), Daniel Kahn Gillmor wrote:
> On 10/18/2013 06:33 PM, Yates, Alexandra wrote:
> > Tested PowerTop different platforms including Linux and Windows. The following patch breaks IE compatibility.
> >
> > https://lists.01.org/pipermail/powertop/2013-September/000925.html
>
> Can you describe how IE breaks? what specifically fails? is there an
> explicit javascript error or a backtrace or debug log or something? Is
> data lost or hidden?
>
> sorry, but i don't have IE to test with, or a windows platform to run it
> on if i did.
>
ok, classList is not supported by IE10 and older.
so this generates NULL object access:
var el = document.getElementById(idx);
if (el)
el.classList.add(c);
-ss
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-21 17:21 Yates, Alexandra
0 siblings, 0 replies; 19+ messages in thread
From: Yates, Alexandra @ 2013-10-21 17:21 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
IE 8.0 up to 10 doesn't display the menu bar nor any of the links.
Thank you,
Alexandra.
-----Original Message-----
From: Sergey Senozhatsky [mailto:sergey.senozhatsky(a)gmail.com]
Sent: Saturday, October 19, 2013 12:00 AM
To: Yates, Alexandra
Cc: powertop(a)lists.01.org
Subject: Re: [Powertop] [Announce] v2.5-rc1
On (10/18/13 22:33), Yates, Alexandra wrote:
> Tested PowerTop different platforms including Linux and Windows. The following patch breaks IE compatibility.
>
> https://lists.01.org/pipermail/powertop/2013-September/000925.html
>
more details please: what IE version; how do we break it?
powertop.html
-- firebug console: no errors
-- w3c validation: no error, passed (green)
-ss
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-19 7:00 Sergey Senozhatsky
0 siblings, 0 replies; 19+ messages in thread
From: Sergey Senozhatsky @ 2013-10-19 7:00 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On (10/18/13 22:33), Yates, Alexandra wrote:
> Tested PowerTop different platforms including Linux and Windows. The following patch breaks IE compatibility.
>
> https://lists.01.org/pipermail/powertop/2013-September/000925.html
>
more details please: what IE version; how do we break it?
powertop.html
-- firebug console: no errors
-- w3c validation: no error, passed (green)
-ss
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-19 5:17 Daniel Kahn Gillmor
0 siblings, 0 replies; 19+ messages in thread
From: Daniel Kahn Gillmor @ 2013-10-19 5:17 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On 10/18/2013 06:33 PM, Yates, Alexandra wrote:
> Tested PowerTop different platforms including Linux and Windows. The following patch breaks IE compatibility.
>
> https://lists.01.org/pipermail/powertop/2013-September/000925.html
Can you describe how IE breaks? what specifically fails? is there an
explicit javascript error or a backtrace or debug log or something? Is
data lost or hidden?
sorry, but i don't have IE to test with, or a windows platform to run it
on if i did.
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1027 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Powertop] [Announce] v2.5-rc1
@ 2013-10-18 22:33 Yates, Alexandra
0 siblings, 0 replies; 19+ messages in thread
From: Yates, Alexandra @ 2013-10-18 22:33 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
Tested PowerTop different platforms including Linux and Windows. The following patch breaks IE compatibility.
https://lists.01.org/pipermail/powertop/2013-September/000925.html
Thank you,
Alexandra.
-----Original Message-----
From: powertop-bounces(a)lists.01.org [mailto:powertop-bounces(a)lists.01.org] On Behalf Of Kristen Carlson Accardi
Sent: Friday, October 18, 2013 11:09 AM
To: powertop(a)lists.01.org
Subject: [Powertop] [Announce] v2.5-rc1
Please test.
Thanks,
Kristen
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Powertop] [Announce] v2.5-rc1
@ 2013-10-18 18:09 Kristen Carlson Accardi
0 siblings, 0 replies; 19+ messages in thread
From: Kristen Carlson Accardi @ 2013-10-18 18:09 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 34 bytes --]
Please test.
Thanks,
Kristen
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2013-11-27 7:46 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-02 16:09 [Powertop] [Announce] v2.5-rc1 Marc MERLIN
-- strict thread matches above, loose matches on Subject: below --
2013-11-27 7:46 Sergey Senozhatsky
2013-11-26 21:58 Marc MERLIN
2013-11-26 19:36 Sergey Senozhatsky
2013-10-23 19:06 Sergey Senozhatsky
2013-10-23 18:32 Alexandra Yates
2013-10-23 18:00 Sergey Senozhatsky
2013-10-23 16:58 Sergey Senozhatsky
2013-10-23 16:31 Sergey Senozhatsky
2013-10-23 16:12 Alexandra Yates
2013-10-22 21:44 Sergey Senozhatsky
2013-10-22 18:05 Alexandra Yates
2013-10-22 8:56 Sergey Senozhatsky
2013-10-22 8:16 Sergey Senozhatsky
2013-10-21 17:21 Yates, Alexandra
2013-10-19 7:00 Sergey Senozhatsky
2013-10-19 5:17 Daniel Kahn Gillmor
2013-10-18 22:33 Yates, Alexandra
2013-10-18 18:09 Kristen Carlson Accardi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.