From: sebastian@breakpoint.cc (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status
Date: Mon, 4 Nov 2013 13:51:53 +0100 [thread overview]
Message-ID: <20131104125152.GA27260@breakpoint.cc> (raw)
In-Reply-To: <20131030130325.GA18788@intel.com>
On 30.10.13, Vinod Koul wrote:
> I fixed up the error with below, can you pls verify. Pls note this is compile
> tested only!
I tested this and my mmc driver using edma via drivers/dma seems to
work.
Tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
However you missed one piece:
CC [M] sound/soc/davinci/davinci-pcm.o
sound/soc/davinci/davinci-pcm.c: In function ?davinci_pcm_dma_irq?:
sound/soc/davinci/davinci-pcm.c:241: error: ?DMA_COMPLETE? undeclared (first use in this function)
sound/soc/davinci/davinci-pcm.c:241: error: (Each undeclared identifier is reported only once
sound/soc/davinci/davinci-pcm.c:241: error: for each function it appears in.)
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
sound/soc/davinci/davinci-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/davinci/davinci-pcm.c b/sound/soc/davinci/davinci-pcm.c
index 8460edc..e68ba31 100644
--- a/sound/soc/davinci/davinci-pcm.c
+++ b/sound/soc/davinci/davinci-pcm.c
@@ -238,7 +238,7 @@ static void davinci_pcm_dma_irq(unsigned link, u16 ch_status, void *data)
print_buf_info(prtd->ram_channel, "i ram_channel");
pr_debug("davinci_pcm: link=%d, status=0x%x\n", link, ch_status);
- if (unlikely(ch_status != DMA_COMPLETE))
+ if (unlikely(ch_status != EDMA_DMA_COMPLETE))
return;
if (snd_pcm_running(substream)) {
--
1.8.4.rc3
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Olof Johansson <olof@lixom.net>, Joel Fernandes <joelf@ti.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Dan Williams <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Sekhar Nori <nsekhar@ti.com>,
Matt Porter <matt.porter@linaro.org>
Subject: Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status
Date: Mon, 4 Nov 2013 13:51:53 +0100 [thread overview]
Message-ID: <20131104125152.GA27260@breakpoint.cc> (raw)
In-Reply-To: <20131030130325.GA18788@intel.com>
On 30.10.13, Vinod Koul wrote:
> I fixed up the error with below, can you pls verify. Pls note this is compile
> tested only!
I tested this and my mmc driver using edma via drivers/dma seems to
work.
Tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
However you missed one piece:
CC [M] sound/soc/davinci/davinci-pcm.o
sound/soc/davinci/davinci-pcm.c: In function ‘davinci_pcm_dma_irq’:
sound/soc/davinci/davinci-pcm.c:241: error: ‘DMA_COMPLETE’ undeclared (first use in this function)
sound/soc/davinci/davinci-pcm.c:241: error: (Each undeclared identifier is reported only once
sound/soc/davinci/davinci-pcm.c:241: error: for each function it appears in.)
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
sound/soc/davinci/davinci-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/davinci/davinci-pcm.c b/sound/soc/davinci/davinci-pcm.c
index 8460edc..e68ba31 100644
--- a/sound/soc/davinci/davinci-pcm.c
+++ b/sound/soc/davinci/davinci-pcm.c
@@ -238,7 +238,7 @@ static void davinci_pcm_dma_irq(unsigned link, u16 ch_status, void *data)
print_buf_info(prtd->ram_channel, "i ram_channel");
pr_debug("davinci_pcm: link=%d, status=0x%x\n", link, ch_status);
- if (unlikely(ch_status != DMA_COMPLETE))
+ if (unlikely(ch_status != EDMA_DMA_COMPLETE))
return;
if (snd_pcm_running(substream)) {
--
1.8.4.rc3
Sebastian
next prev parent reply other threads:[~2013-11-04 12:51 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 16:28 [PATCH 00/28]: dmaengine: use DMA_COMPLETE for dma completion status Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 01/28] " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 18:29 ` Guennadi Liakhovetski
2013-10-16 18:29 ` Guennadi Liakhovetski
2013-10-16 18:45 ` Dan Williams
2013-10-16 18:45 ` Dan Williams
2013-10-17 2:07 ` Vinod Koul
2013-10-17 2:07 ` Vinod Koul
2013-10-17 8:27 ` Guennadi Liakhovetski
2013-10-17 8:27 ` Guennadi Liakhovetski
2013-10-17 9:53 ` Vinod Koul
2013-10-17 9:53 ` Vinod Koul
2013-10-17 14:27 ` Sebastian Andrzej Siewior
2013-10-17 14:27 ` Sebastian Andrzej Siewior
2013-10-17 13:48 ` Vinod Koul
2013-10-17 13:48 ` Vinod Koul
2013-10-24 21:28 ` Guennadi Liakhovetski
2013-10-24 21:28 ` Guennadi Liakhovetski
2013-10-25 4:23 ` Vinod Koul
2013-10-25 4:23 ` Vinod Koul
2013-10-25 6:32 ` Guennadi Liakhovetski
2013-10-25 6:32 ` Guennadi Liakhovetski
2013-10-25 5:43 ` Vinod Koul
2013-10-25 5:43 ` Vinod Koul
2013-10-25 6:43 ` Guennadi Liakhovetski
2013-10-25 6:43 ` Guennadi Liakhovetski
2013-10-29 16:47 ` Olof Johansson
2013-10-29 16:47 ` Olof Johansson
2013-10-30 13:03 ` Vinod Koul
2013-10-30 13:03 ` Vinod Koul
2013-11-04 12:51 ` Sebastian Andrzej Siewior [this message]
2013-11-04 12:51 ` Sebastian Andrzej Siewior
2013-11-11 19:13 ` Olof Johansson
2013-11-11 19:13 ` Olof Johansson
2013-11-12 4:00 ` Vinod Koul
2013-11-12 4:00 ` Vinod Koul
2013-11-12 5:11 ` Olof Johansson
2013-11-12 5:11 ` Olof Johansson
2013-11-12 4:47 ` Vinod Koul
2013-11-12 4:47 ` Vinod Koul
2013-10-17 14:39 ` Guennadi Liakhovetski
2013-10-17 14:39 ` Guennadi Liakhovetski
2013-10-16 16:28 ` [PATCH 02/28] dmaengine: amba-pl08x: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 03/28] dmaengine: at_hdma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-17 8:08 ` Nicolas Ferre
2013-10-17 8:08 ` Nicolas Ferre
2013-10-16 16:28 ` [PATCH 04/28] dmaengine: coh901318: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 05/28] dmaengine: cppi41: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 06/28] dmaengine: jz4740: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 07/28] dmaengine: dmatest: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 08/28] dmaengine: dw: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-17 13:43 ` Andy Shevchenko
2013-10-17 13:43 ` Andy Shevchenko
2013-10-21 7:33 ` Viresh Kumar
2013-10-21 7:33 ` Viresh Kumar
2013-10-16 16:28 ` [PATCH 09/28] dmaengine: edma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-17 0:31 ` Joel Fernandes
2013-10-17 0:31 ` Joel Fernandes
2013-10-16 16:28 ` [PATCH 10/28] dmaengine: imx-dma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 11/28] dmaengine: imx-sdma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 12/28] dmaengine: intel_mid_dma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 13/28] dmaengine: ioat: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 14/28] dmaengine: iop: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 15/28] dmaengine: k3dma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-17 14:18 ` zhangfei gao
2013-10-17 14:18 ` zhangfei gao
2013-10-16 16:28 ` [PATCH 16/28] dmaengine: mmp_tdma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-17 14:19 ` zhangfei gao
2013-10-17 14:19 ` zhangfei gao
2013-10-16 16:28 ` [PATCH 17/28] dmaengine: mv_xor: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 18/28] dmaengine: mxs-dma: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 19/28] dmaengine: omap: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 20/28] dmaengine: ppc4xx: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 21/28] dmaengine: sa11x0: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 22/28] dmaengine: sh: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 23/28] dmaengine: ste: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 24/28] dmaengine: tegra: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 25/28] dmaengine: txx9: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 26/28] async_tx: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 16:28 ` [PATCH 27/28] serial: sh: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-16 20:17 ` Greg Kroah-Hartman
2013-10-16 20:17 ` Greg Kroah-Hartman
2013-10-16 16:28 ` [PATCH 28/28] net: " Vinod Koul
2013-10-16 16:28 ` Vinod Koul
2013-10-17 2:16 ` [PATCH 29/29] dmaengine: remove unused DMA_SUCCESS Vinod Koul
2013-10-17 2:16 ` Vinod Koul
2013-10-17 4:55 ` [PATCH 28/28] net: use DMA_COMPLETE for dma completion status David Miller
2013-10-17 4:55 ` David Miller
2013-10-17 9:00 ` [PATCH 00/28]: dmaengine: " Linus Walleij
2013-10-17 9:00 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104125152.GA27260@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.