Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem

[Denys Dmytriyenko <denys@ti.com>]

On Sat, Nov 02, 2013 at 12:35:18PM +0530, Siddharth Heroor wrote:
> On 10/31/2013 7:11 PM, Maupin, Chase wrote:
> >>-----Original Message-----
> >>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >>bounces@arago-project.org] On Behalf Of Heroor, Siddharth
> >>Sent: Wednesday, October 30, 2013 11:19 PM
> >>To: meta-arago@arago-project.org
> >>Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-
> >>cmem
> >>
> >>On 10/31/2013 12:37 AM, Sam Nelson wrote:
> >>>- Recipes for ti-cmem which provides user space api for
> >>contigous memory allocaion
> >>>- ti-cmem_mod provides the kernel module
> >>>- ti-mem provides the user space library
> >>Why do we need to create a new recipe? The ti-linuxutils in meta-
> >>ti
> >>should be the provider for cmem. Shouldn't that be updated for
> >>newer
> >>versions?
> >>Also, I would suggest that we make it machine compatible with
> >>omap-a15.

> >I don't know that linuxutils is really the right solution.  I think it 
> >mainly comes down to where/how is cmem being released.  So really the 
> >question is whether the SRC_URI used below is the official cmem release 
> >point or is the SRC_URI from linuxutils right?  We do not need multiple 
> >versions of cmem where everyone has their own fork of the cmem code.
> >
> >Another point is shouldn't this be in meta-ti for at least the cmem module?
> 
> ludev in the SRC_URI stands for linuxutils dev.  The SRC_URI in the
> linuxutils is a tarball release. One option is for us to drop the
> tarball release from SRC_URI and use the git tree going forward. I'm
> in favour of this primarily because that's where the development
> happens and the tree is tagged.
> 
> On meta-arago vs. meta-ti - I agree that the recipe should be in
> meta-ti. This patch should update linuxutils accordingly.

Sid,

I agree with your suggestions as long as this component is common and being 
reused by both MCSDK and GLSDK teams, as well as others.

What I don't want to happen is to unify on a single recipe and later find out 
that there are so many different requirements and nuances, that none of the 
teams can use the recipe directly and need to override and customize most of 
it to their needs...

So, essentially, what I'm looking for is a confirmation from teams (at least 
Sam and Sid/Mrinmayee, maybe others) that ipc/ludev.git is _the_ repository 
with the latest code for the cmem/linuxutils component that is being used from 
a common (master?) branch. Thank you.

-- 
Denys


> >>>Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> >>>---
> >>>   .../recipes-bsp/ti-cmem/ti-cmem-mod.bb             |   40
> >>++++++++++++++++++++
> >>>   meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb   |   20
> >>++++++++++
> >>>   meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc  |   10
> >>+++++
> >>>   3 files changed, 70 insertions(+)
> >>>   create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-
> >>cmem-mod.bb
> >>>   create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-
> >>cmem.bb
> >>>   create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-
> >>cmem.inc
> >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-
> >>mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb
> >>>new file mode 100755
> >>>index 0000000..0839c20
> >>>--- /dev/null
> >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb
> >>>@@ -0,0 +1,40 @@
> >>>+DESCRIPTION="The cmem component module for contiguous memory
> >>allocation from userspace "
> >>>+
> >>>
> >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM"
> >>>+
> >>>+LICENSE = "GPLv2"
> >>>+
> >>>+include ti-cmem.inc
> >>>+
> >>>+RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})"
> >>>+
> >>>+DEPENDS += "virtual/kernel"
> >>>+
> >>>+NAME="cmem"
> >>>+MODULE_BUILD_DIR ="src/cmem/module"
> >>>+
> >>>+# This package builds a kernel module, use kernel PR as base
> >>and append a local
> >>>+PR = "${MACHINE_KERNEL_PR}"
> >>>+PR_append = "a"
> >>>+
> >>>+PKG_${PN} = "kernel-module-${PN}"
> >>>+
> >>>+KERNEL_VERSION =
> >>"${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
> >>>+
> >>>+S = "${WORKDIR}/git"
> >>>+
> >>>+inherit module
> >>>+
> >>>+do_compile () {
> >>>+    cd ${S}
> >>>+    make -f lu.mak module_clean
> >>>+    make -f lu.mak module
> >>KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR}
> >>TOOLCHAIN_PREFIX=${CROSS_COMPILE}
> >>>+}
> >>>+
> >>>+do_install () {
> >>>+    cd ${S}
> >>>+    make -f lu.mak module_install
> >>KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}"
> >>EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra"
> >>INSTALL_MOD_PATH="${D}"
> >>>+}
> >>>+
> >>>+PACKAGE_STRIP = "no"
> >>>+
> >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb
> >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb
> >>>new file mode 100644
> >>>index 0000000..a106aa0
> >>>--- /dev/null
> >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb
> >>>@@ -0,0 +1,20 @@
> >>>+DESCRIPTION="The cmem component supports contiguous memory
> >>allocation from userspace "
> >>>+
> >>>
> >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM"
> >>>+
> >>>+LICENSE = "GPLv2"
> >>>+
> >>>+include ti-cmem.inc
> >>>+
> >>>+DEPENDS = "ti-cmem-mod"
> >>>+
> >>>+S = "${WORKDIR}/git"
> >>>+
> >>>+PR = "r1"
> >>>+
> >>>+PACKAGES =+ "${PN}-test"
> >>>+
> >>>+FILES_${PN}-test = "${bindir}/*"
> >>>+
> >>>+inherit autotools
> >>>+
> >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc
> >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc
> >>>new file mode 100644
> >>>index 0000000..9308b2d
> >>>--- /dev/null
> >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc
> >>>@@ -0,0 +1,10 @@
> >>>
> >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM"
> >>>+
> >>>+LIC_FILES_CHKSUM =
> >>"file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165b
> >>cb1a23ffd50dbb"
> >>>+
> >>>+COMPATIBLE_MACHINE = "keystone-evm"
> >>>+
> >>>+BRANCH ?= "master"
> >>>+SRCREV = "4.00.00.06"
> >>>+
> >>>+SRC_URI =
> >>"git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}"
> >>
> >>_______________________________________________
> >>meta-arago mailing list
> >>meta-arago@arago-project.org
> >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago