* [PATCH 1/1] ti-cmem: New recipes for ti-cmem
@ 2013-10-30 19:07 Sam Nelson
2013-10-30 19:23 ` Denys Dmytriyenko
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Sam Nelson @ 2013-10-30 19:07 UTC (permalink / raw)
To: meta-arago, sam.nelson
- Recipes for ti-cmem which provides user space api for contigous memory allocaion
- ti-cmem_mod provides the kernel module
- ti-mem provides the user space library
Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
.../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 ++++++++++++++++++++
meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++
meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++
3 files changed, 70 insertions(+)
create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb
create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb
create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc
diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb
new file mode 100755
index 0000000..0839c20
--- /dev/null
+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb
@@ -0,0 +1,40 @@
+DESCRIPTION="The cmem component module for contiguous memory allocation from userspace "
+
+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM"
+
+LICENSE = "GPLv2"
+
+include ti-cmem.inc
+
+RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})"
+
+DEPENDS += "virtual/kernel"
+
+NAME="cmem"
+MODULE_BUILD_DIR ="src/cmem/module"
+
+# This package builds a kernel module, use kernel PR as base and append a local
+PR = "${MACHINE_KERNEL_PR}"
+PR_append = "a"
+
+PKG_${PN} = "kernel-module-${PN}"
+
+KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
+
+S = "${WORKDIR}/git"
+
+inherit module
+
+do_compile () {
+ cd ${S}
+ make -f lu.mak module_clean
+ make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE}
+}
+
+do_install () {
+ cd ${S}
+ make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
+}
+
+PACKAGE_STRIP = "no"
+
diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb
new file mode 100644
index 0000000..a106aa0
--- /dev/null
+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb
@@ -0,0 +1,20 @@
+DESCRIPTION="The cmem component supports contiguous memory allocation from userspace "
+
+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM"
+
+LICENSE = "GPLv2"
+
+include ti-cmem.inc
+
+DEPENDS = "ti-cmem-mod"
+
+S = "${WORKDIR}/git"
+
+PR = "r1"
+
+PACKAGES =+ "${PN}-test"
+
+FILES_${PN}-test = "${bindir}/*"
+
+inherit autotools
+
diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc
new file mode 100644
index 0000000..9308b2d
--- /dev/null
+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc
@@ -0,0 +1,10 @@
+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM"
+
+LIC_FILES_CHKSUM = "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a23ffd50dbb"
+
+COMPATIBLE_MACHINE = "keystone-evm"
+
+BRANCH ?= "master"
+SRCREV = "4.00.00.06"
+
+SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-30 19:07 [PATCH 1/1] ti-cmem: New recipes for ti-cmem Sam Nelson @ 2013-10-30 19:23 ` Denys Dmytriyenko 2013-10-30 22:22 ` Nelson, Sam 2013-10-30 19:24 ` Cooper Jr., Franklin 2013-10-31 4:18 ` Siddharth Heroor 2 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2013-10-30 19:23 UTC (permalink / raw) To: Sam Nelson; +Cc: meta-arago Sam, First, thanks for the submission! Second, please drop "ti-" prefix from the recipes - it's redundant. Plus, everywhere else it is called just "cmem": > "The cmem component module for contiguous memory allocation from userspace " > "The cmem component supports contiguous memory allocation from userspace " > "http://processors.wiki.ti.com/index.php/Category:CMEM" For the rest of the comments, please see inline. But mostly everything looks fine, just a few minor questions/concerns. On Wed, Oct 30, 2013 at 03:07:35PM -0400, Sam Nelson wrote: > - Recipes for ti-cmem which provides user space api for contigous memory allocaion > - ti-cmem_mod provides the kernel module > - ti-mem provides the user space library > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 ++++++++++++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++ > 3 files changed, 70 insertions(+) > create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > new file mode 100755 > index 0000000..0839c20 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > @@ -0,0 +1,40 @@ > +DESCRIPTION="The cmem component module for contiguous memory allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" You duplicate HOMEPAGE in all recipes and .inc file... > +LICENSE = "GPLv2" Can you move LICENSE field in the .inc file, since you already have LIC_FILES_CHKSUM there... > +include ti-cmem.inc > + > +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" Is it really tied to a specific kernel version? What if it's slightly different, i.e. with a minor update? Would using ">=" be better here? > +DEPENDS += "virtual/kernel" module.bbclass already does it for you. > +NAME="cmem" > +MODULE_BUILD_DIR ="src/cmem/module" > + > +# This package builds a kernel module, use kernel PR as base and append a local > +PR = "${MACHINE_KERNEL_PR}" > +PR_append = "a" > + > +PKG_${PN} = "kernel-module-${PN}" > + > +KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" This one is also defined by module.bbclass > +S = "${WORKDIR}/git" > + > +inherit module > + > +do_compile () { > + cd ${S} > + make -f lu.mak module_clean > + make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE} > +} > + > +do_install () { > + cd ${S} > + make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}" > +} > + > +PACKAGE_STRIP = "no" Why this? > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > new file mode 100644 > index 0000000..a106aa0 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > @@ -0,0 +1,20 @@ > +DESCRIPTION="The cmem component supports contiguous memory allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" > + > +include ti-cmem.inc > + > +DEPENDS = "ti-cmem-mod" Do you mean RDEPENDS here? I don't think you have a build-time dependency here... > +S = "${WORKDIR}/git" > + > +PR = "r1" > + > +PACKAGES =+ "${PN}-test" > + > +FILES_${PN}-test = "${bindir}/*" So, all the binaries will go into cmem-test, what would remain in the main cmem package? > +inherit autotools > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > new file mode 100644 > index 0000000..9308b2d > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > @@ -0,0 +1,10 @@ > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LIC_FILES_CHKSUM = "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a23ffd50dbb" I haven't checked yet, but is the Makefile the only and proper place to define licenses for the component? > +COMPATIBLE_MACHINE = "keystone-evm" > + > +BRANCH ?= "master" > +SRCREV = "4.00.00.06" Any chance you can use a commit ID here? > +SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-30 19:23 ` Denys Dmytriyenko @ 2013-10-30 22:22 ` Nelson, Sam 2013-10-30 23:37 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Nelson, Sam @ 2013-10-30 22:22 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org Thanks Denys for the detailed feedback. See comments inline. -----Original Message----- From: Dmytriyenko, Denys Sent: Wednesday, October 30, 2013 3:24 PM To: Nelson, Sam Cc: meta-arago@arago-project.org Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-cmem Sam, First, thanks for the submission! Second, please drop "ti-" prefix from the recipes - it's redundant. Plus, everywhere else it is called just "cmem": [Sam] Ok. I will fix this. > "The cmem component module for contiguous memory allocation from userspace " > "The cmem component supports contiguous memory allocation from userspace " > "http://processors.wiki.ti.com/index.php/Category:CMEM" For the rest of the comments, please see inline. But mostly everything looks fine, just a few minor questions/concerns. On Wed, Oct 30, 2013 at 03:07:35PM -0400, Sam Nelson wrote: > - Recipes for ti-cmem which provides user space api for contigous memory allocaion > - ti-cmem_mod provides the kernel module > - ti-mem provides the user space library > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 ++++++++++++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++ > 3 files changed, 70 insertions(+) > create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > new file mode 100755 > index 0000000..0839c20 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > @@ -0,0 +1,40 @@ > +DESCRIPTION="The cmem component module for contiguous memory allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" You duplicate HOMEPAGE in all recipes and .inc file... [Sam] I will fix this. > +LICENSE = "GPLv2" Can you move LICENSE field in the .inc file, since you already have LIC_FILES_CHKSUM there... [Sam] Ok. I will fix this. > +include ti-cmem.inc > + > +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" Is it really tied to a specific kernel version? What if it's slightly different, i.e. with a minor update? Would using ">=" be better here? [Sam] I am not clear on this. I thought the kernel module is compiled for the particular version of kernel and may not work with a different version of kernel. Appreciate any explanation on this. > +DEPENDS += "virtual/kernel" module.bbclass already does it for you. [Sam] I guess I will remove this? > +NAME="cmem" > +MODULE_BUILD_DIR ="src/cmem/module" > + > +# This package builds a kernel module, use kernel PR as base and append a local > +PR = "${MACHINE_KERNEL_PR}" > +PR_append = "a" > + > +PKG_${PN} = "kernel-module-${PN}" > + > +KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" This one is also defined by module.bbclass [Sam] I will remove this as well. > +S = "${WORKDIR}/git" > + > +inherit module > + > +do_compile () { > + cd ${S} > + make -f lu.mak module_clean > + make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE} > +} > + > +do_install () { > + cd ${S} > + make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}" > +} > + > +PACKAGE_STRIP = "no" Why this? [Sam] Not sure may be there was some issue earlier. Looks like I can remove this. > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > new file mode 100644 > index 0000000..a106aa0 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > @@ -0,0 +1,20 @@ > +DESCRIPTION="The cmem component supports contiguous memory allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" > + > +include ti-cmem.inc > + > +DEPENDS = "ti-cmem-mod" Do you mean RDEPENDS here? I don't think you have a build-time dependency here... [Sam] RDEPENDS makes sense. I will fix this. > +S = "${WORKDIR}/git" > + > +PR = "r1" > + > +PACKAGES =+ "${PN}-test" > + > +FILES_${PN}-test = "${bindir}/*" So, all the binaries will go into cmem-test, what would remain in the main cmem package? [Sam] Actually nothing remains in the cmem package itself. Is this an issue? > +inherit autotools > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > new file mode 100644 > index 0000000..9308b2d > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > @@ -0,0 +1,10 @@ > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LIC_FILES_CHKSUM = "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a23ffd50dbb" I haven't checked yet, but is the Makefile the only and proper place to define licenses for the component? [Sam] It was used as the file was in the root directory. Do you prefer using the API header file instead? > +COMPATIBLE_MACHINE = "keystone-evm" > + > +BRANCH ?= "master" > +SRCREV = "4.00.00.06" Any chance you can use a commit ID here? [Sam] I can switch to commit ID. > +SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-30 22:22 ` Nelson, Sam @ 2013-10-30 23:37 ` Denys Dmytriyenko 2013-10-31 2:59 ` Nelson, Sam 0 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2013-10-30 23:37 UTC (permalink / raw) To: Nelson, Sam; +Cc: meta-arago@arago-project.org On Wed, Oct 30, 2013 at 06:22:34PM -0400, Nelson, Sam wrote: > Thanks Denys for the detailed feedback. See comments inline. > > First, thanks for the submission! > > Second, please drop "ti-" prefix from the recipes - it's redundant. Plus, > everywhere else it is called just "cmem": > [Sam] Ok. I will fix this. Thanks! And if you need any support or backing for this change, please let me know - I had a past agreement on this topic with Bill and Jack... > For the rest of the comments, please see inline. But mostly everything looks > fine, just a few minor questions/concerns. > > On Wed, Oct 30, 2013 at 03:07:35PM -0400, Sam Nelson wrote: > > - Recipes for ti-cmem which provides user space api for contigous memory allocaion > > - ti-cmem_mod provides the kernel module > > - ti-mem provides the user space library > > > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > > --- > > .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 ++++++++++++++++++++ > > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++ > > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++ > > 3 files changed, 70 insertions(+) > > create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > new file mode 100755 > > index 0000000..0839c20 > > --- /dev/null > > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > @@ -0,0 +1,40 @@ > > +DESCRIPTION="The cmem component module for contiguous memory allocation from userspace " > > + > > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > You duplicate HOMEPAGE in all recipes and .inc file... > > [Sam] I will fix this. > > > +LICENSE = "GPLv2" > > Can you move LICENSE field in the .inc file, since you already have > LIC_FILES_CHKSUM there... > [Sam] Ok. I will fix this. > > > +include ti-cmem.inc > > + > > +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" > > Is it really tied to a specific kernel version? What if it's slightly > different, i.e. with a minor update? Would using ">=" be better here? > [Sam] I am not clear on this. I thought the kernel module is compiled for > the particular version of kernel and may not work with a different version > of kernel. Appreciate any explanation on this. Ah, if that's the only reason, then you don't need to do anything - module.bbclass will do it for you. > > +DEPENDS += "virtual/kernel" > > module.bbclass already does it for you. > [Sam] I guess I will remove this? Yes, please. > > +NAME="cmem" > > +MODULE_BUILD_DIR ="src/cmem/module" > > + > > +# This package builds a kernel module, use kernel PR as base and append a local > > +PR = "${MACHINE_KERNEL_PR}" > > +PR_append = "a" > > + > > +PKG_${PN} = "kernel-module-${PN}" > > + > > +KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" > > This one is also defined by module.bbclass > [Sam] I will remove this as well. > > > +S = "${WORKDIR}/git" > > + > > +inherit module > > + > > +do_compile () { > > + cd ${S} > > + make -f lu.mak module_clean > > + make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE} > > +} > > + > > +do_install () { > > + cd ${S} > > + make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}" > > +} > > + > > +PACKAGE_STRIP = "no" > > Why this? > > [Sam] Not sure may be there was some issue earlier. Looks like I can remove > this. > > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > new file mode 100644 > > index 0000000..a106aa0 > > --- /dev/null > > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > @@ -0,0 +1,20 @@ > > +DESCRIPTION="The cmem component supports contiguous memory allocation from userspace " > > + > > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > + > > +LICENSE = "GPLv2" > > + > > +include ti-cmem.inc > > + > > +DEPENDS = "ti-cmem-mod" > > Do you mean RDEPENDS here? I don't think you have a build-time dependency > here... > [Sam] RDEPENDS makes sense. I will fix this. > > > > +S = "${WORKDIR}/git" > > + > > +PR = "r1" > > + > > +PACKAGES =+ "${PN}-test" > > + > > +FILES_${PN}-test = "${bindir}/*" > > So, all the binaries will go into cmem-test, what would remain in the main > cmem package? > [Sam] Actually nothing remains in the cmem package itself. Is this an issue? Not an issue, but then why not call the recipe cmem-test if that's its only purpose? > > +inherit autotools > > + > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > new file mode 100644 > > index 0000000..9308b2d > > --- /dev/null > > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > @@ -0,0 +1,10 @@ > > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > + > > +LIC_FILES_CHKSUM = "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a23ffd50dbb" > > I haven't checked yet, but is the Makefile the only and proper place to define > licenses for the component? > [Sam] It was used as the file was in the root directory. Do you prefer using > the API header file instead? It doesn't need to be in the root directory, but it does need to specify the license that is being used. > > +COMPATIBLE_MACHINE = "keystone-evm" > > + > > +BRANCH ?= "master" > > +SRCREV = "4.00.00.06" > > Any chance you can use a commit ID here? > [Sam] I can switch to commit ID. Thanks. The reason for this request is to reduce the number of network connections required during parsing. > > +SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > > -- > > 1.7.9.5 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-30 23:37 ` Denys Dmytriyenko @ 2013-10-31 2:59 ` Nelson, Sam 0 siblings, 0 replies; 13+ messages in thread From: Nelson, Sam @ 2013-10-31 2:59 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org See comments inline. -----Original Message----- From: Dmytriyenko, Denys Sent: Wednesday, October 30, 2013 7:38 PM To: Nelson, Sam Cc: meta-arago@arago-project.org Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-cmem On Wed, Oct 30, 2013 at 06:22:34PM -0400, Nelson, Sam wrote: > Thanks Denys for the detailed feedback. See comments inline. > > First, thanks for the submission! > > Second, please drop "ti-" prefix from the recipes - it's redundant. > Plus, everywhere else it is called just "cmem": > [Sam] Ok. I will fix this. Thanks! And if you need any support or backing for this change, please let me know - I had a past agreement on this topic with Bill and Jack... > For the rest of the comments, please see inline. But mostly everything looks > fine, just a few minor questions/concerns. > > On Wed, Oct 30, 2013 at 03:07:35PM -0400, Sam Nelson wrote: > > - Recipes for ti-cmem which provides user space api for contigous memory allocaion > > - ti-cmem_mod provides the kernel module > > - ti-mem provides the user space library > > > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > > --- > > .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 ++++++++++++++++++++ > > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++ > > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++ > > 3 files changed, 70 insertions(+) > > create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > new file mode 100755 > > index 0000000..0839c20 > > --- /dev/null > > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > @@ -0,0 +1,40 @@ > > +DESCRIPTION="The cmem component module for contiguous memory allocation from userspace " > > + > > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > You duplicate HOMEPAGE in all recipes and .inc file... > > [Sam] I will fix this. > > > +LICENSE = "GPLv2" > > Can you move LICENSE field in the .inc file, since you already have > LIC_FILES_CHKSUM there... > [Sam] Ok. I will fix this. > > > +include ti-cmem.inc > > + > > +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" > > Is it really tied to a specific kernel version? What if it's slightly > different, i.e. with a minor update? Would using ">=" be better here? > [Sam] I am not clear on this. I thought the kernel module is compiled for > the particular version of kernel and may not work with a different version > of kernel. Appreciate any explanation on this. Ah, if that's the only reason, then you don't need to do anything - module.bbclass will do it for you. [Sam] Ok. I will remove this as well. > > +DEPENDS += "virtual/kernel" > > module.bbclass already does it for you. > [Sam] I guess I will remove this? Yes, please. > > +NAME="cmem" > > +MODULE_BUILD_DIR ="src/cmem/module" > > + > > +# This package builds a kernel module, use kernel PR as base and append a local > > +PR = "${MACHINE_KERNEL_PR}" > > +PR_append = "a" > > + > > +PKG_${PN} = "kernel-module-${PN}" > > + > > +KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" > > This one is also defined by module.bbclass > [Sam] I will remove this as well. > > > +S = "${WORKDIR}/git" > > + > > +inherit module > > + > > +do_compile () { > > + cd ${S} > > + make -f lu.mak module_clean > > + make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE} > > +} > > + > > +do_install () { > > + cd ${S} > > + make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}" > > +} > > + > > +PACKAGE_STRIP = "no" > > Why this? > > [Sam] Not sure may be there was some issue earlier. Looks like I can remove > this. > > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > new file mode 100644 > > index 0000000..a106aa0 > > --- /dev/null > > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > @@ -0,0 +1,20 @@ > > +DESCRIPTION="The cmem component supports contiguous memory allocation from userspace " > > + > > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > + > > +LICENSE = "GPLv2" > > + > > +include ti-cmem.inc > > + > > +DEPENDS = "ti-cmem-mod" > > Do you mean RDEPENDS here? I don't think you have a build-time dependency > here... > [Sam] RDEPENDS makes sense. I will fix this. > > > > +S = "${WORKDIR}/git" > > + > > +PR = "r1" > > + > > +PACKAGES =+ "${PN}-test" > > + > > +FILES_${PN}-test = "${bindir}/*" > > So, all the binaries will go into cmem-test, what would remain in the main > cmem package? > [Sam] Actually nothing remains in the cmem package itself. Is this an issue? Not an issue, but then why not call the recipe cmem-test if that's its only purpose? [Sam] The main contents are in cmem-dev, cmem-staticdev. > > +inherit autotools > > + > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > new file mode 100644 > > index 0000000..9308b2d > > --- /dev/null > > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > @@ -0,0 +1,10 @@ > > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > + > > +LIC_FILES_CHKSUM = "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a23ffd50dbb" > > I haven't checked yet, but is the Makefile the only and proper place to define > licenses for the component? > [Sam] It was used as the file was in the root directory. Do you prefer using > the API header file instead? It doesn't need to be in the root directory, but it does need to specify the license that is being used. [Sam] products.mak does have the license used. I will try to switch to a API header file . > > +COMPATIBLE_MACHINE = "keystone-evm" > > + > > +BRANCH ?= "master" > > +SRCREV = "4.00.00.06" > > Any chance you can use a commit ID here? > [Sam] I can switch to commit ID. Thanks. The reason for this request is to reduce the number of network connections required during parsing. > > +SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > > -- > > 1.7.9.5 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-30 19:07 [PATCH 1/1] ti-cmem: New recipes for ti-cmem Sam Nelson 2013-10-30 19:23 ` Denys Dmytriyenko @ 2013-10-30 19:24 ` Cooper Jr., Franklin 2013-10-31 3:02 ` Nelson, Sam 2013-10-31 4:18 ` Siddharth Heroor 2 siblings, 1 reply; 13+ messages in thread From: Cooper Jr., Franklin @ 2013-10-30 19:24 UTC (permalink / raw) To: Nelson, Sam, meta-arago@arago-project.org > -----Original Message----- > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > bounces@arago-project.org] On Behalf Of Nelson, Sam > Sent: Wednesday, October 30, 2013 2:08 PM > To: meta-arago@arago-project.org; Nelson, Sam > Subject: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-cmem > > - Recipes for ti-cmem which provides user space api for contigous memory > allocaion > - ti-cmem_mod provides the kernel module > - ti-mem provides the user space library > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 > ++++++++++++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++ > 3 files changed, 70 insertions(+) > create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc [Franklin] Your recipes are missing the software/library version number. Ex ti-cmem-mod_1.0.bb or ti-cmem-mod_git.bb (you would still have to set the PV for a specific version) > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb b/meta- > arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > new file mode 100755 > index 0000000..0839c20 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > @@ -0,0 +1,40 @@ > +DESCRIPTION="The cmem component module for contiguous memory > allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" [Franklin] ^ I would leave it up to you but you probably could put the HOMEPAGE and LICENSE in the include file and don't bother having to set it again in the two recipes. > + > +include ti-cmem.inc > + > +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" [Franklin] I'm not sure if this is possible. I vaguely remember trying to do something like this before and found out it was impossible to try to RDEPENDS on a specific version of a recipe. You probably would just need to make sure PREFERRED_VERSION is set. > + > +DEPENDS += "virtual/kernel" [Franklin] inherit module already sets this for you. No need to set it again > + > +NAME="cmem" > +MODULE_BUILD_DIR ="src/cmem/module" [Franklin] I might be missing something but what are the above variables being used for? I don't see it being referenced. > + > +# This package builds a kernel module, use kernel PR as base and append > +a local PR = "${MACHINE_KERNEL_PR}" > +PR_append = "a" > + > +PKG_${PN} = "kernel-module-${PN}" > + > +KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel- > abiversion')}" > + > +S = "${WORKDIR}/git" > + > +inherit module > + > +do_compile () { > + cd ${S} > + make -f lu.mak module_clean > + make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} > +TOOLCHAIN_PREFIX=${CROSS_COMPILE} } > + > +do_install () { > + cd ${S} > + make -f lu.mak module_install > KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" > EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" > INSTALL_MOD_PATH="${D}" > +} > + > +PACKAGE_STRIP = "no" > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb b/meta-arago- > extras/recipes-bsp/ti-cmem/ti-cmem.bb > new file mode 100644 > index 0000000..a106aa0 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > @@ -0,0 +1,20 @@ > +DESCRIPTION="The cmem component supports contiguous memory allocation > from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" > + > +include ti-cmem.inc > + > +DEPENDS = "ti-cmem-mod" > + > +S = "${WORKDIR}/git" > + > +PR = "r1" [Franklin] New recipes should start are 0 > + > +PACKAGES =+ "${PN}-test" > + > +FILES_${PN}-test = "${bindir}/*" > + > +inherit autotools > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc b/meta-arago- > extras/recipes-bsp/ti-cmem/ti-cmem.inc > new file mode 100644 > index 0000000..9308b2d > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > @@ -0,0 +1,10 @@ > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LIC_FILES_CHKSUM = > "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a2 > 3ffd50dbb" > + > +COMPATIBLE_MACHINE = "keystone-evm" > + > +BRANCH ?= "master" > +SRCREV = "4.00.00.06" > + > +SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-30 19:24 ` Cooper Jr., Franklin @ 2013-10-31 3:02 ` Nelson, Sam 0 siblings, 0 replies; 13+ messages in thread From: Nelson, Sam @ 2013-10-31 3:02 UTC (permalink / raw) To: Cooper Jr., Franklin, meta-arago@arago-project.org Thanks Franklin for your feedback as well. See my comments inline on what is not already covered by Denys. -----Original Message----- From: Cooper Jr., Franklin Sent: Wednesday, October 30, 2013 3:25 PM To: Nelson, Sam; meta-arago@arago-project.org Subject: RE: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-cmem > -----Original Message----- > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > bounces@arago-project.org] On Behalf Of Nelson, Sam > Sent: Wednesday, October 30, 2013 2:08 PM > To: meta-arago@arago-project.org; Nelson, Sam > Subject: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-cmem > > - Recipes for ti-cmem which provides user space api for contigous > memory allocaion > - ti-cmem_mod provides the kernel module > - ti-mem provides the user space library > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 > ++++++++++++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++ > 3 files changed, 70 insertions(+) > create mode 100755 > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc [Franklin] Your recipes are missing the software/library version number. Ex ti-cmem-mod_1.0.bb or ti-cmem-mod_git.bb (you would still have to set the PV for a specific version) [Sam] I will add the cmem-mod_git.bb and cmem_git.bb. > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > b/meta- arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > new file mode 100755 > index 0000000..0839c20 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > @@ -0,0 +1,40 @@ > +DESCRIPTION="The cmem component module for contiguous memory > allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" [Franklin] ^ I would leave it up to you but you probably could put the HOMEPAGE and LICENSE in the include file and don't bother having to set it again in the two recipes. > + > +include ti-cmem.inc > + > +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" [Franklin] I'm not sure if this is possible. I vaguely remember trying to do something like this before and found out it was impossible to try to RDEPENDS on a specific version of a recipe. You probably would just need to make sure PREFERRED_VERSION is set. > + > +DEPENDS += "virtual/kernel" [Franklin] inherit module already sets this for you. No need to set it again > + > +NAME="cmem" > +MODULE_BUILD_DIR ="src/cmem/module" [Franklin] I might be missing something but what are the above variables being used for? I don't see it being referenced. [Sam] I will remove this. > + > +# This package builds a kernel module, use kernel PR as base and > +append a local PR = "${MACHINE_KERNEL_PR}" > +PR_append = "a" > + > +PKG_${PN} = "kernel-module-${PN}" > + > +KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel- > abiversion')}" > + > +S = "${WORKDIR}/git" > + > +inherit module > + > +do_compile () { > + cd ${S} > + make -f lu.mak module_clean > + make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} > +TOOLCHAIN_PREFIX=${CROSS_COMPILE} } > + > +do_install () { > + cd ${S} > + make -f lu.mak module_install > KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" > EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" > INSTALL_MOD_PATH="${D}" > +} > + > +PACKAGE_STRIP = "no" > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > b/meta-arago- extras/recipes-bsp/ti-cmem/ti-cmem.bb > new file mode 100644 > index 0000000..a106aa0 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > @@ -0,0 +1,20 @@ > +DESCRIPTION="The cmem component supports contiguous memory allocation > from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" > + > +include ti-cmem.inc > + > +DEPENDS = "ti-cmem-mod" > + > +S = "${WORKDIR}/git" > + > +PR = "r1" [Franklin] New recipes should start are 0 > + > +PACKAGES =+ "${PN}-test" > + > +FILES_${PN}-test = "${bindir}/*" > + > +inherit autotools > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > b/meta-arago- extras/recipes-bsp/ti-cmem/ti-cmem.inc > new file mode 100644 > index 0000000..9308b2d > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > @@ -0,0 +1,10 @@ > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LIC_FILES_CHKSUM = > "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a > 2 > 3ffd50dbb" > + > +COMPATIBLE_MACHINE = "keystone-evm" > + > +BRANCH ?= "master" > +SRCREV = "4.00.00.06" > + > +SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-30 19:07 [PATCH 1/1] ti-cmem: New recipes for ti-cmem Sam Nelson 2013-10-30 19:23 ` Denys Dmytriyenko 2013-10-30 19:24 ` Cooper Jr., Franklin @ 2013-10-31 4:18 ` Siddharth Heroor 2013-10-31 13:41 ` Maupin, Chase 2 siblings, 1 reply; 13+ messages in thread From: Siddharth Heroor @ 2013-10-31 4:18 UTC (permalink / raw) To: meta-arago On 10/31/2013 12:37 AM, Sam Nelson wrote: > - Recipes for ti-cmem which provides user space api for contigous memory allocaion > - ti-cmem_mod provides the kernel module > - ti-mem provides the user space library Why do we need to create a new recipe? The ti-linuxutils in meta-ti should be the provider for cmem. Shouldn't that be updated for newer versions? Also, I would suggest that we make it machine compatible with omap-a15. > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 ++++++++++++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 ++++++++++ > meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 +++++ > 3 files changed, 70 insertions(+) > create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > new file mode 100755 > index 0000000..0839c20 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > @@ -0,0 +1,40 @@ > +DESCRIPTION="The cmem component module for contiguous memory allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" > + > +include ti-cmem.inc > + > +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" > + > +DEPENDS += "virtual/kernel" > + > +NAME="cmem" > +MODULE_BUILD_DIR ="src/cmem/module" > + > +# This package builds a kernel module, use kernel PR as base and append a local > +PR = "${MACHINE_KERNEL_PR}" > +PR_append = "a" > + > +PKG_${PN} = "kernel-module-${PN}" > + > +KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" > + > +S = "${WORKDIR}/git" > + > +inherit module > + > +do_compile () { > + cd ${S} > + make -f lu.mak module_clean > + make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE} > +} > + > +do_install () { > + cd ${S} > + make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}" > +} > + > +PACKAGE_STRIP = "no" > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > new file mode 100644 > index 0000000..a106aa0 > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > @@ -0,0 +1,20 @@ > +DESCRIPTION="The cmem component supports contiguous memory allocation from userspace " > + > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LICENSE = "GPLv2" > + > +include ti-cmem.inc > + > +DEPENDS = "ti-cmem-mod" > + > +S = "${WORKDIR}/git" > + > +PR = "r1" > + > +PACKAGES =+ "${PN}-test" > + > +FILES_${PN}-test = "${bindir}/*" > + > +inherit autotools > + > diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > new file mode 100644 > index 0000000..9308b2d > --- /dev/null > +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > @@ -0,0 +1,10 @@ > +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > + > +LIC_FILES_CHKSUM = "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165bcb1a23ffd50dbb" > + > +COMPATIBLE_MACHINE = "keystone-evm" > + > +BRANCH ?= "master" > +SRCREV = "4.00.00.06" > + > +SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-31 4:18 ` Siddharth Heroor @ 2013-10-31 13:41 ` Maupin, Chase 2013-11-02 7:05 ` Siddharth Heroor 0 siblings, 1 reply; 13+ messages in thread From: Maupin, Chase @ 2013-10-31 13:41 UTC (permalink / raw) To: Heroor, Siddharth, meta-arago@arago-project.org >-----Original Message----- >From: meta-arago-bounces@arago-project.org [mailto:meta-arago- >bounces@arago-project.org] On Behalf Of Heroor, Siddharth >Sent: Wednesday, October 30, 2013 11:19 PM >To: meta-arago@arago-project.org >Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti- >cmem > >On 10/31/2013 12:37 AM, Sam Nelson wrote: >> - Recipes for ti-cmem which provides user space api for >contigous memory allocaion >> - ti-cmem_mod provides the kernel module >> - ti-mem provides the user space library > >Why do we need to create a new recipe? The ti-linuxutils in meta- >ti >should be the provider for cmem. Shouldn't that be updated for >newer >versions? >Also, I would suggest that we make it machine compatible with >omap-a15. I don't know that linuxutils is really the right solution. I think it mainly comes down to where/how is cmem being released. So really the question is whether the SRC_URI used below is the official cmem release point or is the SRC_URI from linuxutils right? We do not need multiple versions of cmem where everyone has their own fork of the cmem code. Another point is shouldn't this be in meta-ti for at least the cmem module? > >> >> Signed-off-by: Sam Nelson <sam.nelson@ti.com> >> --- >> .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 >++++++++++++++++++++ >> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 >++++++++++ >> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 >+++++ >> 3 files changed, 70 insertions(+) >> create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti- >cmem-mod.bb >> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- >cmem.bb >> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- >cmem.inc >> >> diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem- >mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb >> new file mode 100755 >> index 0000000..0839c20 >> --- /dev/null >> +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb >> @@ -0,0 +1,40 @@ >> +DESCRIPTION="The cmem component module for contiguous memory >allocation from userspace " >> + >> >+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" >> + >> +LICENSE = "GPLv2" >> + >> +include ti-cmem.inc >> + >> +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" >> + >> +DEPENDS += "virtual/kernel" >> + >> +NAME="cmem" >> +MODULE_BUILD_DIR ="src/cmem/module" >> + >> +# This package builds a kernel module, use kernel PR as base >and append a local >> +PR = "${MACHINE_KERNEL_PR}" >> +PR_append = "a" >> + >> +PKG_${PN} = "kernel-module-${PN}" >> + >> +KERNEL_VERSION = >"${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" >> + >> +S = "${WORKDIR}/git" >> + >> +inherit module >> + >> +do_compile () { >> + cd ${S} >> + make -f lu.mak module_clean >> + make -f lu.mak module >KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} >TOOLCHAIN_PREFIX=${CROSS_COMPILE} >> +} >> + >> +do_install () { >> + cd ${S} >> + make -f lu.mak module_install >KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" >EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" >INSTALL_MOD_PATH="${D}" >> +} >> + >> +PACKAGE_STRIP = "no" >> + >> diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb >b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb >> new file mode 100644 >> index 0000000..a106aa0 >> --- /dev/null >> +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb >> @@ -0,0 +1,20 @@ >> +DESCRIPTION="The cmem component supports contiguous memory >allocation from userspace " >> + >> >+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" >> + >> +LICENSE = "GPLv2" >> + >> +include ti-cmem.inc >> + >> +DEPENDS = "ti-cmem-mod" >> + >> +S = "${WORKDIR}/git" >> + >> +PR = "r1" >> + >> +PACKAGES =+ "${PN}-test" >> + >> +FILES_${PN}-test = "${bindir}/*" >> + >> +inherit autotools >> + >> diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc >b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc >> new file mode 100644 >> index 0000000..9308b2d >> --- /dev/null >> +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc >> @@ -0,0 +1,10 @@ >> >+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" >> + >> +LIC_FILES_CHKSUM = >"file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165b >cb1a23ffd50dbb" >> + >> +COMPATIBLE_MACHINE = "keystone-evm" >> + >> +BRANCH ?= "master" >> +SRCREV = "4.00.00.06" >> + >> +SRC_URI = >"git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > >_______________________________________________ >meta-arago mailing list >meta-arago@arago-project.org >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-10-31 13:41 ` Maupin, Chase @ 2013-11-02 7:05 ` Siddharth Heroor 2013-11-04 17:06 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Siddharth Heroor @ 2013-11-02 7:05 UTC (permalink / raw) To: Maupin, Chase, meta-arago@arago-project.org On 10/31/2013 7:11 PM, Maupin, Chase wrote: >> -----Original Message----- >> From: meta-arago-bounces@arago-project.org [mailto:meta-arago- >> bounces@arago-project.org] On Behalf Of Heroor, Siddharth >> Sent: Wednesday, October 30, 2013 11:19 PM >> To: meta-arago@arago-project.org >> Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti- >> cmem >> >> On 10/31/2013 12:37 AM, Sam Nelson wrote: >>> - Recipes for ti-cmem which provides user space api for >> contigous memory allocaion >>> - ti-cmem_mod provides the kernel module >>> - ti-mem provides the user space library >> Why do we need to create a new recipe? The ti-linuxutils in meta- >> ti >> should be the provider for cmem. Shouldn't that be updated for >> newer >> versions? >> Also, I would suggest that we make it machine compatible with >> omap-a15. > I don't know that linuxutils is really the right solution. I think it mainly comes down to where/how is cmem being released. So really the question is whether the SRC_URI used below is the official cmem release point or is the SRC_URI from linuxutils right? We do not need multiple versions of cmem where everyone has their own fork of the cmem code. > > Another point is shouldn't this be in meta-ti for at least the cmem module? ludev in the SRC_URI stands for linuxutils dev. The SRC_URI in the linuxutils is a tarball release. One option is for us to drop the tarball release from SRC_URI and use the git tree going forward. I'm in favour of this primarily because that's where the development happens and the tree is tagged. On meta-arago vs. meta-ti - I agree that the recipe should be in meta-ti. This patch should update linuxutils accordingly. > >>> Signed-off-by: Sam Nelson <sam.nelson@ti.com> >>> --- >>> .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 >> ++++++++++++++++++++ >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 >> ++++++++++ >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 >> +++++ >>> 3 files changed, 70 insertions(+) >>> create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti- >> cmem-mod.bb >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- >> cmem.bb >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- >> cmem.inc >>> diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem- >> mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb >>> new file mode 100755 >>> index 0000000..0839c20 >>> --- /dev/null >>> +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb >>> @@ -0,0 +1,40 @@ >>> +DESCRIPTION="The cmem component module for contiguous memory >> allocation from userspace " >>> + >>> >> +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" >>> + >>> +LICENSE = "GPLv2" >>> + >>> +include ti-cmem.inc >>> + >>> +RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" >>> + >>> +DEPENDS += "virtual/kernel" >>> + >>> +NAME="cmem" >>> +MODULE_BUILD_DIR ="src/cmem/module" >>> + >>> +# This package builds a kernel module, use kernel PR as base >> and append a local >>> +PR = "${MACHINE_KERNEL_PR}" >>> +PR_append = "a" >>> + >>> +PKG_${PN} = "kernel-module-${PN}" >>> + >>> +KERNEL_VERSION = >> "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" >>> + >>> +S = "${WORKDIR}/git" >>> + >>> +inherit module >>> + >>> +do_compile () { >>> + cd ${S} >>> + make -f lu.mak module_clean >>> + make -f lu.mak module >> KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} >> TOOLCHAIN_PREFIX=${CROSS_COMPILE} >>> +} >>> + >>> +do_install () { >>> + cd ${S} >>> + make -f lu.mak module_install >> KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" >> EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" >> INSTALL_MOD_PATH="${D}" >>> +} >>> + >>> +PACKAGE_STRIP = "no" >>> + >>> diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb >> b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb >>> new file mode 100644 >>> index 0000000..a106aa0 >>> --- /dev/null >>> +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb >>> @@ -0,0 +1,20 @@ >>> +DESCRIPTION="The cmem component supports contiguous memory >> allocation from userspace " >>> + >>> >> +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" >>> + >>> +LICENSE = "GPLv2" >>> + >>> +include ti-cmem.inc >>> + >>> +DEPENDS = "ti-cmem-mod" >>> + >>> +S = "${WORKDIR}/git" >>> + >>> +PR = "r1" >>> + >>> +PACKAGES =+ "${PN}-test" >>> + >>> +FILES_${PN}-test = "${bindir}/*" >>> + >>> +inherit autotools >>> + >>> diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc >> b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc >>> new file mode 100644 >>> index 0000000..9308b2d >>> --- /dev/null >>> +++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc >>> @@ -0,0 +1,10 @@ >>> >> +HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" >>> + >>> +LIC_FILES_CHKSUM = >> "file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165b >> cb1a23ffd50dbb" >>> + >>> +COMPATIBLE_MACHINE = "keystone-evm" >>> + >>> +BRANCH ?= "master" >>> +SRCREV = "4.00.00.06" >>> + >>> +SRC_URI = >> "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" >> >> _______________________________________________ >> meta-arago mailing list >> meta-arago@arago-project.org >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-11-02 7:05 ` Siddharth Heroor @ 2013-11-04 17:06 ` Denys Dmytriyenko 2013-11-06 15:53 ` Nelson, Sam 0 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2013-11-04 17:06 UTC (permalink / raw) To: Siddharth Heroor; +Cc: meta-arago@arago-project.org On Sat, Nov 02, 2013 at 12:35:18PM +0530, Siddharth Heroor wrote: > On 10/31/2013 7:11 PM, Maupin, Chase wrote: > >>-----Original Message----- > >>From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > >>bounces@arago-project.org] On Behalf Of Heroor, Siddharth > >>Sent: Wednesday, October 30, 2013 11:19 PM > >>To: meta-arago@arago-project.org > >>Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti- > >>cmem > >> > >>On 10/31/2013 12:37 AM, Sam Nelson wrote: > >>>- Recipes for ti-cmem which provides user space api for > >>contigous memory allocaion > >>>- ti-cmem_mod provides the kernel module > >>>- ti-mem provides the user space library > >>Why do we need to create a new recipe? The ti-linuxutils in meta- > >>ti > >>should be the provider for cmem. Shouldn't that be updated for > >>newer > >>versions? > >>Also, I would suggest that we make it machine compatible with > >>omap-a15. > >I don't know that linuxutils is really the right solution. I think it > >mainly comes down to where/how is cmem being released. So really the > >question is whether the SRC_URI used below is the official cmem release > >point or is the SRC_URI from linuxutils right? We do not need multiple > >versions of cmem where everyone has their own fork of the cmem code. > > > >Another point is shouldn't this be in meta-ti for at least the cmem module? > > ludev in the SRC_URI stands for linuxutils dev. The SRC_URI in the > linuxutils is a tarball release. One option is for us to drop the > tarball release from SRC_URI and use the git tree going forward. I'm > in favour of this primarily because that's where the development > happens and the tree is tagged. > > On meta-arago vs. meta-ti - I agree that the recipe should be in > meta-ti. This patch should update linuxutils accordingly. Sid, I agree with your suggestions as long as this component is common and being reused by both MCSDK and GLSDK teams, as well as others. What I don't want to happen is to unify on a single recipe and later find out that there are so many different requirements and nuances, that none of the teams can use the recipe directly and need to override and customize most of it to their needs... So, essentially, what I'm looking for is a confirmation from teams (at least Sam and Sid/Mrinmayee, maybe others) that ipc/ludev.git is _the_ repository with the latest code for the cmem/linuxutils component that is being used from a common (master?) branch. Thank you. -- Denys > >>>Signed-off-by: Sam Nelson <sam.nelson@ti.com> > >>>--- > >>> .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 > >>++++++++++++++++++++ > >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 > >>++++++++++ > >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 > >>+++++ > >>> 3 files changed, 70 insertions(+) > >>> create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti- > >>cmem-mod.bb > >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- > >>cmem.bb > >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- > >>cmem.inc > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem- > >>mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > >>>new file mode 100755 > >>>index 0000000..0839c20 > >>>--- /dev/null > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > >>>@@ -0,0 +1,40 @@ > >>>+DESCRIPTION="The cmem component module for contiguous memory > >>allocation from userspace " > >>>+ > >>> > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > >>>+ > >>>+LICENSE = "GPLv2" > >>>+ > >>>+include ti-cmem.inc > >>>+ > >>>+RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" > >>>+ > >>>+DEPENDS += "virtual/kernel" > >>>+ > >>>+NAME="cmem" > >>>+MODULE_BUILD_DIR ="src/cmem/module" > >>>+ > >>>+# This package builds a kernel module, use kernel PR as base > >>and append a local > >>>+PR = "${MACHINE_KERNEL_PR}" > >>>+PR_append = "a" > >>>+ > >>>+PKG_${PN} = "kernel-module-${PN}" > >>>+ > >>>+KERNEL_VERSION = > >>"${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" > >>>+ > >>>+S = "${WORKDIR}/git" > >>>+ > >>>+inherit module > >>>+ > >>>+do_compile () { > >>>+ cd ${S} > >>>+ make -f lu.mak module_clean > >>>+ make -f lu.mak module > >>KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} > >>TOOLCHAIN_PREFIX=${CROSS_COMPILE} > >>>+} > >>>+ > >>>+do_install () { > >>>+ cd ${S} > >>>+ make -f lu.mak module_install > >>KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" > >>EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" > >>INSTALL_MOD_PATH="${D}" > >>>+} > >>>+ > >>>+PACKAGE_STRIP = "no" > >>>+ > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > >>>new file mode 100644 > >>>index 0000000..a106aa0 > >>>--- /dev/null > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > >>>@@ -0,0 +1,20 @@ > >>>+DESCRIPTION="The cmem component supports contiguous memory > >>allocation from userspace " > >>>+ > >>> > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > >>>+ > >>>+LICENSE = "GPLv2" > >>>+ > >>>+include ti-cmem.inc > >>>+ > >>>+DEPENDS = "ti-cmem-mod" > >>>+ > >>>+S = "${WORKDIR}/git" > >>>+ > >>>+PR = "r1" > >>>+ > >>>+PACKAGES =+ "${PN}-test" > >>>+ > >>>+FILES_${PN}-test = "${bindir}/*" > >>>+ > >>>+inherit autotools > >>>+ > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > >>>new file mode 100644 > >>>index 0000000..9308b2d > >>>--- /dev/null > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > >>>@@ -0,0 +1,10 @@ > >>> > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > >>>+ > >>>+LIC_FILES_CHKSUM = > >>"file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165b > >>cb1a23ffd50dbb" > >>>+ > >>>+COMPATIBLE_MACHINE = "keystone-evm" > >>>+ > >>>+BRANCH ?= "master" > >>>+SRCREV = "4.00.00.06" > >>>+ > >>>+SRC_URI = > >>"git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > >> > >>_______________________________________________ > >>meta-arago mailing list > >>meta-arago@arago-project.org > >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-11-04 17:06 ` Denys Dmytriyenko @ 2013-11-06 15:53 ` Nelson, Sam 2013-11-06 21:13 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Nelson, Sam @ 2013-11-06 15:53 UTC (permalink / raw) To: Dmytriyenko, Denys, Heroor, Siddharth; +Cc: meta-arago@arago-project.org > -----Original Message----- > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > bounces@arago-project.org] On Behalf Of Dmytriyenko, Denys > Sent: Monday, November 04, 2013 12:06 PM > To: Heroor, Siddharth > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-cmem > > On Sat, Nov 02, 2013 at 12:35:18PM +0530, Siddharth Heroor wrote: > > On 10/31/2013 7:11 PM, Maupin, Chase wrote: > > >>-----Original Message----- > > >>From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > >>bounces@arago-project.org] On Behalf Of Heroor, Siddharth > > >>Sent: Wednesday, October 30, 2013 11:19 PM > > >>To: meta-arago@arago-project.org > > >>Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti- > > >>cmem > > >> > > >>On 10/31/2013 12:37 AM, Sam Nelson wrote: > > >>>- Recipes for ti-cmem which provides user space api for > > >>contigous memory allocaion > > >>>- ti-cmem_mod provides the kernel module > > >>>- ti-mem provides the user space library > > >>Why do we need to create a new recipe? The ti-linuxutils in meta- > > >>ti > > >>should be the provider for cmem. Shouldn't that be updated for > > >>newer > > >>versions? > > >>Also, I would suggest that we make it machine compatible with > > >>omap-a15. > > > >I don't know that linuxutils is really the right solution. I think it > > >mainly comes down to where/how is cmem being released. So really the > > >question is whether the SRC_URI used below is the official cmem release > > >point or is the SRC_URI from linuxutils right? We do not need multiple > > >versions of cmem where everyone has their own fork of the cmem code. > > > > > >Another point is shouldn't this be in meta-ti for at least the cmem > module? > > > > ludev in the SRC_URI stands for linuxutils dev. The SRC_URI in the > > linuxutils is a tarball release. One option is for us to drop the > > tarball release from SRC_URI and use the git tree going forward. I'm > > in favour of this primarily because that's where the development > > happens and the tree is tagged. > > > > On meta-arago vs. meta-ti - I agree that the recipe should be in > > meta-ti. This patch should update linuxutils accordingly. > > Sid, > > I agree with your suggestions as long as this component is common and > being > reused by both MCSDK and GLSDK teams, as well as others. > > What I don't want to happen is to unify on a single recipe and later find out > that there are so many different requirements and nuances, that none of the > teams can use the recipe directly and need to override and customize most > of > it to their needs... [Sam] I have discussed with the TISB team who owns the linuxutils. Moving forward it makes sense to use the cmem recipes to be used. (Although it is a component of linuxutils). Does it still makes sense to move to meta-ti? > > So, essentially, what I'm looking for is a confirmation from teams (at least > Sam and Sid/Mrinmayee, maybe others) that ipc/ludev.git is _the_ repository > with the latest code for the cmem/linuxutils component that is being used > from > a common (master?) branch. Thank you. [Sam] Yes. ludev.git will be the place all future releases of cmem will be delivered. > > -- > Denys > > > > >>>Signed-off-by: Sam Nelson <sam.nelson@ti.com> > > >>>--- > > >>> .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 > > >>++++++++++++++++++++ > > >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 > > >>++++++++++ > > >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 > > >>+++++ > > >>> 3 files changed, 70 insertions(+) > > >>> create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti- > > >>cmem-mod.bb > > >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- > > >>cmem.bb > > >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- > > >>cmem.inc > > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem- > > >>mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > >>>new file mode 100755 > > >>>index 0000000..0839c20 > > >>>--- /dev/null > > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > >>>@@ -0,0 +1,40 @@ > > >>>+DESCRIPTION="The cmem component module for contiguous memory > > >>allocation from userspace " > > >>>+ > > >>> > > > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > >>>+ > > >>>+LICENSE = "GPLv2" > > >>>+ > > >>>+include ti-cmem.inc > > >>>+ > > >>>+RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" > > >>>+ > > >>>+DEPENDS += "virtual/kernel" > > >>>+ > > >>>+NAME="cmem" > > >>>+MODULE_BUILD_DIR ="src/cmem/module" > > >>>+ > > >>>+# This package builds a kernel module, use kernel PR as base > > >>and append a local > > >>>+PR = "${MACHINE_KERNEL_PR}" > > >>>+PR_append = "a" > > >>>+ > > >>>+PKG_${PN} = "kernel-module-${PN}" > > >>>+ > > >>>+KERNEL_VERSION = > > >>"${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" > > >>>+ > > >>>+S = "${WORKDIR}/git" > > >>>+ > > >>>+inherit module > > >>>+ > > >>>+do_compile () { > > >>>+ cd ${S} > > >>>+ make -f lu.mak module_clean > > >>>+ make -f lu.mak module > > >>KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} > > >>TOOLCHAIN_PREFIX=${CROSS_COMPILE} > > >>>+} > > >>>+ > > >>>+do_install () { > > >>>+ cd ${S} > > >>>+ make -f lu.mak module_install > > >>KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" > > >>EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" > > >>INSTALL_MOD_PATH="${D}" > > >>>+} > > >>>+ > > >>>+PACKAGE_STRIP = "no" > > >>>+ > > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > >>>new file mode 100644 > > >>>index 0000000..a106aa0 > > >>>--- /dev/null > > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > >>>@@ -0,0 +1,20 @@ > > >>>+DESCRIPTION="The cmem component supports contiguous memory > > >>allocation from userspace " > > >>>+ > > >>> > > > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > >>>+ > > >>>+LICENSE = "GPLv2" > > >>>+ > > >>>+include ti-cmem.inc > > >>>+ > > >>>+DEPENDS = "ti-cmem-mod" > > >>>+ > > >>>+S = "${WORKDIR}/git" > > >>>+ > > >>>+PR = "r1" > > >>>+ > > >>>+PACKAGES =+ "${PN}-test" > > >>>+ > > >>>+FILES_${PN}-test = "${bindir}/*" > > >>>+ > > >>>+inherit autotools > > >>>+ > > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > >>>new file mode 100644 > > >>>index 0000000..9308b2d > > >>>--- /dev/null > > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > >>>@@ -0,0 +1,10 @@ > > >>> > > > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > >>>+ > > >>>+LIC_FILES_CHKSUM = > > >>"file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165b > > >>cb1a23ffd50dbb" > > >>>+ > > >>>+COMPATIBLE_MACHINE = "keystone-evm" > > >>>+ > > >>>+BRANCH ?= "master" > > >>>+SRCREV = "4.00.00.06" > > >>>+ > > >>>+SRC_URI = > > >>"git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > > >> > > >>_______________________________________________ > > >>meta-arago mailing list > > >>meta-arago@arago-project.org > > >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] ti-cmem: New recipes for ti-cmem 2013-11-06 15:53 ` Nelson, Sam @ 2013-11-06 21:13 ` Denys Dmytriyenko 0 siblings, 0 replies; 13+ messages in thread From: Denys Dmytriyenko @ 2013-11-06 21:13 UTC (permalink / raw) To: Nelson, Sam; +Cc: meta-arago@arago-project.org On Wed, Nov 06, 2013 at 10:53:08AM -0500, Nelson, Sam wrote: > > > > -----Original Message----- > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > bounces@arago-project.org] On Behalf Of Dmytriyenko, Denys > > Sent: Monday, November 04, 2013 12:06 PM > > To: Heroor, Siddharth > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti-cmem > > > > On Sat, Nov 02, 2013 at 12:35:18PM +0530, Siddharth Heroor wrote: > > > On 10/31/2013 7:11 PM, Maupin, Chase wrote: > > > >>-----Original Message----- > > > >>From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > > >>bounces@arago-project.org] On Behalf Of Heroor, Siddharth > > > >>Sent: Wednesday, October 30, 2013 11:19 PM > > > >>To: meta-arago@arago-project.org > > > >>Subject: Re: [meta-arago] [PATCH 1/1] ti-cmem: New recipes for ti- > > > >>cmem > > > >> > > > >>On 10/31/2013 12:37 AM, Sam Nelson wrote: > > > >>>- Recipes for ti-cmem which provides user space api for > > > >>contigous memory allocaion > > > >>>- ti-cmem_mod provides the kernel module > > > >>>- ti-mem provides the user space library > > > >>Why do we need to create a new recipe? The ti-linuxutils in meta- > > > >>ti > > > >>should be the provider for cmem. Shouldn't that be updated for > > > >>newer > > > >>versions? > > > >>Also, I would suggest that we make it machine compatible with > > > >>omap-a15. > > > > > >I don't know that linuxutils is really the right solution. I think it > > > >mainly comes down to where/how is cmem being released. So really the > > > >question is whether the SRC_URI used below is the official cmem release > > > >point or is the SRC_URI from linuxutils right? We do not need multiple > > > >versions of cmem where everyone has their own fork of the cmem code. > > > > > > > >Another point is shouldn't this be in meta-ti for at least the cmem > > module? > > > > > > ludev in the SRC_URI stands for linuxutils dev. The SRC_URI in the > > > linuxutils is a tarball release. One option is for us to drop the > > > tarball release from SRC_URI and use the git tree going forward. I'm > > > in favour of this primarily because that's where the development > > > happens and the tree is tagged. > > > > > > On meta-arago vs. meta-ti - I agree that the recipe should be in > > > meta-ti. This patch should update linuxutils accordingly. > > > > Sid, > > > > I agree with your suggestions as long as this component is common and > > being > > reused by both MCSDK and GLSDK teams, as well as others. > > > > What I don't want to happen is to unify on a single recipe and later find out > > that there are so many different requirements and nuances, that none of the > > teams can use the recipe directly and need to override and customize most > > of > > it to their needs... > [Sam] I have discussed with the TISB team who owns the linuxutils. Moving > forward it makes sense to use the cmem recipes to be used. (Although it is a > component of linuxutils). Does it still makes sense to move to meta-ti? So, to rephrase - cmem is one of the sub-components of linuxutils, and linuxutils is used to be distributed and built as a single entity, even though it was a collection of smaller sub-components or utils. And moving forward, the component owner is now fine with splitting it up and having individual recipes for each sub-component. In that case it still makes sense to move it to meta-ti. I may need to start looking into restructuring recipes-ti/ directory (where linuxutils now lives) and figure out better places for things in there, as recipes-bsp is probably a better fit at least for cmem... > > So, essentially, what I'm looking for is a confirmation from teams (at least > > Sam and Sid/Mrinmayee, maybe others) that ipc/ludev.git is _the_ repository > > with the latest code for the cmem/linuxutils component that is being used > > from > > a common (master?) branch. Thank you. > [Sam] Yes. ludev.git will be the place all future releases of cmem will be > delivered. As long as it is shared between teams, it's fine with me - we don't want several different implementations of cmem. Denys > > > >>>Signed-off-by: Sam Nelson <sam.nelson@ti.com> > > > >>>--- > > > >>> .../recipes-bsp/ti-cmem/ti-cmem-mod.bb | 40 > > > >>++++++++++++++++++++ > > > >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb | 20 > > > >>++++++++++ > > > >>> meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc | 10 > > > >>+++++ > > > >>> 3 files changed, 70 insertions(+) > > > >>> create mode 100755 meta-arago-extras/recipes-bsp/ti-cmem/ti- > > > >>cmem-mod.bb > > > >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- > > > >>cmem.bb > > > >>> create mode 100644 meta-arago-extras/recipes-bsp/ti-cmem/ti- > > > >>cmem.inc > > > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem- > > > >>mod.bb b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > > >>>new file mode 100755 > > > >>>index 0000000..0839c20 > > > >>>--- /dev/null > > > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem-mod.bb > > > >>>@@ -0,0 +1,40 @@ > > > >>>+DESCRIPTION="The cmem component module for contiguous memory > > > >>allocation from userspace " > > > >>>+ > > > >>> > > > > > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > > >>>+ > > > >>>+LICENSE = "GPLv2" > > > >>>+ > > > >>>+include ti-cmem.inc > > > >>>+ > > > >>>+RDEPENDS_${PN} += "kernel (=${KERNEL_VERSION})" > > > >>>+ > > > >>>+DEPENDS += "virtual/kernel" > > > >>>+ > > > >>>+NAME="cmem" > > > >>>+MODULE_BUILD_DIR ="src/cmem/module" > > > >>>+ > > > >>>+# This package builds a kernel module, use kernel PR as base > > > >>and append a local > > > >>>+PR = "${MACHINE_KERNEL_PR}" > > > >>>+PR_append = "a" > > > >>>+ > > > >>>+PKG_${PN} = "kernel-module-${PN}" > > > >>>+ > > > >>>+KERNEL_VERSION = > > > >>"${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}" > > > >>>+ > > > >>>+S = "${WORKDIR}/git" > > > >>>+ > > > >>>+inherit module > > > >>>+ > > > >>>+do_compile () { > > > >>>+ cd ${S} > > > >>>+ make -f lu.mak module_clean > > > >>>+ make -f lu.mak module > > > >>KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} > > > >>TOOLCHAIN_PREFIX=${CROSS_COMPILE} > > > >>>+} > > > >>>+ > > > >>>+do_install () { > > > >>>+ cd ${S} > > > >>>+ make -f lu.mak module_install > > > >>KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" > > > >>EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" > > > >>INSTALL_MOD_PATH="${D}" > > > >>>+} > > > >>>+ > > > >>>+PACKAGE_STRIP = "no" > > > >>>+ > > > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > > >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > > >>>new file mode 100644 > > > >>>index 0000000..a106aa0 > > > >>>--- /dev/null > > > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.bb > > > >>>@@ -0,0 +1,20 @@ > > > >>>+DESCRIPTION="The cmem component supports contiguous memory > > > >>allocation from userspace " > > > >>>+ > > > >>> > > > > > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > > >>>+ > > > >>>+LICENSE = "GPLv2" > > > >>>+ > > > >>>+include ti-cmem.inc > > > >>>+ > > > >>>+DEPENDS = "ti-cmem-mod" > > > >>>+ > > > >>>+S = "${WORKDIR}/git" > > > >>>+ > > > >>>+PR = "r1" > > > >>>+ > > > >>>+PACKAGES =+ "${PN}-test" > > > >>>+ > > > >>>+FILES_${PN}-test = "${bindir}/*" > > > >>>+ > > > >>>+inherit autotools > > > >>>+ > > > >>>diff --git a/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > > >>b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > > >>>new file mode 100644 > > > >>>index 0000000..9308b2d > > > >>>--- /dev/null > > > >>>+++ b/meta-arago-extras/recipes-bsp/ti-cmem/ti-cmem.inc > > > >>>@@ -0,0 +1,10 @@ > > > >>> > > > > > >>+HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:CMEM" > > > >>>+ > > > >>>+LIC_FILES_CHKSUM = > > > >>"file://products.mak;beginline=2;endline=30;md5=195feadf798bb4165b > > > >>cb1a23ffd50dbb" > > > >>>+ > > > >>>+COMPATIBLE_MACHINE = "keystone-evm" > > > >>>+ > > > >>>+BRANCH ?= "master" > > > >>>+SRCREV = "4.00.00.06" > > > >>>+ > > > >>>+SRC_URI = > > > >>"git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" > > > >> > > > >>_______________________________________________ > > > >>meta-arago mailing list > > > >>meta-arago@arago-project.org > > > >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > > > > > _______________________________________________ > > > meta-arago mailing list > > > meta-arago@arago-project.org > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-11-06 21:13 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-10-30 19:07 [PATCH 1/1] ti-cmem: New recipes for ti-cmem Sam Nelson 2013-10-30 19:23 ` Denys Dmytriyenko 2013-10-30 22:22 ` Nelson, Sam 2013-10-30 23:37 ` Denys Dmytriyenko 2013-10-31 2:59 ` Nelson, Sam 2013-10-30 19:24 ` Cooper Jr., Franklin 2013-10-31 3:02 ` Nelson, Sam 2013-10-31 4:18 ` Siddharth Heroor 2013-10-31 13:41 ` Maupin, Chase 2013-11-02 7:05 ` Siddharth Heroor 2013-11-04 17:06 ` Denys Dmytriyenko 2013-11-06 15:53 ` Nelson, Sam 2013-11-06 21:13 ` Denys Dmytriyenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.