From: Gleb Natapov <gleb@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS
Date: Tue, 5 Nov 2013 09:34:53 +0200 [thread overview]
Message-ID: <20131105073453.GH7513@redhat.com> (raw)
In-Reply-To: <1382021272-6059-1-git-send-email-pbonzini@redhat.com>
On Thu, Oct 17, 2013 at 04:47:52PM +0200, Paolo Bonzini wrote:
> Only the first item of the array was ever looked at. No
> practical effect, but still worth fixing.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Applied, thanks.
> ---
> target-i386/kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 749aa09..27071e3 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
>
> for (i = 0; i < xcrs.nr_xcrs; i++) {
> /* Only support xcr0 now */
> - if (xcrs.xcrs[0].xcr == 0) {
> - env->xcr0 = xcrs.xcrs[0].value;
> + if (xcrs.xcrs[i].xcr == 0) {
> + env->xcr0 = xcrs.xcrs[i].value;
> break;
> }
> }
> --
> 1.8.3.1
--
Gleb.
WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS
Date: Tue, 5 Nov 2013 09:34:53 +0200 [thread overview]
Message-ID: <20131105073453.GH7513@redhat.com> (raw)
In-Reply-To: <1382021272-6059-1-git-send-email-pbonzini@redhat.com>
On Thu, Oct 17, 2013 at 04:47:52PM +0200, Paolo Bonzini wrote:
> Only the first item of the array was ever looked at. No
> practical effect, but still worth fixing.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Applied, thanks.
> ---
> target-i386/kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 749aa09..27071e3 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
>
> for (i = 0; i < xcrs.nr_xcrs; i++) {
> /* Only support xcr0 now */
> - if (xcrs.xcrs[0].xcr == 0) {
> - env->xcr0 = xcrs.xcrs[0].value;
> + if (xcrs.xcrs[i].xcr == 0) {
> + env->xcr0 = xcrs.xcrs[i].value;
> break;
> }
> }
> --
> 1.8.3.1
--
Gleb.
next prev parent reply other threads:[~2013-11-05 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 14:47 [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS Paolo Bonzini
2013-10-17 14:47 ` [Qemu-devel] " Paolo Bonzini
2013-11-04 15:56 ` Paolo Bonzini
2013-11-04 15:56 ` [Qemu-devel] " Paolo Bonzini
2013-11-05 7:34 ` Gleb Natapov [this message]
2013-11-05 7:34 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105073453.GH7513@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.