From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: null_blk: multi queue aware block test driver
Date: Tue, 05 Nov 2013 20:21:34 +0000 [thread overview]
Message-ID: <20131105202134.GE3949@elgon.mountain> (raw)
Hello Jens Axboe,
This is a semi-automatic email about new static checker warnings.
The patch f2298c0403b0: "null_blk: multi queue aware block test
driver" from Oct 25, 2013, leads to the following Smatch complaint:
drivers/block/null_blk.c:524 null_add_dev()
warn: variable dereferenced before check 'nullb->q' (see line 523)
drivers/block/null_blk.c
522 nullb->q = blk_init_queue_node(null_request_fn, &nullb->lock, home_node);
523 blk_queue_prep_rq(nullb->q, null_rq_prep_fn);
^^^^^^^^
Dereference.
524 if (nullb->q)
^^^^^^^^
Null check.
525 blk_queue_softirq_done(nullb->q, null_softirq_done_fn);
526 }
regards,
dan carpenter
next reply other threads:[~2013-11-05 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 20:21 Dan Carpenter [this message]
2013-11-05 20:22 ` null_blk: multi queue aware block test driver Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105202134.GE3949@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.