All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: null_blk: multi queue aware block test driver
Date: Tue, 05 Nov 2013 20:22:12 +0000	[thread overview]
Message-ID: <20131105202212.GF3949@elgon.mountain> (raw)
In-Reply-To: <20131105202134.GE3949@elgon.mountain>

Hello Jens Axboe,

The patch f2298c0403b0: "null_blk: multi queue aware block test 
driver" from Oct 25, 2013, leads to the following
static checker warning: "drivers/block/null_blk.c:531 null_add_dev()
	 error: 'nullb->q' dereferencing possible ERR_PTR()"

drivers/block/null_blk.c
   513  
   514                          null_mq_reg.nr_hw_queues = submit_queues;
   515                  }
   516  
   517                  nullb->q = blk_mq_init_queue(&null_mq_reg, nullb);
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
blk_mq_init_queue() returns an ERR_PTR on error.

   518          } else if (queue_mode = NULL_Q_BIO) {
   519                  nullb->q = blk_alloc_queue_node(GFP_KERNEL, home_node);
   520                  blk_queue_make_request(nullb->q, null_queue_bio);
   521          } else {
   522                  nullb->q = blk_init_queue_node(null_request_fn, &nullb->lock, home_node);
   523                  blk_queue_prep_rq(nullb->q, null_rq_prep_fn);
   524                  if (nullb->q)
   525                          blk_queue_softirq_done(nullb->q, null_softirq_done_fn);
   526          }
   527  
   528          if (!nullb->q)
   529                  goto queue_fail;
   530  
   531          nullb->q->queuedata = nullb;
                ^^^^^^^^^^^^^^^^^^^
Dereference.

   532          queue_flag_set_unlocked(QUEUE_FLAG_NONROT, nullb->q);

regards,
dan carpenter


      reply	other threads:[~2013-11-05 20:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 20:21 null_blk: multi queue aware block test driver Dan Carpenter
2013-11-05 20:22 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131105202212.GF3949@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.