All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/13] ASoC: ux500_pcm: Extend ux500 MSP binding for enumeration
Date: Wed, 6 Nov 2013 11:22:48 +0000	[thread overview]
Message-ID: <20131106112248.GE30901@lee--X1> (raw)
In-Reply-To: <20131106104658.GE11602@sirena.org.uk>

On Wed, 06 Nov 2013, Mark Brown wrote:

> On Wed, Nov 06, 2013 at 10:16:18AM +0000, Lee Jones wrote:
> 
> > +++ b/Documentation/devicetree/bindings/sound/ux500-msp.txt
> > @@ -3,6 +3,7 @@
> >  Required properties:
> >   - compatible       :"stericsson,ux500-msp-i2s"
> >   - reg              : Physical base address and length of the device's registers.
> > + - id               : MSP ID - used during component registration
> 
> I have no idea what this means or how one would pick the number?  It
> looks like something purely internal to the driver...

Hmm... yes I guess you're right. I think a match table would be more
appropriate.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 06/13] ASoC: ux500_pcm: Extend ux500 MSP binding for enumeration
Date: Wed, 6 Nov 2013 11:22:48 +0000	[thread overview]
Message-ID: <20131106112248.GE30901@lee--X1> (raw)
In-Reply-To: <20131106104658.GE11602@sirena.org.uk>

On Wed, 06 Nov 2013, Mark Brown wrote:

> On Wed, Nov 06, 2013 at 10:16:18AM +0000, Lee Jones wrote:
> 
> > +++ b/Documentation/devicetree/bindings/sound/ux500-msp.txt
> > @@ -3,6 +3,7 @@
> >  Required properties:
> >   - compatible       :"stericsson,ux500-msp-i2s"
> >   - reg              : Physical base address and length of the device's registers.
> > + - id               : MSP ID - used during component registration
> 
> I have no idea what this means or how one would pick the number?  It
> looks like something purely internal to the driver...

Hmm... yes I guess you're right. I think a match table would be more
appropriate.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2013-11-06 11:22 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 10:16 [PATCH 00/13] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Lee Jones
2013-11-06 10:16 ` Lee Jones
2013-11-06 10:16 ` [PATCH 01/13] dma: ste_dma40: Expand DT binding to accept 'high-priority channel' flag Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:40   ` Linus Walleij
2013-11-06 11:40     ` Linus Walleij
2013-11-06 11:40     ` Linus Walleij
2013-11-06 12:11     ` Lee Jones
2013-11-06 12:11       ` Lee Jones
2013-11-13 14:16   ` Vinod Koul
2013-11-13 14:16     ` Vinod Koul
2013-11-06 10:16 ` [PATCH 02/13] dma: ste_dma40: Parse flags property for new 'high priority channel' request Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:40   ` Linus Walleij
2013-11-06 11:40     ` Linus Walleij
2013-11-13 14:16   ` Vinod Koul
2013-11-13 14:16     ` Vinod Koul
2013-11-06 10:16 ` [PATCH 03/13] ARM: ux500: Don't use enums for MSP IDs - for easy DT conversion Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:41   ` Linus Walleij
2013-11-06 11:41     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 04/13] ARM: ux500: Add DMA config bindings for MSP devices Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:44   ` Linus Walleij
2013-11-06 11:44     ` Linus Walleij
2013-11-06 12:10     ` Lee Jones
2013-11-06 12:10       ` Lee Jones
2013-11-12 19:43   ` Linus Walleij
2013-11-12 19:43     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 05/13] ARM: ux500: Add ID properties to 'simply' differentiate between MSPs Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:45   ` Linus Walleij
2013-11-06 11:45     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 06/13] ASoC: ux500_pcm: Extend ux500 MSP binding for enumeration Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 10:46   ` Mark Brown
2013-11-06 10:46     ` Mark Brown
2013-11-06 11:22     ` Lee Jones [this message]
2013-11-06 11:22       ` Lee Jones
2013-11-06 11:55     ` Linus Walleij
2013-11-06 11:55       ` Linus Walleij
2013-11-06 12:04       ` Mark Brown
2013-11-06 12:04         ` Mark Brown
2013-11-06 12:04         ` Mark Brown
2013-11-06 12:07       ` Lee Jones
2013-11-06 12:07         ` Lee Jones
2013-11-06 10:16 ` [PATCH 07/13] ASoC: ux500_pcm: Extract MSP IDs from Device Tree Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:46   ` Linus Walleij
2013-11-06 11:46     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 08/13] ASoC: generic-dmaengine-pcm: Clear slave_config memory Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:55   ` [alsa-devel] " Lars-Peter Clausen
2013-11-06 11:55     ` Lars-Peter Clausen
2013-11-07 11:36   ` Mark Brown
2013-11-07 11:36     ` Mark Brown
2013-11-07 11:36     ` Mark Brown
2013-11-06 10:16 ` [PATCH 09/13] ASoC: Ux500: Match platform by device node when booting Device Tree Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:47   ` Linus Walleij
2013-11-06 11:47     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 10/13] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:49   ` Linus Walleij
2013-11-06 11:49     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 11/13] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:50   ` Linus Walleij
2013-11-06 11:50     ` Linus Walleij
2013-11-06 11:50     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 12/13] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:51   ` Linus Walleij
2013-11-06 11:51     ` Linus Walleij
2013-11-06 10:16 ` [PATCH 13/13] ASoC: ux500_pcm: Take out pointless dev_dbg() call Lee Jones
2013-11-06 10:16   ` Lee Jones
2013-11-06 11:52   ` Linus Walleij
2013-11-06 11:52     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131106112248.GE30901@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.