Re: [meta-selinux][PATCH 1/4] Move common POLICY_* variables to refpolicy_common.inc

[Joe MacDonald <joe@deserted.net>]

[-- Attachment #1: Type: text/plain, Size: 3260 bytes --]

[Re: [yocto] [meta-selinux][PATCH 1/4] Move common POLICY_* variables to refpolicy_common.inc] On 13.11.06 (Wed 09:03) Philip Tricca wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Hey Joe,
> 
> On 10/30/2013 10:22 AM, Joe MacDonald wrote:
> > [[yocto] [meta-selinux][PATCH 1/4] Move common POLICY_* variables
> > to refpolicy_common.inc] On 13.10.30 (Wed 01:11) Philip Tricca
> > wrote:
> > 
> >> Use default assignment to allow variables to be overriden by
> >> recipes that include refpolicy_common.inc
> >> 
> >> Signed-off-by: Philip Tricca <flihp@twobit.us> --- 
> >> recipes-security/refpolicy/refpolicy_common.inc |   12
> >> ++++++++++++ 1 file changed, 12 insertions(+)
> >> 
> >> diff --git a/recipes-security/refpolicy/refpolicy_common.inc
> >> b/recipes-security/refpolicy/refpolicy_common.inc index
> >> 0ca0b9d..65d679b 100644 ---
> >> a/recipes-security/refpolicy/refpolicy_common.inc +++
> >> b/recipes-security/refpolicy/refpolicy_common.inc @@ -24,6 +24,18
> >> @@ inherit autotools pythonnative
> >> 
> >> PARALLEL_MAKE = ""
> >> 
> >> +POLICY_NAME ?= "${POLICY_TYPE}" +POLICY_DISTRO ?= "redhat" 
> >> +POLICY_UBAC ?= "n" +POLICY_UNK_PERMS ?= "allow" 
> >> +POLICY_DIRECT_INITRC ?= "n" +POLICY_MONOLITHIC ?= "n" 
> >> +POLICY_CUSTOM_BUILDOPT ?= "" +POLICY_QUIET ?= "y" 
> >> +POLICY_MLS_SENS = "16" +POLICY_MLS_CATS = "1024" 
> >> +POLICY_MCS_CATS = "1024"
> > 
> > Any reason not to make these last three soft assignments as well? 
> > They're unlikely to change and putting them here makes sense, but I
> > can also imagine someone wanting to use this as a base for creating
> > a simplified policy.
> 
> Would you like me to make these changes and resend?

Oops, I'm sorry, Philip, when you followed up saying it was a minor
oversight that they weren't ?= as well, I just assumed you would be
sending a new set, then got distracted with other stuff.  Looking in
context, though, obviously there's no need for a new version based on
such a minor change.  I'll do the merge right now, I've been working
with these in my tree for a week now, after all.  :-)

-J.

> 
> - - Philip
> 
> >> + EXTRA_OEMAKE += "NAME=${POLICY_NAME} \ TYPE=${POLICY_TYPE} \ 
> >> DISTRO=${POLICY_DISTRO} \
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Icedove - http://www.enigmail.net/
> 
> iQIcBAEBCgAGBQJSekwvAAoJEDL3fnXC4dO6e2oP/iLoGZo3LEltHEcGGslI4rwN
> zkI84+zlwMPUue5Phof6oJXYCbDVTfCM4ZfHeZsoVZXwfUr5fy6hepSIVO/7RdEM
> FJfAK99UqwfRYA92dEQpKn4h72RB0DcWF01k8Lxg1fWS189HFDrTJbT0IW/iOxs8
> nUTX9AFtOkYdW7xhjczaLK/0aTsrq/jkjd5poUh2Os8xbM7l8r69+YlG0GycuUFu
> kaMm3QiHhZxiiYSj3m+ZNEF/iBksuBA7oJqoggr8l2rQpoxXOKgoeUdnUcqnNm7D
> KmvSiKNwDEcjo6dakycqeF4xbSD3msQtkimkGn4wTqfBFPcFoqkgq1gJobUw4p/4
> iwDgjYQEZ/WRuoSIHqKYHkUDHElnVLwqDRsrQI0mvZITyCbkuYzgkYmCxAyIqZcG
> 1DpNXAgcT59EI8Qfhmm8ukaCQ9nixCQgehv7Yqsw9Ry0y2uHhqtnTHotZ3xVJVlq
> 5T7bPBi71wsy2VN3rmwVq3QgMClhV+TCvdQPtU7CCO28f0olAxkjKwwacsC4lQSZ
> FVnQP8mWoyf7x7WVBk1cKm+MTxJpFCY0ldAt09B80/+6CPT6BCm1j3l0X4dcjvXl
> cUIOU0zbOQfHyd8T9CRsAJVXUgHikZM70MnqE0QSbAKom6huacIl+ON82dqiISJf
> zkdzv9hqP9k+PXv7wH4G
> =JL/2
> -----END PGP SIGNATURE-----

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]