Re: [meta-selinux][PATCH 1/4] Move common POLICY_* variables to refpolicy_common.inc

[Philip Tricca <flihp@twobit.us>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 10/30/2013 10:22 AM, Joe MacDonald wrote:
> [[yocto] [meta-selinux][PATCH 1/4] Move common POLICY_* variables
> to refpolicy_common.inc] On 13.10.30 (Wed 01:11) Philip Tricca
> wrote:
> 
>> Use default assignment to allow variables to be overriden by
>> recipes that include refpolicy_common.inc
>> 
>> Signed-off-by: Philip Tricca <flihp@twobit.us> --- 
>> recipes-security/refpolicy/refpolicy_common.inc |   12
>> ++++++++++++ 1 file changed, 12 insertions(+)
>> 
>> diff --git a/recipes-security/refpolicy/refpolicy_common.inc
>> b/recipes-security/refpolicy/refpolicy_common.inc index
>> 0ca0b9d..65d679b 100644 ---
>> a/recipes-security/refpolicy/refpolicy_common.inc +++
>> b/recipes-security/refpolicy/refpolicy_common.inc @@ -24,6 +24,18
>> @@ inherit autotools pythonnative
>> 
>> PARALLEL_MAKE = ""
>> 
>> +POLICY_NAME ?= "${POLICY_TYPE}" +POLICY_DISTRO ?= "redhat" 
>> +POLICY_UBAC ?= "n" +POLICY_UNK_PERMS ?= "allow" 
>> +POLICY_DIRECT_INITRC ?= "n" +POLICY_MONOLITHIC ?= "n" 
>> +POLICY_CUSTOM_BUILDOPT ?= "" +POLICY_QUIET ?= "y" 
>> +POLICY_MLS_SENS = "16" +POLICY_MLS_CATS = "1024" 
>> +POLICY_MCS_CATS = "1024"
> 
> Any reason not to make these last three soft assignments as well? 
> They're unlikely to change and putting them here makes sense, but I
> can also imagine someone wanting to use this as a base for creating
> a simplified policy.

Agree these should be default assignment as well. This was just an
oversight on my part. Good catch & thanks.

- - Philip

>> + EXTRA_OEMAKE += "NAME=${POLICY_NAME} \ TYPE=${POLICY_TYPE} \ 
>> DISTRO=${POLICY_DISTRO} \

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iQIcBAEBCgAGBQJScRyPAAoJEDL3fnXC4dO6jhsP/RN8oRzJM2Hv2EYBFBQD8lB3
diOfg13xNye7shlmWUmhHppdR41eiTRQS7ozpzrZz7XsI1RFhB7Zeav9R/uRuqZa
+UkXMg0SF979Qpd1MjjFMl9itlUVFvtZsLdXQCB/OmXQB2Z/YL559UTvR/rD+RUd
qqOpRCgZrwo87O9qn4gVMktd4eG+ETyxgzaDO+BNTAmSLqO8kcxDqd3+UsBT8z/9
4P4UsAGStJNPNDpk4lUoZSZDQUtQNQjGgX3iA0mhzfO1MQ4k6zLq6cAT8Bdov8r+
4nRTHFF8WlrI6cjvjy07ffw7QrIu6Gg9m6krdXYapMYThOf7WEVU1g5uFQr4nget
VEC9Zcz6s3oRppGLDYR28scTCaNqiKyiA5CzQ3GsmhgtZVXBw0k2RBW9vNqrwdgi
rYkq523tKX7sj6WM2+leDp6GtgB6qwNqMlHT4UWMeoDdLvXc6blxZbtWhLqdEp7L
Escohx5biH7zLHrgoDHRmkvobQ4g1pP9k8MRgZIKWQ56vmPVrmvN7O3Uj9jenIk6
RcbFQhlwVhXBdRCJxCbejRRIZ1yvWFTGI/yEJ0UgHlYgE0eBFbOnyxDK/f835Ybs
pPhQCoRbetfcB1GkB9T+wxj2IP+RmXVQI7rm2SAs9IjFy3TDndKds/A9z1LJkXCa
QtMLQtTkd+o1cOTg7HLK
=QCzZ
-----END PGP SIGNATURE-----