[PATCH] avr32: Remove HAVE_KPROBES from avr32 Kconfig

[PATCH] avr32: Remove HAVE_KPROBES from avr32 Kconfig

[Steven Rostedt]

Although there's a arch/avr32/kernel/kprobes.c file, this arch does not
compile with kprobes enabled:

 In file included from cross-linux.git/arch/avr32/kernel/kprobes.c:14:
 cross-linux.git/include/linux/kprobes.h: In function 'get_kprobe_ctlblk':
 cross-linux.git/include/linux/kprobes.h:358: error: invalid use of undefined type 'struct kprobe_ctlblk'
 cross-linux.git/include/linux/kprobes.h:358: error: dereferencing pointer to incomplete type
 make[2]: *** [arch/avr32/kernel/kprobes.o] Error 1

This is because it does not define the required kprobe_ctlblk struct,
and fails to compile when CONFIG_KPROBES is set.

Unfortunately, this also makes my testing of various configs for
different archs to fail on avr32 as well.

If kprobes is not supported by avr32 than do not say that it is.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

diff --git a/arch/avr32/Kconfig b/arch/avr32/Kconfig
index b6878eb..25bcc62 100644
--- a/arch/avr32/Kconfig
+++ b/arch/avr32/Kconfig
@@ -5,7 +5,6 @@ config AVR32
 	select EXPERT
 	select HAVE_CLK
 	select HAVE_OPROFILE
-	select HAVE_KPROBES
 	select VIRT_TO_BUS
 	select GENERIC_IRQ_PROBE
 	select GENERIC_ATOMIC64

Re: [PATCH] avr32: Remove HAVE_KPROBES from avr32 Kconfig

[Hans-Christian Egtvedt]

Around Wed 06 Nov 2013 12:43:30 -0500 or thereabout, Steven Rostedt wrote:

Hello,

> Although there's a arch/avr32/kernel/kprobes.c file, this arch does not
> compile with kprobes enabled:
> 
>  In file included from cross-linux.git/arch/avr32/kernel/kprobes.c:14:
>  cross-linux.git/include/linux/kprobes.h: In function 'get_kprobe_ctlblk':
>  cross-linux.git/include/linux/kprobes.h:358: error: invalid use of undefined type 'struct kprobe_ctlblk'
>  cross-linux.git/include/linux/kprobes.h:358: error: dereferencing pointer to incomplete type
>  make[2]: *** [arch/avr32/kernel/kprobes.o] Error 1
> 
> This is because it does not define the required kprobe_ctlblk struct,
> and fails to compile when CONFIG_KPROBES is set.
> 
> Unfortunately, this also makes my testing of various configs for
> different archs to fail on avr32 as well.
> 
> If kprobes is not supported by avr32 than do not say that it is.

kprobes is supposed to be supported on AVR32, but it seems to have broken
somewhere down the road.

I re-discovered an old patch fixing this from Eirik, I have added this to my
for-linus branch instead of your proposed patch.

https://git.kernel.org/cgit/linux/kernel/git/egtvedt/linux-avr32.git/log/?h=for-linus

> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> 
> diff --git a/arch/avr32/Kconfig b/arch/avr32/Kconfig
> index b6878eb..25bcc62 100644
> --- a/arch/avr32/Kconfig
> +++ b/arch/avr32/Kconfig
> @@ -5,7 +5,6 @@ config AVR32
>  	select EXPERT
>  	select HAVE_CLK
>  	select HAVE_OPROFILE
> -	select HAVE_KPROBES
>  	select VIRT_TO_BUS
>  	select GENERIC_IRQ_PROBE
>  	select GENERIC_ATOMIC64
-- 
mvh
Hans-Christian Egtvedt

Re: [PATCH] avr32: Remove HAVE_KPROBES from avr32 Kconfig

[Steven Rostedt]

On Wed, 6 Nov 2013 22:05:21 +0100
Hans-Christian Egtvedt <egtvedt@samfundet.no> wrote:

> Around Wed 06 Nov 2013 12:43:30 -0500 or thereabout, Steven Rostedt wrote:
> 
> Hello,
> 
> > Although there's a arch/avr32/kernel/kprobes.c file, this arch does not
> > compile with kprobes enabled:
> > 
> >  In file included from cross-linux.git/arch/avr32/kernel/kprobes.c:14:
> >  cross-linux.git/include/linux/kprobes.h: In function 'get_kprobe_ctlblk':
> >  cross-linux.git/include/linux/kprobes.h:358: error: invalid use of undefined type 'struct kprobe_ctlblk'
> >  cross-linux.git/include/linux/kprobes.h:358: error: dereferencing pointer to incomplete type
> >  make[2]: *** [arch/avr32/kernel/kprobes.o] Error 1
> > 
> > This is because it does not define the required kprobe_ctlblk struct,
> > and fails to compile when CONFIG_KPROBES is set.
> > 
> > Unfortunately, this also makes my testing of various configs for
> > different archs to fail on avr32 as well.
> > 
> > If kprobes is not supported by avr32 than do not say that it is.
> 
> kprobes is supposed to be supported on AVR32, but it seems to have broken
> somewhere down the road.
> 
> I re-discovered an old patch fixing this from Eirik, I have added this to my
> for-linus branch instead of your proposed patch.
> 
> https://git.kernel.org/cgit/linux/kernel/git/egtvedt/linux-avr32.git/log/?h=for-linus
> 

That works too! I was hoping for a similar fix. I sent my patch more as
an incentive to get kprobes fixed than to disable it ;-)

Tested-by: Steven Rostedt <rostedt@goodmis.org> # only cross compiled tested

-- Steve