From: Dan Carpenter <dan.carpenter@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [patch] ocfs2: remove some impossible checks
Date: Thu, 07 Nov 2013 07:42:32 +0000 [thread overview]
Message-ID: <20131107074232.GC21844@elgon.mountain> (raw)
pv_major and pv_minor are unsigned char type so these checks are just
noise.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c
index 4599de7..eca3f93 100644
--- a/fs/ocfs2/stack_user.c
+++ b/fs/ocfs2/stack_user.c
@@ -808,11 +808,7 @@ static int lvb_to_version(char *lvb, struct ocfs2_protocol_version *ver)
&ocfs2_user_plugin.sp_max_proto;
memcpy(&pv, lvb, sizeof(struct ocfs2_protocol_version));
- if ((pv.pv_major = LONG_MIN) || (pv.pv_major = LONG_MAX) ||
- (pv.pv_major > (u8)-1) || (pv.pv_major < 1))
- return -ERANGE;
- if ((pv.pv_minor = LONG_MIN) || (pv.pv_minor = LONG_MAX) ||
- (pv.pv_minor > (u8)-1) || (pv.pv_minor < 0))
+ if (pv.pv_major < 1)
return -ERANGE;
if ((pv.pv_major != max->pv_major) ||
(pv.pv_minor > max->pv_minor))
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [patch] ocfs2: remove some impossible checks
Date: Thu, 7 Nov 2013 10:42:32 +0300 [thread overview]
Message-ID: <20131107074232.GC21844@elgon.mountain> (raw)
pv_major and pv_minor are unsigned char type so these checks are just
noise.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c
index 4599de7..eca3f93 100644
--- a/fs/ocfs2/stack_user.c
+++ b/fs/ocfs2/stack_user.c
@@ -808,11 +808,7 @@ static int lvb_to_version(char *lvb, struct ocfs2_protocol_version *ver)
&ocfs2_user_plugin.sp_max_proto;
memcpy(&pv, lvb, sizeof(struct ocfs2_protocol_version));
- if ((pv.pv_major == LONG_MIN) || (pv.pv_major == LONG_MAX) ||
- (pv.pv_major > (u8)-1) || (pv.pv_major < 1))
- return -ERANGE;
- if ((pv.pv_minor == LONG_MIN) || (pv.pv_minor == LONG_MAX) ||
- (pv.pv_minor > (u8)-1) || (pv.pv_minor < 0))
+ if (pv.pv_major < 1)
return -ERANGE;
if ((pv.pv_major != max->pv_major) ||
(pv.pv_minor > max->pv_minor))
next reply other threads:[~2013-11-07 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 7:42 Dan Carpenter [this message]
2013-11-07 7:42 ` [Ocfs2-devel] [patch] ocfs2: remove some impossible checks Dan Carpenter
2013-11-07 22:02 ` Goldwyn Rodrigues
2013-11-07 22:02 ` [Ocfs2-devel] " Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107074232.GC21844@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.