* [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata
@ 2013-11-07 2:26 Jisheng Zhang
2013-11-07 2:34 ` Shawn Guo
2013-11-07 2:47 ` Felipe Balbi
0 siblings, 2 replies; 4+ messages in thread
From: Jisheng Zhang @ 2013-11-07 2:26 UTC (permalink / raw)
To: balbi, gregkh; +Cc: linux-usb, linux-kernel, shawn.guo, Jisheng Zhang
We need to set mxs_phy rather as the platform drvdata so that we can get
the correct mxs_phy in mxs_phy_remove().
Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/usb/phy/phy-mxs-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index fdd33b4..545844b 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
mxs_phy->clk = clk;
- platform_set_drvdata(pdev, &mxs_phy->phy);
+ platform_set_drvdata(pdev, mxs_phy);
ret = usb_add_phy_dev(&mxs_phy->phy);
if (ret)
--
1.8.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata
2013-11-07 2:26 [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata Jisheng Zhang
@ 2013-11-07 2:34 ` Shawn Guo
2013-11-07 2:36 ` Jisheng Zhang
2013-11-07 2:47 ` Felipe Balbi
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2013-11-07 2:34 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: balbi, gregkh, linux-usb, linux-kernel
On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> We need to set mxs_phy rather as the platform drvdata so that we can get
> the correct mxs_phy in mxs_phy_remove().
>
> Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Change-Id should be dropped though.
Shawn
> ---
> drivers/usb/phy/phy-mxs-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index fdd33b4..545844b 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
>
> mxs_phy->clk = clk;
>
> - platform_set_drvdata(pdev, &mxs_phy->phy);
> + platform_set_drvdata(pdev, mxs_phy);
>
> ret = usb_add_phy_dev(&mxs_phy->phy);
> if (ret)
> --
> 1.8.4.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata
2013-11-07 2:34 ` Shawn Guo
@ 2013-11-07 2:36 ` Jisheng Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2013-11-07 2:36 UTC (permalink / raw)
To: Shawn Guo
Cc: balbi@ti.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
On Wed, 6 Nov 2013 18:34:47 -0800
Shawn Guo <shawn.guo@linaro.org> wrote:
> On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> > We need to set mxs_phy rather as the platform drvdata so that we can get
> > the correct mxs_phy in mxs_phy_remove().
> >
> > Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
> Change-Id should be dropped though.
OOPs, sorry, I should take care of that. I'll remind myself every time.
Thank you for your pointing out
Jisheng
>
> Shawn
>
> > ---
> > drivers/usb/phy/phy-mxs-usb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> > index fdd33b4..545844b 100644
> > --- a/drivers/usb/phy/phy-mxs-usb.c
> > +++ b/drivers/usb/phy/phy-mxs-usb.c
> > @@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
> >
> > mxs_phy->clk = clk;
> >
> > - platform_set_drvdata(pdev, &mxs_phy->phy);
> > + platform_set_drvdata(pdev, mxs_phy);
> >
> > ret = usb_add_phy_dev(&mxs_phy->phy);
> > if (ret)
> > --
> > 1.8.4.2
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata
2013-11-07 2:26 [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata Jisheng Zhang
2013-11-07 2:34 ` Shawn Guo
@ 2013-11-07 2:47 ` Felipe Balbi
1 sibling, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2013-11-07 2:47 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: balbi, gregkh, linux-usb, linux-kernel, shawn.guo
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> We need to set mxs_phy rather as the platform drvdata so that we can get
> the correct mxs_phy in mxs_phy_remove().
>
> Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
please strip Gerrit-specific tags from commit log.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-07 2:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-07 2:26 [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata Jisheng Zhang
2013-11-07 2:34 ` Shawn Guo
2013-11-07 2:36 ` Jisheng Zhang
2013-11-07 2:47 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.