From: Joel Becker <jlbec@evilplan.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 17/24] ocfs2: Convert use of typedef ctl_table to struct ctl_table
Date: Thu, 7 Nov 2013 03:06:45 -0800 [thread overview]
Message-ID: <20131107110645.GE24799@localhost> (raw)
In-Reply-To: <f5f72664f6f5b3b433149e515cacbd0d90bf99f9.1382480758.git.joe@perches.com>
On Tue, Oct 22, 2013 at 03:30:00PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
> ---
> fs/ocfs2/stackglue.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index 39abf89..cb7ec0b 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -643,7 +643,7 @@ error:
>
> #define FS_OCFS2_NM 1
>
> -static ctl_table ocfs2_nm_table[] = {
> +static struct ctl_table ocfs2_nm_table[] = {
> {
> .procname = "hb_ctl_path",
> .data = ocfs2_hb_ctl_path,
> @@ -654,7 +654,7 @@ static ctl_table ocfs2_nm_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_mod_table[] = {
> +static struct ctl_table ocfs2_mod_table[] = {
> {
> .procname = "nm",
> .data = NULL,
> @@ -665,7 +665,7 @@ static ctl_table ocfs2_mod_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_kern_table[] = {
> +static struct ctl_table ocfs2_kern_table[] = {
> {
> .procname = "ocfs2",
> .data = NULL,
> @@ -676,7 +676,7 @@ static ctl_table ocfs2_kern_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_root_table[] = {
> +static struct ctl_table ocfs2_root_table[] = {
> {
> .procname = "fs",
> .data = NULL,
> --
> 1.8.1.2.459.gbcd45b4.dirty
>
--
Life's Little Instruction Book #451
"Don't be afraid to say, 'I'm sorry.'"
http://www.jlbec.org/
jlbec at evilplan.org
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <jlbec@evilplan.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 17/24] ocfs2: Convert use of typedef ctl_table to struct ctl_table
Date: Thu, 7 Nov 2013 03:06:45 -0800 [thread overview]
Message-ID: <20131107110645.GE24799@localhost> (raw)
In-Reply-To: <f5f72664f6f5b3b433149e515cacbd0d90bf99f9.1382480758.git.joe@perches.com>
On Tue, Oct 22, 2013 at 03:30:00PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
> ---
> fs/ocfs2/stackglue.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index 39abf89..cb7ec0b 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -643,7 +643,7 @@ error:
>
> #define FS_OCFS2_NM 1
>
> -static ctl_table ocfs2_nm_table[] = {
> +static struct ctl_table ocfs2_nm_table[] = {
> {
> .procname = "hb_ctl_path",
> .data = ocfs2_hb_ctl_path,
> @@ -654,7 +654,7 @@ static ctl_table ocfs2_nm_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_mod_table[] = {
> +static struct ctl_table ocfs2_mod_table[] = {
> {
> .procname = "nm",
> .data = NULL,
> @@ -665,7 +665,7 @@ static ctl_table ocfs2_mod_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_kern_table[] = {
> +static struct ctl_table ocfs2_kern_table[] = {
> {
> .procname = "ocfs2",
> .data = NULL,
> @@ -676,7 +676,7 @@ static ctl_table ocfs2_kern_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_root_table[] = {
> +static struct ctl_table ocfs2_root_table[] = {
> {
> .procname = "fs",
> .data = NULL,
> --
> 1.8.1.2.459.gbcd45b4.dirty
>
--
Life's Little Instruction Book #451
"Don't be afraid to say, 'I'm sorry.'"
http://www.jlbec.org/
jlbec@evilplan.org
next prev parent reply other threads:[~2013-11-07 11:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 22:29 [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table Joe Perches
2013-10-22 22:30 ` [Ocfs2-devel] " Joe Perches
2013-10-22 22:29 ` Joe Perches
2013-10-22 22:29 ` Joe Perches
2013-10-22 22:29 ` Joe Perches
2013-10-22 22:29 ` [PATCH 01/24] arm: " Joe Perches
2013-10-22 22:29 ` Joe Perches
2013-10-22 22:29 ` [PATCH 02/24] ia64: " Joe Perches
2013-10-22 22:29 ` Joe Perches
2013-10-22 22:29 ` [PATCH 03/24] s390: " Joe Perches
2013-10-25 7:18 ` Heiko Carstens
2013-10-22 22:29 ` [PATCH 04/24] tile: " Joe Perches
2013-10-22 22:29 ` [PATCH 05/24] cdrom: " Joe Perches
2013-10-22 22:29 ` [PATCH 06/24] random: " Joe Perches
2013-10-22 22:29 ` [PATCH 07/24] infiniband: " Joe Perches
2013-10-22 22:29 ` [PATCH 08/24] md: " Joe Perches
2013-10-23 0:37 ` NeilBrown
2013-10-22 22:29 ` [PATCH 09/24] parport: " Joe Perches
2013-10-22 22:29 ` [PATCH 10/24] scsi: " Joe Perches
2013-10-22 22:29 ` [PATCH 11/24] coda: " Joe Perches
2013-10-22 22:29 ` [PATCH 12/24] fscache: " Joe Perches
2013-10-22 22:29 ` [PATCH 13/24] lockd: " Joe Perches
2013-10-22 22:29 ` [PATCH 14/24] nfs: " Joe Perches
2013-10-22 22:29 ` [PATCH 15/24] inotify: " Joe Perches
2013-10-22 22:29 ` [PATCH 16/24] ntfs: " Joe Perches
2013-10-22 22:30 ` [PATCH 17/24] ocfs2: " Joe Perches
2013-10-22 22:31 ` [Ocfs2-devel] " Joe Perches
2013-11-07 11:06 ` Joel Becker [this message]
2013-11-07 11:06 ` Joel Becker
2013-10-22 22:30 ` [PATCH 18/24] proc: " Joe Perches
2013-10-22 22:30 ` [PATCH 19/24] fs: " Joe Perches
2013-10-22 22:30 ` [PATCH 20/24] key: " Joe Perches
2013-10-22 22:30 ` [PATCH 21/24] ipc: " Joe Perches
2013-10-22 22:30 ` [PATCH 22/24] kernel: " Joe Perches
2013-10-22 22:30 ` [PATCH 23/24] mm: " Joe Perches
2013-10-22 22:30 ` Joe Perches
2013-10-22 22:30 ` [PATCH 24/24] security:keys: " Joe Perches
2013-10-22 23:53 ` [PATCH 00/24] treewide: " David Daney
2013-10-22 23:53 ` [Ocfs2-devel] " David Daney
2013-10-22 23:53 ` David Daney
2013-10-22 23:53 ` David Daney
2013-10-22 23:53 ` David Daney
2013-10-22 23:58 ` Joe Perches
2013-10-22 23:58 ` [Ocfs2-devel] " Joe Perches
2013-10-22 23:58 ` Joe Perches
2013-10-22 23:58 ` Joe Perches
2013-10-22 23:58 ` Joe Perches
2013-10-22 23:58 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107110645.GE24799@localhost \
--to=jlbec@evilplan.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.