All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] adjust BBPATH to be a good citizen of layer world
@ 2013-11-07  2:25 Khem Raj
  2013-11-07  4:29 ` Maupin, Chase
  2013-11-07 17:01 ` Denys Dmytriyenko
  0 siblings, 2 replies; 14+ messages in thread
From: Khem Raj @ 2013-11-07  2:25 UTC (permalink / raw)
  To: meta-ti

Currently, meta-ti appears as first path in BBPATH
rest of layers append so lets do the same

helps distros with multiple BSP layers to include meta-ti

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/layer.conf b/conf/layer.conf
index e39bd85..faa4ac0 100644
--- a/conf/layer.conf
+++ b/conf/layer.conf
@@ -1,5 +1,5 @@
 # We have a conf and classes directory, append to BBPATH
-BBPATH =. "${LAYERDIR}:"
+BBPATH .= ":${LAYERDIR}"
 
 # We have a recipes directory, add to BBFILES
 BBFILES += "${LAYERDIR}/recipes*/*/*.bb ${LAYERDIR}/recipes*/*/*.bbappend"
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07  2:25 [PATCH] adjust BBPATH to be a good citizen of layer world Khem Raj
@ 2013-11-07  4:29 ` Maupin, Chase
  2013-11-07  4:55   ` Khem Raj
  2013-11-07 17:01 ` Denys Dmytriyenko
  1 sibling, 1 reply; 14+ messages in thread
From: Maupin, Chase @ 2013-11-07  4:29 UTC (permalink / raw)
  To: Khem Raj, meta-ti@yoctoproject.org

This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217

Looks like there may be a need to cover the different use cases and understand what each person is trying to do :)

>-----Original Message-----
>From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>bounces@yoctoproject.org] On Behalf Of Khem Raj
>Sent: Thursday, November 07, 2013 7:55 AM
>To: meta-ti@yoctoproject.org
>Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
>layer world
>
>Currently, meta-ti appears as first path in BBPATH
>rest of layers append so lets do the same
>
>helps distros with multiple BSP layers to include meta-ti
>
>Signed-off-by: Khem Raj <raj.khem@gmail.com>
>---
> conf/layer.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/conf/layer.conf b/conf/layer.conf
>index e39bd85..faa4ac0 100644
>--- a/conf/layer.conf
>+++ b/conf/layer.conf
>@@ -1,5 +1,5 @@
> # We have a conf and classes directory, append to BBPATH
>-BBPATH =. "${LAYERDIR}:"
>+BBPATH .= ":${LAYERDIR}"
>
> # We have a recipes directory, add to BBFILES
> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
>${LAYERDIR}/recipes*/*/*.bbappend"
>--
>1.8.3.2
>
>_______________________________________________
>meta-ti mailing list
>meta-ti@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07  4:29 ` Maupin, Chase
@ 2013-11-07  4:55   ` Khem Raj
  2013-11-07 16:59     ` Denys Dmytriyenko
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2013-11-07  4:55 UTC (permalink / raw)
  To: Maupin, Chase; +Cc: meta-ti@yoctoproject.org

On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
>
> Looks like there may be a need to cover the different use cases and understand what each person is trying to do :)
>

ah I see what caused this all pain. So now meta-ti is odd ball out.
this patch should have never gone in.

>>-----Original Message-----
>>From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>>bounces@yoctoproject.org] On Behalf Of Khem Raj
>>Sent: Thursday, November 07, 2013 7:55 AM
>>To: meta-ti@yoctoproject.org
>>Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
>>layer world
>>
>>Currently, meta-ti appears as first path in BBPATH
>>rest of layers append so lets do the same
>>
>>helps distros with multiple BSP layers to include meta-ti
>>
>>Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>---
>> conf/layer.conf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/conf/layer.conf b/conf/layer.conf
>>index e39bd85..faa4ac0 100644
>>--- a/conf/layer.conf
>>+++ b/conf/layer.conf
>>@@ -1,5 +1,5 @@
>> # We have a conf and classes directory, append to BBPATH
>>-BBPATH =. "${LAYERDIR}:"
>>+BBPATH .= ":${LAYERDIR}"
>>
>> # We have a recipes directory, add to BBFILES
>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
>>${LAYERDIR}/recipes*/*/*.bbappend"
>>--
>>1.8.3.2
>>
>>_______________________________________________
>>meta-ti mailing list
>>meta-ti@yoctoproject.org
>>https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07  4:55   ` Khem Raj
@ 2013-11-07 16:59     ` Denys Dmytriyenko
  2013-11-07 17:15       ` Khem Raj
  0 siblings, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2013-11-07 16:59 UTC (permalink / raw)
  To: Khem Raj; +Cc: meta-ti@yoctoproject.org

On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
> > This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
> >
> > Looks like there may be a need to cover the different use cases and 
> > understand what each person is trying to do :)
> >
> 
> ah I see what caused this all pain. So now meta-ti is odd ball out.
> this patch should have never gone in.

Khem,

If you remember, we discussed this with Richard and he suggested this as a 
solution to the ordering problem. Otherwise people tend to append any extra 
layers _after_ oe-core, which should be the other way around in order to 
override anything in there...

-- 
Denys


> >>-----Original Message-----
> >>From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> >>bounces@yoctoproject.org] On Behalf Of Khem Raj
> >>Sent: Thursday, November 07, 2013 7:55 AM
> >>To: meta-ti@yoctoproject.org
> >>Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
> >>layer world
> >>
> >>Currently, meta-ti appears as first path in BBPATH
> >>rest of layers append so lets do the same
> >>
> >>helps distros with multiple BSP layers to include meta-ti
> >>
> >>Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>---
> >> conf/layer.conf | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/conf/layer.conf b/conf/layer.conf
> >>index e39bd85..faa4ac0 100644
> >>--- a/conf/layer.conf
> >>+++ b/conf/layer.conf
> >>@@ -1,5 +1,5 @@
> >> # We have a conf and classes directory, append to BBPATH
> >>-BBPATH =. "${LAYERDIR}:"
> >>+BBPATH .= ":${LAYERDIR}"
> >>
> >> # We have a recipes directory, add to BBFILES
> >> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
> >>${LAYERDIR}/recipes*/*/*.bbappend"
> >>--
> >>1.8.3.2
> >>
> >>_______________________________________________
> >>meta-ti mailing list
> >>meta-ti@yoctoproject.org
> >>https://lists.yoctoproject.org/listinfo/meta-ti
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07  2:25 [PATCH] adjust BBPATH to be a good citizen of layer world Khem Raj
  2013-11-07  4:29 ` Maupin, Chase
@ 2013-11-07 17:01 ` Denys Dmytriyenko
  2013-11-07 17:33   ` Khem Raj
  1 sibling, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2013-11-07 17:01 UTC (permalink / raw)
  To: Khem Raj; +Cc: meta-ti

NAK for now, as there was a chance to comment on the proposed change:

http://thread.gmane.org/gmane.linux.embedded.yocto.meta-ti/2939

On Wed, Nov 06, 2013 at 06:25:26PM -0800, Khem Raj wrote:
> Currently, meta-ti appears as first path in BBPATH
> rest of layers append so lets do the same
> 
> helps distros with multiple BSP layers to include meta-ti
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  conf/layer.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/layer.conf b/conf/layer.conf
> index e39bd85..faa4ac0 100644
> --- a/conf/layer.conf
> +++ b/conf/layer.conf
> @@ -1,5 +1,5 @@
>  # We have a conf and classes directory, append to BBPATH
> -BBPATH =. "${LAYERDIR}:"
> +BBPATH .= ":${LAYERDIR}"
>  
>  # We have a recipes directory, add to BBFILES
>  BBFILES += "${LAYERDIR}/recipes*/*/*.bb ${LAYERDIR}/recipes*/*/*.bbappend"
> -- 
> 1.8.3.2
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 16:59     ` Denys Dmytriyenko
@ 2013-11-07 17:15       ` Khem Raj
  2013-11-07 17:37         ` Denys Dmytriyenko
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2013-11-07 17:15 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org


On Nov 7, 2013, at 8:59 AM, Denys Dmytriyenko <denys@ti.com> wrote:

> On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
>> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
>>> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
>>> 
>>> Looks like there may be a need to cover the different use cases and 
>>> understand what each person is trying to do :)
>>> 
>> 
>> ah I see what caused this all pain. So now meta-ti is odd ball out.
>> this patch should have never gone in.
> 
> Khem,
> 
> If you remember, we discussed this with Richard and he suggested this as a 
> solution to the ordering problem. Otherwise people tend to append any extra 
> layers _after_ oe-core, which should be the other way around in order to 
> override anything in there…

I think the problem is when you have many other layers then the whole paradigm changes to it
and you end up with same issue upside down. I think how you order bblayer.conf can control the override of
oe-core, I wish if distro’s could control the layer.conf for each bsp layer then it wouldnt matter as much


> 
> -- 
> Denys
> 
> 
>>>> -----Original Message-----
>>>> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
>>>> bounces@yoctoproject.org] On Behalf Of Khem Raj
>>>> Sent: Thursday, November 07, 2013 7:55 AM
>>>> To: meta-ti@yoctoproject.org
>>>> Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
>>>> layer world
>>>> 
>>>> Currently, meta-ti appears as first path in BBPATH
>>>> rest of layers append so lets do the same
>>>> 
>>>> helps distros with multiple BSP layers to include meta-ti
>>>> 
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> conf/layer.conf | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> diff --git a/conf/layer.conf b/conf/layer.conf
>>>> index e39bd85..faa4ac0 100644
>>>> --- a/conf/layer.conf
>>>> +++ b/conf/layer.conf
>>>> @@ -1,5 +1,5 @@
>>>> # We have a conf and classes directory, append to BBPATH
>>>> -BBPATH =. "${LAYERDIR}:"
>>>> +BBPATH .= ":${LAYERDIR}"
>>>> 
>>>> # We have a recipes directory, add to BBFILES
>>>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
>>>> ${LAYERDIR}/recipes*/*/*.bbappend"
>>>> --
>>>> 1.8.3.2
>>>> 
>>>> _______________________________________________
>>>> meta-ti mailing list
>>>> meta-ti@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/meta-ti
>> _______________________________________________
>> meta-ti mailing list
>> meta-ti@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-ti



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 17:01 ` Denys Dmytriyenko
@ 2013-11-07 17:33   ` Khem Raj
  2013-11-07 17:41     ` Denys Dmytriyenko
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2013-11-07 17:33 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-ti


On Nov 7, 2013, at 9:01 AM, Denys Dmytriyenko <denys@ti.com> wrote:

> NAK for now, as there was a chance to comment on the proposed change:

well. I did not try, that change however its not that its set in stone either.
now meta-ti appears appears first no matter what in angstrom
in BBPATH and shadows meta-beagleboard which also provides definitions for beaglebone.conf
which I want to use and no matter what I try unless I start changing the other layers to prepend
as well I do not get the right order. I can happily punt out meta-ti or fork it but thats not the solution
I am looking for.



> 
> http://thread.gmane.org/gmane.linux.embedded.yocto.meta-ti/2939
> 
> On Wed, Nov 06, 2013 at 06:25:26PM -0800, Khem Raj wrote:
>> Currently, meta-ti appears as first path in BBPATH
>> rest of layers append so lets do the same
>> 
>> helps distros with multiple BSP layers to include meta-ti
>> 
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> conf/layer.conf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/conf/layer.conf b/conf/layer.conf
>> index e39bd85..faa4ac0 100644
>> --- a/conf/layer.conf
>> +++ b/conf/layer.conf
>> @@ -1,5 +1,5 @@
>> # We have a conf and classes directory, append to BBPATH
>> -BBPATH =. "${LAYERDIR}:"
>> +BBPATH .= ":${LAYERDIR}"
>> 
>> # We have a recipes directory, add to BBFILES
>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb ${LAYERDIR}/recipes*/*/*.bbappend"
>> -- 
>> 1.8.3.2
>> 
>> _______________________________________________
>> meta-ti mailing list
>> meta-ti@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-ti



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 17:15       ` Khem Raj
@ 2013-11-07 17:37         ` Denys Dmytriyenko
  2013-11-07 17:42           ` Khem Raj
  0 siblings, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2013-11-07 17:37 UTC (permalink / raw)
  To: Khem Raj; +Cc: meta-ti@yoctoproject.org

On Thu, Nov 07, 2013 at 09:15:40AM -0800, Khem Raj wrote:
> 
> On Nov 7, 2013, at 8:59 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> 
> > On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
> >> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
> >>> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
> >>> 
> >>> Looks like there may be a need to cover the different use cases and 
> >>> understand what each person is trying to do :)
> >>> 
> >> 
> >> ah I see what caused this all pain. So now meta-ti is odd ball out.
> >> this patch should have never gone in.
> > 
> > Khem,
> > 
> > If you remember, we discussed this with Richard and he suggested this as a 
> > solution to the ordering problem. Otherwise people tend to append any extra 
> > layers _after_ oe-core, which should be the other way around in order to 
> > override anything in there…
> 
> I think the problem is when you have many other layers then the whole 
> paradigm changes to it and you end up with same issue upside down. I think 
> how you order bblayer.conf can control the override of oe-core, I wish if 
> distro’s could control the layer.conf for each bsp layer then it wouldnt 
> matter as much

I agree this is a bigger issue. I looked at some layers and found few that 
prepend themselves, while most of others just append.

The order inside bblayers.conf is much more important than people let to 
believe. For example, if multiple layers define the machine config, the first 
one listed in bblayers.conf wins - this is a real problem for beagleboard.conf 
that is currently being defined in meta-ti as well as meta-yocto-bsp (as a 
reference platform) and meta-beagleboard too. Very soon the same problem will 
happen to beaglebone.conf, when meta-yocto-bsp picks it up as a reference...

Anyway, the biggest issue I'm trying to work around with this change is the 
"shadowing" of the new-style DTBs that I ported from Dora to Dylan. If meta-ti 
is not in front of oe-core, the old-style DTBs come into play and DTBs are not 
built at all. So, this is not really an issue for Dora or master, and those 
don't need to be prepended after all...


> >>>> -----Original Message-----
> >>>> From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> >>>> bounces@yoctoproject.org] On Behalf Of Khem Raj
> >>>> Sent: Thursday, November 07, 2013 7:55 AM
> >>>> To: meta-ti@yoctoproject.org
> >>>> Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
> >>>> layer world
> >>>> 
> >>>> Currently, meta-ti appears as first path in BBPATH
> >>>> rest of layers append so lets do the same
> >>>> 
> >>>> helps distros with multiple BSP layers to include meta-ti
> >>>> 
> >>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>>> ---
> >>>> conf/layer.conf | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>> 
> >>>> diff --git a/conf/layer.conf b/conf/layer.conf
> >>>> index e39bd85..faa4ac0 100644
> >>>> --- a/conf/layer.conf
> >>>> +++ b/conf/layer.conf
> >>>> @@ -1,5 +1,5 @@
> >>>> # We have a conf and classes directory, append to BBPATH
> >>>> -BBPATH =. "${LAYERDIR}:"
> >>>> +BBPATH .= ":${LAYERDIR}"
> >>>> 
> >>>> # We have a recipes directory, add to BBFILES
> >>>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
> >>>> ${LAYERDIR}/recipes*/*/*.bbappend"
> >>>> --
> >>>> 1.8.3.2
> >>>> 
> >>>> _______________________________________________
> >>>> meta-ti mailing list
> >>>> meta-ti@yoctoproject.org
> >>>> https://lists.yoctoproject.org/listinfo/meta-ti
> >> _______________________________________________
> >> meta-ti mailing list
> >> meta-ti@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-ti
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 17:33   ` Khem Raj
@ 2013-11-07 17:41     ` Denys Dmytriyenko
  0 siblings, 0 replies; 14+ messages in thread
From: Denys Dmytriyenko @ 2013-11-07 17:41 UTC (permalink / raw)
  To: Khem Raj; +Cc: meta-ti

On Thu, Nov 07, 2013 at 09:33:33AM -0800, Khem Raj wrote:
> 
> On Nov 7, 2013, at 9:01 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> 
> > NAK for now, as there was a chance to comment on the proposed change:
> 
> well. I did not try, that change however its not that its set in stone 
> either. now meta-ti appears appears first no matter what in angstrom in 
> BBPATH and shadows meta-beagleboard which also provides definitions for 
> beaglebone.conf which I want to use and no matter what I try unless I start 
> changing the other layers to prepend as well I do not get the right order. I 
> can happily punt out meta-ti or fork it but thats not the solution I am 
> looking for.

Indeed - one of the problems I just described in the other reply to this 
thread.

Anyway, what really bothers me, is that you, me and Richard had this exact 
discussion at ELCE and agreed that prepending should solve the issue... :)


> > http://thread.gmane.org/gmane.linux.embedded.yocto.meta-ti/2939
> > 
> > On Wed, Nov 06, 2013 at 06:25:26PM -0800, Khem Raj wrote:
> >> Currently, meta-ti appears as first path in BBPATH
> >> rest of layers append so lets do the same
> >> 
> >> helps distros with multiple BSP layers to include meta-ti
> >> 
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >> conf/layer.conf | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/conf/layer.conf b/conf/layer.conf
> >> index e39bd85..faa4ac0 100644
> >> --- a/conf/layer.conf
> >> +++ b/conf/layer.conf
> >> @@ -1,5 +1,5 @@
> >> # We have a conf and classes directory, append to BBPATH
> >> -BBPATH =. "${LAYERDIR}:"
> >> +BBPATH .= ":${LAYERDIR}"
> >> 
> >> # We have a recipes directory, add to BBFILES
> >> BBFILES += "${LAYERDIR}/recipes*/*/*.bb ${LAYERDIR}/recipes*/*/*.bbappend"
> >> -- 
> >> 1.8.3.2
> >> 
> >> _______________________________________________
> >> meta-ti mailing list
> >> meta-ti@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-ti
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 17:37         ` Denys Dmytriyenko
@ 2013-11-07 17:42           ` Khem Raj
  2013-11-07 17:47             ` Denys Dmytriyenko
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2013-11-07 17:42 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org


On Nov 7, 2013, at 9:37 AM, Denys Dmytriyenko <denys@ti.com> wrote:

> On Thu, Nov 07, 2013 at 09:15:40AM -0800, Khem Raj wrote:
>> 
>> On Nov 7, 2013, at 8:59 AM, Denys Dmytriyenko <denys@ti.com> wrote:
>> 
>>> On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
>>>> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
>>>>> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
>>>>> 
>>>>> Looks like there may be a need to cover the different use cases and 
>>>>> understand what each person is trying to do :)
>>>>> 
>>>> 
>>>> ah I see what caused this all pain. So now meta-ti is odd ball out.
>>>> this patch should have never gone in.
>>> 
>>> Khem,
>>> 
>>> If you remember, we discussed this with Richard and he suggested this as a 
>>> solution to the ordering problem. Otherwise people tend to append any extra 
>>> layers _after_ oe-core, which should be the other way around in order to 
>>> override anything in there…
>> 
>> I think the problem is when you have many other layers then the whole 
>> paradigm changes to it and you end up with same issue upside down. I think 
>> how you order bblayer.conf can control the override of oe-core, I wish if 
>> distro’s could control the layer.conf for each bsp layer then it wouldnt 
>> matter as much
> 
> I agree this is a bigger issue. I looked at some layers and found few that 
> prepend themselves, while most of others just append.
> 
> The order inside bblayers.conf is much more important than people let to 
> believe. For example, if multiple layers define the machine config, the first 
> one listed in bblayers.conf wins - this is a real problem for beagleboard.conf 
> that is currently being defined in meta-ti as well as meta-yocto-bsp (as a 
> reference platform) and meta-beagleboard too. Very soon the same problem will 
> happen to beaglebone.conf, when meta-yocto-bsp picks it up as a reference...
> 
> Anyway, the biggest issue I'm trying to work around with this change is the 
> "shadowing" of the new-style DTBs that I ported from Dora to Dylan. If meta-ti 
> is not in front of oe-core, the old-style DTBs come into play and DTBs are not 
> built at all. So, this is not really an issue for Dora or master, and those 
> don't need to be prepended after all…


Now its even more intriguing since you changed meta-ti/master and I would have expected this change to
show up in meta-ti/dylan or are you claiming all sort of oe-core branches to work with meta-ti/master
thats a perilous path.

> 
> 
>>>>>> -----Original Message-----
>>>>>> From: meta-ti-bounces@yoctoproject.org[mailto:meta-ti-
>>>>>> bounces@yoctoproject.org] On Behalf Of Khem Raj
>>>>>> Sent: Thursday, November 07, 2013 7:55 AM
>>>>>> To: meta-ti@yoctoproject.org
>>>>>> Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
>>>>>> layer world
>>>>>> 
>>>>>> Currently, meta-ti appears as first path in BBPATH
>>>>>> rest of layers append so lets do the same
>>>>>> 
>>>>>> helps distros with multiple BSP layers to include meta-ti
>>>>>> 
>>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>>>> ---
>>>>>> conf/layer.conf | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>> 
>>>>>> diff --git a/conf/layer.conf b/conf/layer.conf
>>>>>> index e39bd85..faa4ac0 100644
>>>>>> --- a/conf/layer.conf
>>>>>> +++ b/conf/layer.conf
>>>>>> @@ -1,5 +1,5 @@
>>>>>> # We have a conf and classes directory, append to BBPATH
>>>>>> -BBPATH =. "${LAYERDIR}:"
>>>>>> +BBPATH .= ":${LAYERDIR}"
>>>>>> 
>>>>>> # We have a recipes directory, add to BBFILES
>>>>>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
>>>>>> ${LAYERDIR}/recipes*/*/*.bbappend"
>>>>>> --
>>>>>> 1.8.3.2
>>>>>> 
>>>>>> _______________________________________________
>>>>>> meta-ti mailing list
>>>>>> meta-ti@yoctoproject.org
>>>>>> https://lists.yoctoproject.org/listinfo/meta-ti
>>>> _______________________________________________
>>>> meta-ti mailing list
>>>> meta-ti@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/meta-ti



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 17:42           ` Khem Raj
@ 2013-11-07 17:47             ` Denys Dmytriyenko
  2013-11-07 17:57               ` Khem Raj
  0 siblings, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2013-11-07 17:47 UTC (permalink / raw)
  To: Khem Raj; +Cc: meta-ti@yoctoproject.org

On Thu, Nov 07, 2013 at 09:42:50AM -0800, Khem Raj wrote:
> 
> On Nov 7, 2013, at 9:37 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> 
> > On Thu, Nov 07, 2013 at 09:15:40AM -0800, Khem Raj wrote:
> >> 
> >> On Nov 7, 2013, at 8:59 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> >> 
> >>> On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
> >>>> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
> >>>>> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
> >>>>> 
> >>>>> Looks like there may be a need to cover the different use cases and 
> >>>>> understand what each person is trying to do :)
> >>>>> 
> >>>> 
> >>>> ah I see what caused this all pain. So now meta-ti is odd ball out.
> >>>> this patch should have never gone in.
> >>> 
> >>> Khem,
> >>> 
> >>> If you remember, we discussed this with Richard and he suggested this as a 
> >>> solution to the ordering problem. Otherwise people tend to append any extra 
> >>> layers _after_ oe-core, which should be the other way around in order to 
> >>> override anything in there…
> >> 
> >> I think the problem is when you have many other layers then the whole 
> >> paradigm changes to it and you end up with same issue upside down. I think 
> >> how you order bblayer.conf can control the override of oe-core, I wish if 
> >> distro’s could control the layer.conf for each bsp layer then it wouldnt 
> >> matter as much
> > 
> > I agree this is a bigger issue. I looked at some layers and found few that 
> > prepend themselves, while most of others just append.
> > 
> > The order inside bblayers.conf is much more important than people let to 
> > believe. For example, if multiple layers define the machine config, the first 
> > one listed in bblayers.conf wins - this is a real problem for beagleboard.conf 
> > that is currently being defined in meta-ti as well as meta-yocto-bsp (as a 
> > reference platform) and meta-beagleboard too. Very soon the same problem will 
> > happen to beaglebone.conf, when meta-yocto-bsp picks it up as a reference...
> > 
> > Anyway, the biggest issue I'm trying to work around with this change is the 
> > "shadowing" of the new-style DTBs that I ported from Dora to Dylan. If meta-ti 
> > is not in front of oe-core, the old-style DTBs come into play and DTBs are not 
> > built at all. So, this is not really an issue for Dora or master, and those 
> > don't need to be prepended after all…
> 
> 
> Now its even more intriguing since you changed meta-ti/master and I would 
> have expected this change to show up in meta-ti/dylan or are you claiming 
> all sort of oe-core branches to work with meta-ti/master thats a perilous 
> path.

It's in meta-ti/dylan AND meta-ti/master, as I thought the change was 
rather safe. But what I'm saying now is that it's not really needed in 
meta-ti/master, only dylan.

As of meta-ti/master, it should work with oe-core/master and maybe dora, but 
probably it's time to branch of meta-ti/dora, since there were some changes in 
oe-core/master no longer compatible with dora...


> >>>>>> -----Original Message-----
> >>>>>> From: meta-ti-bounces@yoctoproject.org[mailto:meta-ti-
> >>>>>> bounces@yoctoproject.org] On Behalf Of Khem Raj
> >>>>>> Sent: Thursday, November 07, 2013 7:55 AM
> >>>>>> To: meta-ti@yoctoproject.org
> >>>>>> Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
> >>>>>> layer world
> >>>>>> 
> >>>>>> Currently, meta-ti appears as first path in BBPATH
> >>>>>> rest of layers append so lets do the same
> >>>>>> 
> >>>>>> helps distros with multiple BSP layers to include meta-ti
> >>>>>> 
> >>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>>>>> ---
> >>>>>> conf/layer.conf | 2 +-
> >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>> 
> >>>>>> diff --git a/conf/layer.conf b/conf/layer.conf
> >>>>>> index e39bd85..faa4ac0 100644
> >>>>>> --- a/conf/layer.conf
> >>>>>> +++ b/conf/layer.conf
> >>>>>> @@ -1,5 +1,5 @@
> >>>>>> # We have a conf and classes directory, append to BBPATH
> >>>>>> -BBPATH =. "${LAYERDIR}:"
> >>>>>> +BBPATH .= ":${LAYERDIR}"
> >>>>>> 
> >>>>>> # We have a recipes directory, add to BBFILES
> >>>>>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
> >>>>>> ${LAYERDIR}/recipes*/*/*.bbappend"
> >>>>>> --
> >>>>>> 1.8.3.2
> >>>>>> 
> >>>>>> _______________________________________________
> >>>>>> meta-ti mailing list
> >>>>>> meta-ti@yoctoproject.org
> >>>>>> https://lists.yoctoproject.org/listinfo/meta-ti
> >>>> _______________________________________________
> >>>> meta-ti mailing list
> >>>> meta-ti@yoctoproject.org
> >>>> https://lists.yoctoproject.org/listinfo/meta-ti
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 17:47             ` Denys Dmytriyenko
@ 2013-11-07 17:57               ` Khem Raj
  2013-11-07 18:20                 ` Denys Dmytriyenko
  0 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2013-11-07 17:57 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org


On Nov 7, 2013, at 9:47 AM, Denys Dmytriyenko <denys@ti.com> wrote:

> On Thu, Nov 07, 2013 at 09:42:50AM -0800, Khem Raj wrote:
>> 
>> On Nov 7, 2013, at 9:37 AM, Denys Dmytriyenko <denys@ti.com> wrote:
>> 
>>> On Thu, Nov 07, 2013 at 09:15:40AM -0800, Khem Raj wrote:
>>>> 
>>>> On Nov 7, 2013, at 8:59 AM, Denys Dmytriyenko <denys@ti.com> wrote:
>>>> 
>>>>> On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
>>>>>> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
>>>>>>> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
>>>>>>> 
>>>>>>> Looks like there may be a need to cover the different use cases and 
>>>>>>> understand what each person is trying to do :)
>>>>>>> 
>>>>>> 
>>>>>> ah I see what caused this all pain. So now meta-ti is odd ball out.
>>>>>> this patch should have never gone in.
>>>>> 
>>>>> Khem,
>>>>> 
>>>>> If you remember, we discussed this with Richard and he suggested this as a 
>>>>> solution to the ordering problem. Otherwise people tend to append any extra 
>>>>> layers _after_ oe-core, which should be the other way around in order to 
>>>>> override anything in there…
>>>> 
>>>> I think the problem is when you have many other layers then the whole 
>>>> paradigm changes to it and you end up with same issue upside down. I think 
>>>> how you order bblayer.conf can control the override of oe-core, I wish if 
>>>> distro’s could control the layer.conf for each bsp layer then it wouldnt 
>>>> matter as much
>>> 
>>> I agree this is a bigger issue. I looked at some layers and found few that 
>>> prepend themselves, while most of others just append.
>>> 
>>> The order inside bblayers.conf is much more important than people let to 
>>> believe. For example, if multiple layers define the machine config, the first 
>>> one listed in bblayers.conf wins - this is a real problem for beagleboard.conf 
>>> that is currently being defined in meta-ti as well as meta-yocto-bsp (as a 
>>> reference platform) and meta-beagleboard too. Very soon the same problem will 
>>> happen to beaglebone.conf, when meta-yocto-bsp picks it up as a reference...
>>> 
>>> Anyway, the biggest issue I'm trying to work around with this change is the 
>>> "shadowing" of the new-style DTBs that I ported from Dora to Dylan. If meta-ti 
>>> is not in front of oe-core, the old-style DTBs come into play and DTBs are not 
>>> built at all. So, this is not really an issue for Dora or master, and those 
>>> don't need to be prepended after all…
>> 
>> 
>> Now its even more intriguing since you changed meta-ti/master and I would 
>> have expected this change to show up in meta-ti/dylan or are you claiming 
>> all sort of oe-core branches to work with meta-ti/master thats a perilous 
>> path.
> 
> It's in meta-ti/dylan AND meta-ti/master,

yes. So can we change the master please ?
oe-core is also appending itself in BBPATH in oe-core/master and so are meta-yocto-bsp
and meta-beagleboard so with mere ordering of these layers in your distro’s bblayer.conf
you should be able to get desired behaviour.

> as I thought the change was 
> rather safe. But what I'm saying now is that it's not really needed in 
> meta-ti/master, only dylan.
> 
> As of meta-ti/master, it should work with oe-core/master and maybe dora, but 
> probably it's time to branch of meta-ti/dora, since there were some changes in 
> oe-core/master no longer compatible with dora…

sure yes but have that commit before you branch out.

> 
> 
>>>>>>>> -----Original Message-----
>>>>>>>> From: meta-ti-bounces@yoctoproject.org[mailto:meta-ti-
>>>>>>>> bounces@yoctoproject.org] On Behalf Of Khem Raj
>>>>>>>> Sent: Thursday, November 07, 2013 7:55 AM
>>>>>>>> To: meta-ti@yoctoproject.org
>>>>>>>> Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
>>>>>>>> layer world
>>>>>>>> 
>>>>>>>> Currently, meta-ti appears as first path in BBPATH
>>>>>>>> rest of layers append so lets do the same
>>>>>>>> 
>>>>>>>> helps distros with multiple BSP layers to include meta-ti
>>>>>>>> 
>>>>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>>>>>> ---
>>>>>>>> conf/layer.conf | 2 +-
>>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>> 
>>>>>>>> diff --git a/conf/layer.conf b/conf/layer.conf
>>>>>>>> index e39bd85..faa4ac0 100644
>>>>>>>> --- a/conf/layer.conf
>>>>>>>> +++ b/conf/layer.conf
>>>>>>>> @@ -1,5 +1,5 @@
>>>>>>>> # We have a conf and classes directory, append to BBPATH
>>>>>>>> -BBPATH =. "${LAYERDIR}:"
>>>>>>>> +BBPATH .= ":${LAYERDIR}"
>>>>>>>> 
>>>>>>>> # We have a recipes directory, add to BBFILES
>>>>>>>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
>>>>>>>> ${LAYERDIR}/recipes*/*/*.bbappend"
>>>>>>>> --
>>>>>>>> 1.8.3.2
>>>>>>>> 
>>>>>>>> _______________________________________________
>>>>>>>> meta-ti mailing list
>>>>>>>> meta-ti@yoctoproject.org
>>>>>>>> https://lists.yoctoproject.org/listinfo/meta-ti
>>>>>> _______________________________________________
>>>>>> meta-ti mailing list
>>>>>> meta-ti@yoctoproject.org
>>>>>> https://lists.yoctoproject.org/listinfo/meta-ti



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 17:57               ` Khem Raj
@ 2013-11-07 18:20                 ` Denys Dmytriyenko
  2013-11-07 18:41                   ` Khem Raj
  0 siblings, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2013-11-07 18:20 UTC (permalink / raw)
  To: Khem Raj; +Cc: meta-ti@yoctoproject.org

On Thu, Nov 07, 2013 at 09:57:09AM -0800, Khem Raj wrote:
> 
> On Nov 7, 2013, at 9:47 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> 
> > On Thu, Nov 07, 2013 at 09:42:50AM -0800, Khem Raj wrote:
> >> 
> >> On Nov 7, 2013, at 9:37 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> >> 
> >>> On Thu, Nov 07, 2013 at 09:15:40AM -0800, Khem Raj wrote:
> >>>> 
> >>>> On Nov 7, 2013, at 8:59 AM, Denys Dmytriyenko <denys@ti.com> wrote:
> >>>> 
> >>>>> On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
> >>>>>> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
> >>>>>>> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
> >>>>>>> 
> >>>>>>> Looks like there may be a need to cover the different use cases and 
> >>>>>>> understand what each person is trying to do :)
> >>>>>>> 
> >>>>>> 
> >>>>>> ah I see what caused this all pain. So now meta-ti is odd ball out.
> >>>>>> this patch should have never gone in.
> >>>>> 
> >>>>> Khem,
> >>>>> 
> >>>>> If you remember, we discussed this with Richard and he suggested this as a 
> >>>>> solution to the ordering problem. Otherwise people tend to append any extra 
> >>>>> layers _after_ oe-core, which should be the other way around in order to 
> >>>>> override anything in there…
> >>>> 
> >>>> I think the problem is when you have many other layers then the whole 
> >>>> paradigm changes to it and you end up with same issue upside down. I think 
> >>>> how you order bblayer.conf can control the override of oe-core, I wish if 
> >>>> distro’s could control the layer.conf for each bsp layer then it wouldnt 
> >>>> matter as much
> >>> 
> >>> I agree this is a bigger issue. I looked at some layers and found few that 
> >>> prepend themselves, while most of others just append.
> >>> 
> >>> The order inside bblayers.conf is much more important than people let to 
> >>> believe. For example, if multiple layers define the machine config, the first 
> >>> one listed in bblayers.conf wins - this is a real problem for beagleboard.conf 
> >>> that is currently being defined in meta-ti as well as meta-yocto-bsp (as a 
> >>> reference platform) and meta-beagleboard too. Very soon the same problem will 
> >>> happen to beaglebone.conf, when meta-yocto-bsp picks it up as a reference...
> >>> 
> >>> Anyway, the biggest issue I'm trying to work around with this change is the 
> >>> "shadowing" of the new-style DTBs that I ported from Dora to Dylan. If meta-ti 
> >>> is not in front of oe-core, the old-style DTBs come into play and DTBs are not 
> >>> built at all. So, this is not really an issue for Dora or master, and those 
> >>> don't need to be prepended after all…
> >> 
> >> 
> >> Now its even more intriguing since you changed meta-ti/master and I would 
> >> have expected this change to show up in meta-ti/dylan or are you claiming 
> >> all sort of oe-core branches to work with meta-ti/master thats a perilous 
> >> path.
> > 
> > It's in meta-ti/dylan AND meta-ti/master,
> 
> yes. So can we change the master please ?

I'll think about it ;)


> oe-core is also appending itself in BBPATH in oe-core/master

Yes, I know.


> and so are meta-yocto-bsp and meta-beagleboard 

Also quite aware of that.

But since you mention meta-yocto-bsp, which is part of Poky, do you know that 
meta-yocto prepends itself in front? And I believe there were one or two more 
obscure layers doing that as well...

BTW, I like the comment you made in meta-oe long time ago:

# It really depends on order of the layers appearing in BBLAYERS
# variable in toplevel bblayers.conf file, where bitbake will search
# for .inc files and others where bitbake uses BBPATH since it will
# search the directories from first to last as specified in BBPATH
# Therefore if you want a given layer to be considered high priority
# for the .inc and .conf etc. then consider it adding at the beginning
# of BBPATH. For bblayers bitbake will use BBFILES_PRIORITY to resolve
# the recipe contention so the order of directories in BBFILES does 
# not matter.

But the problem is that people don't read comments and don't bother with 
BBLAYERS order, hence I had to do what you suggested above with BBPATH order 
instead!


> so with mere ordering of these layers in your distro’s bblayer.conf you 
> should be able to get desired behaviour.

Well, it's not really a problem for Arago or Angstrom, as both provide setup 
tools to generate the correct bblayers.conf with the proper order of BBLAYERS. 
But the problem is really with Poky, as it expects people to manually add 
extra layers to bblayers.conf and people just tend to append everything AFTER 
oe-core and meta-yocto and meta-yocto-bsp. So, it's really Poky that is broken 
or rather unclear...


> > as I thought the change was 
> > rather safe. But what I'm saying now is that it's not really needed in 
> > meta-ti/master, only dylan.
> > 
> > As of meta-ti/master, it should work with oe-core/master and maybe dora, but 
> > probably it's time to branch of meta-ti/dora, since there were some changes in 
> > oe-core/master no longer compatible with dora…
> 
> sure yes but have that commit before you branch out.
> 
> > 
> > 
> >>>>>>>> -----Original Message-----
> >>>>>>>> From: meta-ti-bounces@yoctoproject.org[mailto:meta-ti-
> >>>>>>>> bounces@yoctoproject.org] On Behalf Of Khem Raj
> >>>>>>>> Sent: Thursday, November 07, 2013 7:55 AM
> >>>>>>>> To: meta-ti@yoctoproject.org
> >>>>>>>> Subject: [meta-ti] [PATCH] adjust BBPATH to be a good citizen of
> >>>>>>>> layer world
> >>>>>>>> 
> >>>>>>>> Currently, meta-ti appears as first path in BBPATH
> >>>>>>>> rest of layers append so lets do the same
> >>>>>>>> 
> >>>>>>>> helps distros with multiple BSP layers to include meta-ti
> >>>>>>>> 
> >>>>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>>>>>>> ---
> >>>>>>>> conf/layer.conf | 2 +-
> >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>>>> 
> >>>>>>>> diff --git a/conf/layer.conf b/conf/layer.conf
> >>>>>>>> index e39bd85..faa4ac0 100644
> >>>>>>>> --- a/conf/layer.conf
> >>>>>>>> +++ b/conf/layer.conf
> >>>>>>>> @@ -1,5 +1,5 @@
> >>>>>>>> # We have a conf and classes directory, append to BBPATH
> >>>>>>>> -BBPATH =. "${LAYERDIR}:"
> >>>>>>>> +BBPATH .= ":${LAYERDIR}"
> >>>>>>>> 
> >>>>>>>> # We have a recipes directory, add to BBFILES
> >>>>>>>> BBFILES += "${LAYERDIR}/recipes*/*/*.bb
> >>>>>>>> ${LAYERDIR}/recipes*/*/*.bbappend"
> >>>>>>>> --
> >>>>>>>> 1.8.3.2
> >>>>>>>> 
> >>>>>>>> _______________________________________________
> >>>>>>>> meta-ti mailing list
> >>>>>>>> meta-ti@yoctoproject.org
> >>>>>>>> https://lists.yoctoproject.org/listinfo/meta-ti
> >>>>>> _______________________________________________
> >>>>>> meta-ti mailing list
> >>>>>> meta-ti@yoctoproject.org
> >>>>>> https://lists.yoctoproject.org/listinfo/meta-ti
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] adjust BBPATH to be a good citizen of layer world
  2013-11-07 18:20                 ` Denys Dmytriyenko
@ 2013-11-07 18:41                   ` Khem Raj
  0 siblings, 0 replies; 14+ messages in thread
From: Khem Raj @ 2013-11-07 18:41 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org


On Nov 7, 2013, at 10:20 AM, Denys Dmytriyenko <denys@ti.com> wrote:

> On Thu, Nov 07, 2013 at 09:57:09AM -0800, Khem Raj wrote:
>> 
>> On Nov 7, 2013, at 9:47 AM, Denys Dmytriyenko <denys@ti.com> wrote:
>> 
>>> On Thu, Nov 07, 2013 at 09:42:50AM -0800, Khem Raj wrote:
>>>> 
>>>> On Nov 7, 2013, at 9:37 AM, Denys Dmytriyenko <denys@ti.com> wrote:
>>>> 
>>>>> On Thu, Nov 07, 2013 at 09:15:40AM -0800, Khem Raj wrote:
>>>>>> 
>>>>>> On Nov 7, 2013, at 8:59 AM, Denys Dmytriyenko <denys@ti.com> wrote:
>>>>>> 
>>>>>>> On Wed, Nov 06, 2013 at 08:55:55PM -0800, Khem Raj wrote:
>>>>>>>> On Wed, Nov 6, 2013 at 8:29 PM, Maupin, Chase <chase.maupin@ti.com> wrote:
>>>>>>>>> This seems like a reversal of http://arago-project.org/git/meta-ti.git?a=commit;h=dabd83e96fe99d0c3d1a88be4d1637831526d217
>>>>>>>>> 
>>>>>>>>> Looks like there may be a need to cover the different use cases and 
>>>>>>>>> understand what each person is trying to do :)
>>>>>>>>> 
>>>>>>>> 
>>>>>>>> ah I see what caused this all pain. So now meta-ti is odd ball out.
>>>>>>>> this patch should have never gone in.
>>>>>>> 
>>>>>>> Khem,
>>>>>>> 
>>>>>>> If you remember, we discussed this with Richard and he suggested this as a 
>>>>>>> solution to the ordering problem. Otherwise people tend to append any extra 
>>>>>>> layers _after_ oe-core, which should be the other way around in order to 
>>>>>>> override anything in there…
>>>>>> 
>>>>>> I think the problem is when you have many other layers then the whole 
>>>>>> paradigm changes to it and you end up with same issue upside down. I think 
>>>>>> how you order bblayer.conf can control the override of oe-core, I wish if 
>>>>>> distro’s could control the layer.conf for each bsp layer then it wouldnt 
>>>>>> matter as much
>>>>> 
>>>>> I agree this is a bigger issue. I looked at some layers and found few that 
>>>>> prepend themselves, while most of others just append.
>>>>> 
>>>>> The order inside bblayers.conf is much more important than people let to 
>>>>> believe. For example, if multiple layers define the machine config, the first 
>>>>> one listed in bblayers.conf wins - this is a real problem for beagleboard.conf 
>>>>> that is currently being defined in meta-ti as well as meta-yocto-bsp (as a 
>>>>> reference platform) and meta-beagleboard too. Very soon the same problem will 
>>>>> happen to beaglebone.conf, when meta-yocto-bsp picks it up as a reference...
>>>>> 
>>>>> Anyway, the biggest issue I'm trying to work around with this change is the 
>>>>> "shadowing" of the new-style DTBs that I ported from Dora to Dylan. If meta-ti 
>>>>> is not in front of oe-core, the old-style DTBs come into play and DTBs are not 
>>>>> built at all. So, this is not really an issue for Dora or master, and those 
>>>>> don't need to be prepended after all…
>>>> 
>>>> 
>>>> Now its even more intriguing since you changed meta-ti/master and I would 
>>>> have expected this change to show up in meta-ti/dylan or are you claiming 
>>>> all sort of oe-core branches to work with meta-ti/master thats a perilous 
>>>> path.
>>> 
>>> It's in meta-ti/dylan AND meta-ti/master,
>> 
>> yes. So can we change the master please ?
> 
> I'll think about it ;)
> 
> 
>> oe-core is also appending itself in BBPATH in oe-core/master
> 
> Yes, I know.
> 
> 
>> and so are meta-yocto-bsp and meta-beagleboard 
> 
> Also quite aware of that.
> 
> But since you mention meta-yocto-bsp, which is part of Poky, do you know that 
> meta-yocto prepends itself in front? And I believe there were one or two more 
> obscure layers doing that as well…

we can coerce them to change as well. if I have time I will go through
this on layers index. Its good in general to have this since its beneficial
and does larger good.

> 
> BTW, I like the comment you made in meta-oe long time ago:
> 
> # It really depends on order of the layers appearing in BBLAYERS
> # variable in toplevel bblayers.conf file, where bitbake will search
> # for .inc files and others where bitbake uses BBPATH since it will
> # search the directories from first to last as specified in BBPATH
> # Therefore if you want a given layer to be considered high priority
> # for the .inc and .conf etc. then consider it adding at the beginning
> # of BBPATH. For bblayers bitbake will use BBFILES_PRIORITY to resolve
> # the recipe contention so the order of directories in BBFILES does 
> # not matter.
> 
> But the problem is that people don't read comments and don't bother with 
> BBLAYERS order, hence I had to do what you suggested above with BBPATH order 
> instead!


amen

> 
> 
>> so with mere ordering of these layers in your distro’s bblayer.conf you 
>> should be able to get desired behaviour.
> 
> Well, it's not really a problem for Arago or Angstrom, as both provide setup 
> tools to generate the correct bblayers.conf with the proper order of BBLAYERS. 
> But the problem is really with Poky, as it expects people to manually add 
> extra layers to bblayers.conf and people just tend to append everything AFTER 
> oe-core and meta-yocto and meta-yocto-bsp. So, it's really Poky that is broken 
> or rather unclear…

yes and I think as long as all layers follow append model it will bring some santiy
to poky model as well.




^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2013-11-07 18:41 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-07  2:25 [PATCH] adjust BBPATH to be a good citizen of layer world Khem Raj
2013-11-07  4:29 ` Maupin, Chase
2013-11-07  4:55   ` Khem Raj
2013-11-07 16:59     ` Denys Dmytriyenko
2013-11-07 17:15       ` Khem Raj
2013-11-07 17:37         ` Denys Dmytriyenko
2013-11-07 17:42           ` Khem Raj
2013-11-07 17:47             ` Denys Dmytriyenko
2013-11-07 17:57               ` Khem Raj
2013-11-07 18:20                 ` Denys Dmytriyenko
2013-11-07 18:41                   ` Khem Raj
2013-11-07 17:01 ` Denys Dmytriyenko
2013-11-07 17:33   ` Khem Raj
2013-11-07 17:41     ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.